Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 754120 - sys-auth/seatd-0.4.0 uses -Werror for build
Summary: sys-auth/seatd-0.4.0 uses -Werror for build
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Haelwenn (lanodan) Monnier
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: werror
  Show dependency tree
 
Reported: 2020-11-12 08:49 UTC by Agostino Sarubbo
Modified: 2020-11-13 20:53 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2020-11-12 08:49:44 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sys-auth/seatd-0.4.0 uses -Werror for build.
Discovered on: amd64 (internal ref: ci)

-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html

NOTE: If you want to change the summary, to avoid auto-filed duplicates, please at least keep the word '-Werror'
Comment 1 Haelwenn (lanodan) Monnier 2020-11-13 02:20:42 UTC
Weh, thanks meson.eclass for not doing `-Dwerror=false` by default.
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-11-13 04:59:38 UTC
(In reply to Haelwenn Monnier from comment #1)
> Weh, thanks meson.eclass for not doing `-Dwerror=false` by default.

That may be worth filing a bug against the eclass for if it's a standard parameter.
Comment 3 Haelwenn (lanodan) Monnier 2020-11-13 17:38:41 UTC
(In reply to Sam James from comment #2)
> (In reply to Haelwenn Monnier from comment #1)
> > Weh, thanks meson.eclass for not doing `-Dwerror=false` by default.
> 
> That may be worth filing a bug against the eclass for if it's a standard
> parameter.

As far as I know it is, filled it in https://bugs.gentoo.org/754279
Comment 4 Larry the Git Cow gentoo-dev 2020-11-13 20:53:48 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c7051cc7228b8ddf4223e002b63c48ca45e8e193

commit c7051cc7228b8ddf4223e002b63c48ca45e8e193
Author:     Haelwenn (lanodan) Monnier <contact@hacktivis.me>
AuthorDate: 2020-11-13 02:27:47 +0000
Commit:     Aaron Bauman <bman@gentoo.org>
CommitDate: 2020-11-13 20:53:32 +0000

    sys-auth/seatd: Disable -Werror
    
    Closes: https://bugs.gentoo.org/754120
    Signed-off-by: Haelwenn (lanodan) Monnier <contact@hacktivis.me>
    Closes: https://github.com/gentoo/gentoo/pull/18237
    Signed-off-by: Aaron Bauman <bman@gentoo.org>

 sys-auth/seatd/seatd-0.4.0.ebuild | 1 +
 sys-auth/seatd/seatd-9999.ebuild  | 1 +
 2 files changed, 2 insertions(+)