Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 744658 - dev-libs/crc32c-1.0.6 uses -Werror for build
Summary: dev-libs/crc32c-1.0.6 uses -Werror for build
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Jason Zaman
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: werror 807025
  Show dependency tree
 
Reported: 2020-09-25 13:48 UTC by Agostino Sarubbo
Modified: 2021-09-05 16:41 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2020-09-25 13:48:48 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-libs/crc32c-1.0.6 uses -Werror for build.
Discovered on: amd64 (internal ref: ci)

-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html

NOTE: If you want to change the summary, to avoid auto-filed duplicates, please at least keep the word '-Werror'
Comment 1 Arthur Zamarin archtester Gentoo Infrastructure gentoo-dev Security 2021-08-21 08:01:37 UTC
The flag is added in the CMakeLists.txt file, in a separate step.
So we can remove the flag using:
sed -e '/-Werror/d' -i CMakeLists.txt
Comment 2 Larry the Git Cow gentoo-dev 2021-09-05 16:41:22 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7b5f5bec1046b618a945eb0ead4d4e4b44cb3bd9

commit 7b5f5bec1046b618a945eb0ead4d4e4b44cb3bd9
Author:     Arthur Zamarin <arthurzam@gentoo.org>
AuthorDate: 2021-09-05 16:33:46 +0000
Commit:     Arthur Zamarin <arthurzam@gentoo.org>
CommitDate: 2021-09-05 16:40:18 +0000

    dev-libs/crc32c: move to cmake.eclass, fix Werror
    
    Closes: https://bugs.gentoo.org/744658
    Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>

 dev-libs/crc32c/crc32c-1.0.6.ebuild | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)