Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 68762 - DSPAM has to narrow/unflexible set of enable/disable flags in the ebuild
Summary: DSPAM has to narrow/unflexible set of enable/disable flags in the ebuild
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Net-Mail Packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-10-24 17:14 UTC by steveb
Modified: 2005-01-09 07:13 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description steveb 2004-10-24 17:14:05 UTC
I need DSPAM with the following options:
--enable-domain-scale
--enable-source-address-tracking
--enable-spam-subject
--enable-signature-headers
--enable-whitelist

etc...


every time a new version of DSPAM hit's the portage, I need to tweak the ebuild to allow me certain enable/disable flags. Now to my question/request:

Can the ebuild not be extended to allow flexible options for enable/disable flags? Maybe something like this:

	# User selected options. Only --disable and --enable flags allowed
	if [[ "x${DSPAM_MYOPTS}" != "x" ]]
	then
		einfo "Parsing user specified compile options..."
		for foo in ${DSPAM_MYOPTS}
		do
			if [[ "${foo:0:9}" == "--enable-" || "${foo:0:10}" == "--disable-" ]]
			then
				einfo "User setting: ${foo}"
				clean_foo="${foo/--enable-/}"
				clean_foo="${clean_foo/--disable-/}"
				myconf="${myconf/--enable-${clean_foo}/}"
				myconf="${myconf/--disable-{$clean_foo/}"
				myconf="${myconf} ${foo}"
			fi
		done
	fi


The end-user could then use: DSPAM_MYOPTS="--enable-domain-scale" emerge DSPAM


With the above tweak the normal installation would not be influenced at all, while the advanced DSPAM user still could enable/disable flags the way she/he wants.


cheers

SteveB

Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 Torsten Veller (RETIRED) gentoo-dev 2004-10-25 00:58:53 UTC
You can also use EXTRA_ECONF:
EXTRA_ECONF="--enable-domain-scale --enable-source-address-tracking --enable-spam-subject --enable-signature-headers --enable-whitelist" emerge dspam

Problems:
- your settings are overwritten by the settings in the ebuild (afaics your flags are not set by the ebuild, so they are not replaced.)
Comment 2 Lim Swee Tat (RETIRED) gentoo-dev 2004-10-25 03:21:32 UTC
Hi,
  I think I do have a problem here, this create a large list of use flags for dspam since there are other options that seem to need to be addressed for the flexibility you are looking for.  But that said and done, I'll like to look into this too, since I know that this is gonna be a problem.
Comment 3 Rob Rosenfeld 2004-11-07 15:54:51 UTC
This ebuild needs to be updated for newer releases.

1.  myconf="${myconf} --enable-robinson"
    myconf="${myconf} --enable-robinson-pvalues"

From the README, http://dspam.nuclearelephant.com/text/README-3.2.1.txt
  --enable-robinson
       This algorithm is obsolete, and not recommended for production builds. 

  --enable-robinson-pvalues
   NOTE: This could potentially decrease accuracy when applied to other
   algorithms.

2.  Per UPGRADING.txt, some config options no longer needs to be specified at build time, but can be set in dspam.conf.

3.  --enable-large-scale is select by default
Perhaps it would benefit from local flags to handle this one?
Comment 4 Lim Swee Tat (RETIRED) gentoo-dev 2005-01-09 07:13:06 UTC
All these requirements have been integrated in the ebuild.