Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 674734 - www-client/weboob-2.0 version bump with Python 3 and Qt5 support
Summary: www-client/weboob-2.0 version bump with Python 3 and Qt5 support
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal
Deadline: 2020-04-26
Assignee: Patrick Lauer
URL:
Whiteboard:
Keywords: EBUILD, PMASKED, PullRequest
: 698982 (view as bug list)
Depends on:
Blocks: py3-tracker, python-3-incompatible
  Show dependency tree
 
Reported: 2019-01-06 21:17 UTC by Laurent Bachelier
Modified: 2020-05-11 05:02 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Fix URLs (0001-www-client-weboob-New-URLs.patch,4.27 KB, patch)
2019-01-06 21:18 UTC, Laurent Bachelier
Details | Diff
Add 1.4 & update git (0002-www-client-weboob-Add-1.4-remove-deprecated-dependen.patch,6.20 KB, patch)
2019-01-06 21:19 UTC, Laurent Bachelier
Details | Diff
Add 1.5 & update license (0003-www-client-weboob-Add-1.5-change-license.patch,5.76 KB, patch)
2019-03-04 15:33 UTC, Laurent Bachelier
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laurent Bachelier 2019-01-06 21:17:51 UTC
My patches also fix #674298

https://git.weboob.org/weboob/weboob/tags/1.4
https://pypi.org/project/weboob/1.4/#files

One dependency is removed (mechanize).

Weboob 2.0 should switch to Python 3 since that was the last dependency only working for Python 2.
Comment 1 Laurent Bachelier 2019-01-06 21:18:41 UTC
Created attachment 560142 [details, diff]
Fix URLs
Comment 2 Laurent Bachelier 2019-01-06 21:19:25 UTC
Created attachment 560144 [details, diff]
Add 1.4 & update git
Comment 3 bdouxx 2019-01-10 06:41:18 UTC
Hi

If weboob support python 3, why don't you put in the ebuild :  PYTHON_COMPAT=( python{2_7,3_4,3_5,3_6} )
In order to allow to compile with python 3?

Thank
Comment 4 Laurent Bachelier 2019-01-10 08:02:55 UTC
Good question!

Currently only the core library of Weboob has been tested with Python 3, and about half the modules (160 out of 267) are marked as working with Python 3.

There's still code that would lead to SyntaxError exceptions too.

So the support is currently only intended for developers, I fear it would lead to a lot of frustration for end-users and a lot of redundant bug reports.

Maybe as a masked USE flag? I haven't done something similar before, but I could look it up.
Comment 5 Laurent Bachelier 2019-03-04 15:33:06 UTC
Created attachment 567744 [details, diff]
Add 1.5 & update license
Comment 6 Laurent Bachelier 2019-03-04 15:34:11 UTC
Version 1.5 was released, I've added a patch

https://git.weboob.org/weboob/weboob/tags/1.5
Comment 7 Andreas Sturmlechner gentoo-dev 2019-12-09 12:45:11 UTC
*** Bug 698982 has been marked as a duplicate of this bug. ***
Comment 8 Andreas Sturmlechner gentoo-dev 2019-12-09 13:17:18 UTC
Laurent, it looks to me as if you're doing good work here. Would you be interested in proxy-maintaining this package? It means we would add your contact to the package's metadata.xml together with proxy-maint, and time-to-tree for your contributions should not take as long (does not rely on single maintainer) if you work with proxy-maint via GitHub PRs. You would also receive notifications about bugs.

https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers
https://devmanual.gentoo.org/
Comment 9 Laurent Bachelier 2019-12-09 13:41:21 UTC
Hello,
Yes I would be interested!

By the way our next version is going to be using Python 3 fully. 1.5 isn't very good for it *but* if it is really needed it could be done.
Comment 10 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-03-27 11:25:04 UTC
This is blocking cleanup of dev-python/html2text now.
Comment 11 Larry the Git Cow gentoo-dev 2020-03-27 16:51:52 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0e9749633e3483c5ffa69c41a41e668ba8836866

commit 0e9749633e3483c5ffa69c41a41e668ba8836866
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2020-03-27 16:43:43 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2020-03-27 16:51:41 +0000

    package.mask: Last rite www-client/weboob
    
    Bug: https://bugs.gentoo.org/674734
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 profiles/package.mask | 5 +++++
 1 file changed, 5 insertions(+)
Comment 12 Laurent Bachelier 2020-03-27 19:42:48 UTC
All this masking (first USE=X then the package) could have been prevented by updating the package as per the whole history of this bug report.

...anyway here is 2.0 in my overlay which is Python 3 only, now in two separate packages:
http://git.p.engu.in/laurentb/gentoo-overlay/tree/www-client/weboob
http://git.p.engu.in/laurentb/gentoo-overlay/tree/www-client/weboob-qt

Please tell me if you need more, e.g. .patch files or other changes.
Comment 13 Zoltan Puskas 2020-03-28 04:35:34 UTC
app-office/kmymoney depends on weboob to "Enable import of online banking transactions " and removing it will break it.
Comment 14 Andreas Sturmlechner gentoo-dev 2020-03-28 12:02:24 UTC
(In reply to Zoltan Puskas from comment #13)
> app-office/kmymoney depends on weboob to "Enable import of online banking
> transactions " and removing it will break it.
Are you a user of this, and would you test if kmymoney[weboob] actually works with weboob-2?
Comment 15 Zoltan Puskas 2020-03-29 07:01:43 UTC
(In reply to Andreas Sturmlechner from comment #14)
> (In reply to Zoltan Puskas from comment #13)
> > app-office/kmymoney depends on weboob to "Enable import of online banking
> > transactions " and removing it will break it.
> Are you a user of this, and would you test if kmymoney[weboob] actually
> works with weboob-2?

I don't think it will work out of the box, mainly because kmymoney's cmake configuration expects Python2 if weboob is enabled. I will play around patching it and see if it works with the new version, but it will also require moving kmymoney ebuild to Python3 (which is inherently a good thing). It may also require upstream support, however kmymoney issues are outside of the scope for this bug.
Comment 16 Zoltan Puskas 2020-03-29 07:06:47 UTC
(In reply to Laurent Bachelier from comment #12)
> All this masking (first USE=X then the package) could have been prevented by
> updating the package as per the whole history of this bug report.
> 
> ...anyway here is 2.0 in my overlay which is Python 3 only, now in two
> separate packages:
> http://git.p.engu.in/laurentb/gentoo-overlay/tree/www-client/weboob
> http://git.p.engu.in/laurentb/gentoo-overlay/tree/www-client/weboob-qt
> 
> Please tell me if you need more, e.g. .patch files or other changes.

I've put up a pull request to update www-client/weboob in the main portage tree to version 2.0, while dropping old 1.3 and unmasking it. I've also polished the ebuild up so it does not throw warnings. 

@Laurent: based on your comment #9 on this thread I've added you as a proxied maintainer to the ebuild, if you don't mind.

However I've removed the USE="X" option for the moment and the PR does not include the www-client/weboob-qt ebuild at the moment. The reason is that the aforementioned ebuild is quite broken and does not work properly. It will require more time to fix it up properly. @Laurent, some help would be welcome here.
Comment 17 Zoltan Puskas 2020-03-29 07:30:04 UTC
One more thing. I've removed Python 3.8 support from the ebuild as not all the dependencies in the tree are there yet, namely dev-python/unidecode.
Comment 18 Zoltan Puskas 2020-03-29 18:51:49 UTC
Actually @Laurent has to make the PR if we is willing to proxy-maintain the ebuild. I've cancelled mine.
Comment 19 Larry the Git Cow gentoo-dev 2020-04-27 08:14:06 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=469e9cdf10eaa4463981367d5340f364505d12b2

commit 469e9cdf10eaa4463981367d5340f364505d12b2
Author:     Mikle Kolyada <zlogene@gentoo.org>
AuthorDate: 2020-04-27 08:12:13 +0000
Commit:     Mikle Kolyada <zlogene@gentoo.org>
CommitDate: 2020-04-27 08:13:57 +0000

    www-client/weboob: remove last-rited pkg
    
    Closes: https://bugs.gentoo.org/674298
    Closes: https://bugs.gentoo.org/674734
    
    Signed-off-by: Mikle Kolyada <zlogene@gentoo.org>

 www-client/weboob/Manifest           |  1 -
 www-client/weboob/metadata.xml       | 13 -----
 www-client/weboob/weboob-1.3.ebuild  | 96 ------------------------------------
 www-client/weboob/weboob-9998.ebuild | 96 ------------------------------------
 www-client/weboob/weboob-9999.ebuild | 96 ------------------------------------
 5 files changed, 302 deletions(-)
Comment 20 Laurent Bachelier 2020-04-27 15:27:22 UTC
That's not a fix, sorry.