Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 657926 - kernel-2.eclass: Migrate patching from src_unpack to src_prepare ebuild phase, deprecate EAPI<4 support
Summary: kernel-2.eclass: Migrate patching from src_unpack to src_prepare ebuild phase...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Kernel Bug Wranglers and Kernel Maintainers
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2018-06-12 02:17 UTC by Michael 'veremitz' Everitt
Modified: 2023-01-31 12:47 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Move patch logic (kernel-2.eclass_bug657926.diff,4.20 KB, text/plain)
2018-08-09 00:41 UTC, Thomas Deutschmann (RETIRED) 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael 'veremitz' Everitt 2018-06-12 02:17:36 UTC 
Source patching currently takes place in the src_unpack phase of kernel-2.eclass and its child ebuilds. A historical note reminds us that EAPI0-1 didn't have the src_prepare ebuild phase, but any *-sources ebuilds using these EAPI's have long gone. In fact there are only two ebuilds currently in-tree using EAPI4 which is the lowest consumer of the eclass.

It is therefore proposed, to deprecate use of EAPI<4 within kernel-2.eclass, and migrate the patching functions into the src_prepare ebuild phase. This is a minor shift, mostly involving renaming, and moving a few functions into their new 'homes'.
Comment 1 Larry the Git Cow gentoo-dev 2018-07-29 23:48:26 UTC 
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3b73ebd9ac730549bb9edf5e8f9ff6614d08726a

commit 3b73ebd9ac730549bb9edf5e8f9ff6614d08726a
Author:     Marty E. Plummer <hanetzer@startmail.com>
AuthorDate: 2018-07-29 23:14:26 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2018-07-29 23:14:26 +0000

    kernel-2.eclass: drop EAPI 0-1 support code
    
    Also went ahead and dropped versionator in favor of eapi7-ver for EAPI 0-6,
    and eutils for epatch. multilib dropped as unneeded. All ebuilds using it
    tested with ebuild clean install clean.
    
    Bug: https://bugs.gentoo.org/657926
    Package-Manager: Portage-2.3.40, Repoman-2.3.9
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 eclass/kernel-2.eclass | 40 ++++++++++++++--------------------------
 1 file changed, 14 insertions(+), 26 deletions(-)
Comment 2 Michael 'veremitz' Everitt 2018-07-30 00:40:03 UTC 
(In reply to Larry the Git Cow from comment #1)
> The bug has been referenced in the following commit(s):
> 
> https://gitweb.gentoo.org/repo/gentoo.git/commit/
> ?id=3b73ebd9ac730549bb9edf5e8f9ff6614d08726a
> 
This only partially addresses the issue specified in the subject, which is part of PR #9064 (a wider cleanup).

Re-opening for now, until more of this PR is ready for merging.
Comment 3 Alice Ferrazzi Gentoo Infrastructure gentoo-dev 2018-07-30 06:45:15 UTC 
what is still missing from here ?
Comment 4 Thomas Deutschmann (RETIRED) gentoo-dev 2018-08-09 00:41:30 UTC 
Created attachment 542822 [details]
Move patch logic

Here's a patch. But I still don't know if we really need this. At the moment it looks like a code change for nothing...
Comment 5 Mike Pagano gentoo-dev 2021-09-15 22:51:50 UTC 
Michael, the link at :

https://devmanual.gentoo.org/eclass-reference/ebuild/index.html

Mentions patch in both unpack and prepare.

Should we still rework this ?
Comment 6 Mike Pagano gentoo-dev 2023-01-31 12:47:49 UTC 
I think we're ok here and within documented guidelines.