Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 644920 - app-laptop/laptop-mode-tools-1.71-r1 should depend on sys-apps/hdparm - laptop_mode: ERROR: hdparm not installed
Summary: app-laptop/laptop-mode-tools-1.71-r1 should depend on sys-apps/hdparm - lapto...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Alon Bar-Lev (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-18 09:04 UTC by Andrew Ammerlaan
Modified: 2018-09-01 07:21 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Ammerlaan gentoo-dev 2018-01-18 09:04:02 UTC
app-laptop/laptop-mode-tools-1.71-r1 complains about sys-apps/hdparm not being installed upon starting: "ERROR: hdparm not installed". I therefore request that sys-apps/hdparm be added as a dependency to >=app-laptop/laptop-mode-tools-1.71-r1
Comment 1 Alon Bar-Lev (RETIRED) gentoo-dev 2018-01-18 14:42:03 UTC
Hi,
When do you get that? Not during installation, right?
There are lots of utilities laptop_mode_tools requires, we do not want to force them if not actually used.
hdparm is long retired as libata in kernel is providing scsi interface.

Maybe I should also change ASSUME_SCSI_IS_SATA=0 as default.
Comment 2 Andrew Ammerlaan gentoo-dev 2018-02-01 20:59:32 UTC
Hi, sorry for the late reply, I seem to have forgotten to add myself to the CC-list.

No, it's not during install, just during start and stop of laptop-mode-tools. If it's harmless then I suppose there is indeed no point in forcing an extra dependency. 
I merely thought that laptop-mode-tools might not work at all if it was missing hdparm. The way the error message is printed makes it seem rather serious.
Comment 3 Igor Kotrasiński 2018-05-07 22:31:39 UTC
I can confirm the same message happening on 1.72.2. Quick grep suggests that the error line is in /usr/share/laptop-mode-tools/modules/hdparm:209. Surrounding code suggests that either hdparm or sdparm (also dependent on the drive type operated on) is required to change drive power management.

Additionally Arch wiki (https://wiki.archlinux.org/index.php/Laptop_Mode_Tools#Hard_disks) claims that either sdparm or hdparm is required to control drive spin up / down.
Comment 4 Larry the Git Cow gentoo-dev 2018-09-01 07:21:39 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=692632c4e1fd984551915af8a658c558ce39c7b5

commit 692632c4e1fd984551915af8a658c558ce39c7b5
Author:     Alon Bar-Lev <alonbl@gentoo.org>
AuthorDate: 2018-09-01 07:17:40 +0000
Commit:     Alon Bar-Lev <alonbl@gentoo.org>
CommitDate: 2018-09-01 07:20:33 +0000

    app-laptop/laptop-mode-tools: re-add sdparm/hdparm dependency
    
    Closes: https://bugs.gentoo.org/show_bug.cgi?id=644920
    Package-Manager: Portage-2.3.40, Repoman-2.3.9

 app-laptop/laptop-mode-tools/laptop-mode-tools-1.72.2.ebuild | 4 ++++
 1 file changed, 4 insertions(+)