63568 – xorg-x11 : evdev keyboard case sensitivity patch

Bug 63568 - xorg-x11 : evdev keyboard case sensitivity patch

Summary: xorg-x11 : evdev keyboard case sensitivity patch

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	High minor (vote)
Assignee:	Gentoo X packagers

URL:
Whiteboard:
Keywords:	Inclusion

Duplicates (1):	65090 (view as bug list)
Depends on:
Blocks:

Reported:	2004-09-10 10:23 UTC by Alan Swanson
Modified:	2004-10-11 02:19 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
9001-evdev-patch.diff (9001-evdev-patch.diff,772 bytes, patch) 2004-09-10 10:24 UTC, Alan Swanson	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Alan Swanson 2004-09-10 10:23:50 UTC

Anybody who has been using the keyboard entry 'Option "Protocol" "Standard"' with xorg (or xfree) will, after updating to a version built with the evdev patches, have a non-working X due to a CoreKeyboard not found error.

Problem is the evdev patches make this option value case sensitive in contrast with the original code and the man page which shows capitals. No recognised protocol, no keyboard.

Attached is a patch to the 9001_all_4.3.0-lnx-evdev-keyboard.patch file. This uses the xf86NameCmp function instead of strcmp, reduces the code and allows the standard keyboard function to return the unrecognised protocol error message.

(Should perhaps also replace strcmp with xf86NameCmp in 9000_all_6.7.99.2-lnx-evdev-core-v2.patch aswell?)

Comment 1 Alan Swanson 2004-09-10 10:24:25 UTC

Created attachment 39330 [details, diff]
9001-evdev-patch.diff

Comment 2 Donnie Berkholz (RETIRED) gentoo-dev

2004-10-07 16:05:59 UTC

Great idea, thanks for the patch! I'll try to get this in soon.

Comment 3 Donnie Berkholz (RETIRED) gentoo-dev

2004-10-07 16:39:08 UTC

*** Bug 65090 has been marked as a duplicate of this bug. ***

Comment 4 Donnie Berkholz (RETIRED) gentoo-dev

2004-10-11 02:19:49 UTC

This is in 6.8.0-r1 and -r2, patchset 0.2.2. Thanks! Have you sent this upstream, by the way? If not, please file a bug at bugs.freedesktop.org and post the bug number here.