Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 620814 - media-sound/helm: binary file in gentoo repository
Summary: media-sound/helm: binary file in gentoo repository
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal QA (vote)
Assignee: Professional Audio Applications Maintainers
URL: https://qa-reports.gentoo.org/output/...
Whiteboard:
Keywords:
Depends on:
Blocks: binaries-in-git
  Show dependency tree
 
Reported: 2017-06-04 17:06 UTC by Ulrich Müller
Modified: 2017-06-07 00:21 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2017-06-04 17:06:02 UTC
As reported, see URL: 
media-sound/helm/files/helm-0.4.1-gcc6.patch: application/octet-stream; charset=binary (size=992)

Policy reference:
https://devmanual.gentoo.org/general-concepts/tree/index.html#what-belongs-in-the-tree%3F
Comment 1 Ulrich Müller gentoo-dev 2017-06-06 07:35:24 UTC
Looks like the bad file originates from this PR:
https://github.com/gentoo/gentoo/pull/4754
Comment 2 Peter Levine 2017-06-06 16:07:25 UTC
(In reply to Ulrich Müller from comment #1)
> Looks like the bad file originates from this PR:
> https://github.com/gentoo/gentoo/pull/4754

That's mine.  The patch is a pretty straight forward text file.  How is it that that is being interpreted as a binary file?
Comment 3 Ulrich Müller gentoo-dev 2017-06-06 19:29:32 UTC
(In reply to Peter Levine from comment #2)
> The patch is a pretty straight forward text file.  How is it that that is
> being interpreted as a binary file?

The file contained some garbage characters in the commit message (which are not visible in github's web interface). No idea if they were there in the original patch, or if it's some later corruption.

It should be fixed now:
https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=83b1bbf35b53f7becef8bba1f5c11ede1d57e0e1
Comment 4 Peter Levine 2017-06-07 00:21:38 UTC
(In reply to Ulrich Müller from comment #3)
> (In reply to Peter Levine from comment #2)
> > The patch is a pretty straight forward text file.  How is it that that is
> > being interpreted as a binary file?
> 
> The file contained some garbage characters in the commit message (which are
> not visible in github's web interface). No idea if they were there in the
> original patch, or if it's some later corruption.
> 
> It should be fixed now:
> https://gitweb.gentoo.org/repo/gentoo.git/commit/
> ?id=83b1bbf35b53f7becef8bba1f5c11ede1d57e0e1

OK.  It might have been a Unicode BOM which I accidentally enabled a while back.