Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 607654 - net-p2p/qbittorrent-3.3.10: please stabilise
Summary: net-p2p/qbittorrent-3.3.10: please stabilise
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Stabilization (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Markos Chandras (RETIRED)
URL:
Whiteboard:
Keywords: STABLEREQ
Depends on: 530720 607734
Blocks:
  Show dependency tree
 
Reported: 2017-01-29 20:04 UTC by David Seifert
Modified: 2017-04-25 08:38 UTC (History)
1 user (show)

See Also:
Package list:
=net-p2p/qbittorrent-3.3.10
Runtime testing required: No
stable-bot: sanity-check-


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Seifert gentoo-dev 2017-01-29 20:04:17 UTC
please stabilise
Comment 1 Gleb 2017-01-29 20:11:47 UTC
https://bugs.gentoo.org/show_bug.cgi?id=530720 - what about this request?
Comment 2 Davide Pesavento (RETIRED) gentoo-dev 2017-01-29 20:33:13 UTC
David, you need to explain this stablereq a bit better than "please stabilise". qbittorrent-3.3.10 was added to the tree *minutes* ago. Are you not aware of the 30-day policy for stabilizations? If you need an exception, you should definitely explain why. The new ebuild seems to have major changes (the build system changed completely) compared to the current stable candidate (3.3.7)... and there's also bug 530720...
Comment 3 David Seifert gentoo-dev 2017-01-29 20:59:24 UTC
(In reply to Davide Pesavento from comment #2)
> David, you need to explain this stablereq a bit better than "please
> stabilise". qbittorrent-3.3.10 was added to the tree *minutes* ago. Are you
> not aware of the 30-day policy for stabilizations? If you need an exception,
> you should definitely explain why. The new ebuild seems to have major
> changes (the build system changed completely) compared to the current stable
> candidate (3.3.7)... and there's also bug 530720...

Given that 99% of Stablereqs are purely compile checks, I don't really see major useability testing as an obstacle with stablereqs nowadays anymore (I've seen way too many stablereqs that went through fine, yet were not stable). I've tried all use flag combinations, and it worked fine me, the GUI seemed ok etc.

I've tested it and it solves all the 3 outstanding bugs against qbittorrent + gets rid of Qt4 (now that upstream by default also prefers Qt5).

You can close this if you like.
Comment 4 Stabilization helper bot gentoo-dev 2017-01-29 21:05:57 UTC
An automated check of this bug failed - repoman reported dependency errors (51 lines truncated): 

> dependency.bad net-p2p/qbittorrent/qbittorrent-3.3.10.ebuild: DEPEND: amd64(default/linux/amd64/13.0) ['>=net-libs/rb_libtorrent-1.0.6']
> dependency.bad net-p2p/qbittorrent/qbittorrent-3.3.10.ebuild: RDEPEND: amd64(default/linux/amd64/13.0) ['>=net-libs/rb_libtorrent-1.0.6']
> dependency.bad net-p2p/qbittorrent/qbittorrent-3.3.10.ebuild: DEPEND: amd64(default/linux/amd64/13.0/desktop) ['>=net-libs/rb_libtorrent-1.0.6']
Comment 5 Davide Pesavento (RETIRED) gentoo-dev 2017-01-31 02:15:05 UTC
(In reply to David Seifert from comment #3)
> (In reply to Davide Pesavento from comment #2)
> > David, you need to explain this stablereq a bit better than "please
> > stabilise". qbittorrent-3.3.10 was added to the tree *minutes* ago. Are you
> > not aware of the 30-day policy for stabilizations? If you need an exception,
> > you should definitely explain why. The new ebuild seems to have major
> > changes (the build system changed completely) compared to the current stable
> > candidate (3.3.7)... and there's also bug 530720...
> 
> Given that 99% of Stablereqs are purely compile checks, I don't really see
> major useability testing as an obstacle with stablereqs nowadays anymore
> (I've seen way too many stablereqs that went through fine, yet were not
> stable). I've tried all use flag combinations, and it worked fine me, the
> GUI seemed ok etc.
> 
> I've tested it and it solves all the 3 outstanding bugs against qbittorrent
> + gets rid of Qt4 (now that upstream by default also prefers Qt5).

That's not the point. If there's a policy you should follow it (again, motivated exceptions such as security issues aside). If you don't like the policy, come up with a proposal to change it, don't simply ignore it.
Comment 6 Andreas Sturmlechner gentoo-dev 2017-03-06 21:00:10 UTC
If 3.3.11 fixes these issues - it has a big Changelog - maybe we can stabilise it instead of .10 and take the usual 30 day threshold with a grain of salt, in face of current stable qbittorrent being apparently broken.
Comment 7 Andreas Sturmlechner gentoo-dev 2017-03-07 22:28:58 UTC
@pesa, so bug 607734 looks wholly invalid and should not block this anymore.

Can we simply replace 3.3.7 with 3.3.10 in bug 530720 to resolve this standoff?
Comment 8 Davide Pesavento (RETIRED) gentoo-dev 2017-03-09 04:25:03 UTC
(In reply to Andreas Sturmlechner from comment #7)
> Can we simply replace 3.3.7 with 3.3.10 in bug 530720 to resolve this
> standoff?

Sounds good to me.
Comment 9 Michael Palimaka (kensington) gentoo-dev 2017-04-25 08:38:27 UTC
Stabilisation was completed in bug #530720.