Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 599938 - x11-drivers/xf86-input-keyboard-1.8.1: build fails with >=x11-base/xorg-server-1.19.0
Summary: x11-drivers/xf86-input-keyboard-1.8.1: build fails with >=x11-base/xorg-serve...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal with 1 vote (vote)
Assignee: Gentoo X packagers
URL: https://cgit.freedesktop.org/xorg/dri...
Whiteboard:
Keywords:
: 599954 (view as bug list)
Depends on:
Blocks: xorg-1.19
  Show dependency tree
 
Reported: 2016-11-16 03:41 UTC by Alexander Turenko
Modified: 2016-11-17 21:50 UTC (History)
10 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Proposed patch, for convenience (fix_build_xorg_1.19.patch,904 bytes, patch)
2016-11-16 08:57 UTC, Kamil Kamiński 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Turenko 2016-11-16 03:41:03 UTC 
The patch from URL field makes it able to be built.
Comment 1 Kamil Kamiński 2016-11-16 08:57:06 UTC 
Created attachment 453430 [details, diff]
Proposed patch, for convenience

After applying, xf86-input-keyboard-1.8.1 builds fine.
Comment 2 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2016-11-16 10:55:29 UTC 
*** Bug 599954 has been marked as a duplicate of this bug. ***
Comment 3 Alex Turbov 2016-11-16 18:28:07 UTC 
+1 (patch works for me)
Comment 4 lekto 2016-11-16 22:18:14 UTC 
Patch works for me on nomultilib too.
Comment 5 max parmer 2016-11-17 01:17:32 UTC 
Build was failing with:

> /var/tmp/portage/x11-drivers/xf86-input-keyboard-1.8.1/work/xf86-input-keyboard-1.8.1/src/kbd.c: In function 'KbdProc':
> /var/tmp/portage/x11-drivers/xf86-input-keyboard-1.8.1/work/xf86-input-keyboard-1.8.1/src/kbd.c:386:2: error: implicit declaration of function 'AddEnabledDevice' [-Werror=implicit-function-decla
ration]
>   AddEnabledDevice(pInfo->fd);
>   ^
> /var/tmp/portage/x11-drivers/xf86-input-keyboard-1.8.1/work/xf86-input-keyboard-1.8.1/src/kbd.c:386:2: warning: nested extern declaration of 'AddEnabledDevice' [-Wnested-externs]
> /var/tmp/portage/x11-drivers/xf86-input-keyboard-1.8.1/work/xf86-input-keyboard-1.8.1/src/kbd.c:400:7: error: implicit declaration of function 'RemoveEnabledDevice' [-Werror=implicit-function-de
claration]
>        RemoveEnabledDevice(pInfo->fd);
>        ^
> /var/tmp/portage/x11-drivers/xf86-input-keyboard-1.8.1/work/xf86-input-keyboard-1.8.1/src/kbd.c:400:7: warning: nested extern declaration of 'RemoveEnabledDevice' [-Wnested-externs]
> cc1: some warnings being treated as errors

Proposed patch resolves this.
Comment 6 cam++ 2016-11-17 16:36:32 UTC 
Simple, install xf86-input-keyboard.1.9.0 !!
Comment 7 Toralf Förster gentoo-dev 2016-11-17 16:45:30 UTC 
This is a tinderbox.
If a package fails it should correct its (r)deps.
Comment 8 Ooblick 2016-11-17 16:52:27 UTC 
xf86-input-keyboard-1.9 is released https://www.x.org/releases/individual/driver/xf86-input-keyboard-1.9.0.tar.bz2
Comment 9 Alexander Turenko 2016-11-17 16:53:41 UTC 
Yep, the upstream tagged 1.9.0 12 hours ago :)
Comment 10 Manuel Rüger (RETIRED) gentoo-dev 2016-11-17 21:50:32 UTC 
commit 3e8ece145d930f6ad7d25133c11d2a0a7e6db83a
Author: Manuel Rüger <mrueg@gentoo.org>
Date:   Thu Nov 17 22:41:37 2016 +0100

    x11-drivers/xf86-input-keyboard: Version bump to 1.9.0
    
    Supports xorg-server-1.19
    
    Gentoo-Bug: 599938
    
    Package-Manager: portage-2.3.2