Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 589480 - media-sound/pulseaudio: use of REPLACING_VERSIONS does not account for multiple values
Summary: media-sound/pulseaudio: use of REPLACING_VERSIONS does not account for multip...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal QA (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords: QAcanfix
Depends on:
Blocks: 589444
  Show dependency tree
 
Reported: 2016-07-23 12:43 UTC by Michał Górny
Modified: 2017-03-28 12:21 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2016-07-23 12:43:47 UTC
See the tracker bug.

  if ! version_is_at_least 6.0 ${REPLACING_VERSIONS}; then

This is going to fail hard when RV is empty or has >1 value.
Comment 1 Pacho Ramos gentoo-dev 2016-07-24 12:54:24 UTC
Well, in this case REPLACING_VERSIONS will always be only one as this has no SLOTs and updates will always be from an unique older version to latest one... should we still move this to the larger form then? :/ (well, this applies to many other bugs assigned to gnome team about this)
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2016-07-24 12:57:55 UTC
You are wrong as explained in the post linked to the tracker. And yes, you have to use 'for'. That's the spec.
Comment 3 Mart Raudsepp gentoo-dev 2017-03-28 12:21:19 UTC
commit d57025ab1a8a0606f6ee83800fd00b35d843d084
Author: Mart Raudsepp <leio@gentoo.org>
Date:   Tue Mar 28 13:46:22 2017 +0300

    media-sound/pulseaudio: clarify equalizer licensing, handle split speexdsp, remove ancient v6 upgrade handling
    
    PA-6 is well over a year old (with at least a year ago in stable) that needed this upgrade path,
    so just remove the REPLACING_VERSIONS handling code instead of fixing it up.
    qpaeq is AGPL-3+, so declare it properly. It also needs dbus to get built (the sink module build
    requires both HAVE_FFTW and HAVE_DBUS).
    Tweak dependencies to pull in split speexdsp when needed.
    Also update check dependency minimum version to match configure.ac (albeit we don't have any older
    versions in tree).
    
    Gentoo-bug: 589480
    Gentoo-bug: 611660