When ~app-editors/emacs-24.5 is built with x11-libs/gtk+-3.20.6 (and possibly anything over 3.10) no icons are shown in toolbar. It is a known bug, people from Arch have already hit it: https://bugs.archlinux.org/task/48862 and backported a fix: https://git.archlinux.org/svntogit/packages.git/tree/trunk/0001-Fix-48862.patch?h=packages/emacs . With this patch applied icons on toolbar are present again.
Upstream commit: http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3f4c6d52d345999938bc2d4a53246af4c61ef176
Created attachment 440640 [details, diff] Fix icons in toolbar with GTK+ 3.20.6. With the fix from Arch I get several compiler warnings about unused code in gtkutil.c: gtkutil.c: In function ‘xg_update_menubar’: gtkutil.c:2844:22: warning: unused variable ‘submenu’ [-Wunused-variable] GtkWidget *submenu = gtk_menu_item_get_submenu (witem); ^ gtkutil.c: In function ‘xg_update_submenu’: gtkutil.c:3077:7: warning: unused variable ‘has_tearoff_p’ [-Wunused-variable] bool has_tearoff_p = 0; ^ gtkutil.c: At top level: gtkutil.c:3916:1: warning: ‘xg_tool_bar_proxy_callback’ defined but not used [-Wunused-function] xg_tool_bar_proxy_callback (GtkWidget *w, gpointer client_data) ^ gtkutil.c:3933:1: warning: ‘xg_tool_bar_proxy_help_callback’ defined but not used [-Wunused-function] xg_tool_bar_proxy_help_callback (GtkWidget *w, ^ Please try if attached patch (which comprises the original upstream commit 3f4c6d52, plus subsequent cleanups ac225d22, 6e5ff616, and 4e946894) fixes the problem for you.
(In reply to Ulrich Müller from comment #2) > Created attachment 440640 [details, diff] [details, diff] > Fix icons in toolbar with GTK+ 3.20.6. (..) > Please try if attached patch (which comprises the original upstream commit > 3f4c6d52, plus subsequent cleanups ac225d22, 6e5ff616, and 4e946894) fixes > the problem for you. Icons in toolbar are present and seem to work fine with your patch - thanks.
Fixed in emacs-24.5-r2. Thank you for reporting and for pinpointing the problem.
