Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 58282 - Exim needs SPF support
Summary: Exim needs SPF support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Server (show other bugs)
Hardware: x86 Linux
: High enhancement (vote)
Assignee: Colin Morey (RETIRED)
URL:
Whiteboard:
Keywords:
: 61336 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-07-25 06:26 UTC by Cal Evans
Modified: 2006-03-05 13:47 UTC (History)
8 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Exim 4.41 w/spf (exim-4.41.ebuild,7.78 KB, text/plain)
2004-07-25 06:34 UTC, Cal Evans
Details
Ebuild to support SPF/SRS (exim-4.43-r1.ebuild,7.94 KB, text/plain)
2004-10-21 04:24 UTC, Sheldon Hearn
Details
Required by exim-4.43-r1.ebuild (exim-4.43-srs2.patch,17.01 KB, text/plain)
2004-10-21 04:25 UTC, Sheldon Hearn
Details
exim-4.50-r2.ebuild (exim-4.50-r2.ebuild,8.15 KB, text/plain)
2005-04-03 11:34 UTC, Sheldon Hearn
Details
files/exim-4.50-srs_update.patch (exim-4.50-srs_update.patch,17.94 KB, patch)
2005-04-03 11:36 UTC, Sheldon Hearn
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Cal Evans 2004-07-25 06:26:14 UTC
Exim/exiscan now support libspf2 library.  I'd like to see a new SPF keyword to compile in support for this.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Actual Results:  
Attached is a modified ebuild for exim 4.41.  I've added a kludge to support
SPF.   It does not check for exiscan support which is required for SPF support.

Also, libspf2 has to be compiled first.  I got the ebuild for here:
http://www.libspf2.org/download.html. and created a directory for it in
mail-mta. Then I added a dependancy in the ebuild.

Exim expects the include directory to be named spf_alt so I had to make a
symlink from /usr/include/spf2 to /usr/include/spf_alt.
Comment 1 Cal Evans 2004-07-25 06:34:06 UTC
Created attachment 36115 [details]
Exim 4.41 w/spf
Comment 2 Jay Pfeifer (RETIRED) gentoo-dev 2004-07-25 09:01:40 UTC
There are ebuilds in portage for libspf2/libsrs2. However, look for them in 'mail-filter'. Am already working on adding SPF support to the exim ebuild.

Have a good one,

Jay
Comment 3 Sven Wegener gentoo-dev 2004-10-04 05:41:33 UTC
*** Bug 61336 has been marked as a duplicate of this bug. ***
Comment 4 Sven Wegener gentoo-dev 2004-10-04 05:42:17 UTC
Jay, any status on this? I would like to add SPF to my exim mail servers.
Comment 5 Jay Pfeifer (RETIRED) gentoo-dev 2004-10-07 14:06:41 UTC
Sven,

I am now testing with exim-4.43. So hopefully this should be an add real soon.

Jay
Comment 6 Sheldon Hearn 2004-10-21 04:24:26 UTC
Created attachment 42301 [details]
Ebuild to support SPF/SRS

Copied from exim-4.43.ebuild, but extended to support SPF/SRS.
Comment 7 Sheldon Hearn 2004-10-21 04:25:42 UTC
Created attachment 42302 [details]
Required by exim-4.43-r1.ebuild

This is files/exim-4.43-srs2.patch, required by attached exim-4.43-r1.ebuild.
Comment 8 Sheldon Hearn 2004-10-21 04:27:52 UTC
Once again, here's a version of the latest ebuild that supports SPF and SRS. :-)

It's attached as exim-4.43-r1.ebuild, and depends on the attached files/exim-4.43-srs2.patch.
Comment 9 Daniel Lawson 2004-11-01 01:20:32 UTC
Sheldon,

Where did you get files/exim-4.43-srs2.patch from?  Much of the patch seems to be dealing with changed whitespace, and it makes it hard for me to see what's going on. I want to test this patch, but would like a cleaner patch before I do so, if that is possible.

Comment 10 Christian Loitsch 2004-11-02 01:25:03 UTC
not that I really mind, as long as spf and srs get into the ebuild, but why don't you use the ebuild proposed in <http://bugs.gentoo.org/show_bug.cgi?id=61336>
?

There the patch for exiscan comes from a freebsd guy (as mentioned in one comment).
Comment 11 Kent Martin 2004-11-05 04:57:10 UTC
I too am keen to see this implemented.
Comment 12 Daniel Lawson 2004-12-09 21:30:14 UTC
I've tested this, and it seems to work fine. 

I'd still like a cleaner patch, as it changes a lot of stuff with only whitespace changes. Can you re-diff with -bB please?
Comment 13 Sheldon Hearn 2005-04-03 10:18:05 UTC
I'm almost done with a new exim-4.50-r2.ebuild that adds spf and srs support, using libspf2 and libsrs_alt, as per the new integrated exiscan-acl.  I believe this will satisfy the request for a cleaner patch. :-)

I'll submit my libsrs_alt-1.0_rc1.ebuild as another bug, and refer to it when I submit the new exim ebuild.

-- Sheldon
Comment 14 Sheldon Hearn 2005-04-03 11:34:45 UTC
Created attachment 55220 [details]
exim-4.50-r2.ebuild

Supports SPF and SRS using libspf2 and libsrs_alt. Requires
files/exim-4.50-srs_update.patch (to be attached).
Comment 15 Sheldon Hearn 2005-04-03 11:36:12 UTC
Created attachment 55221 [details, diff]
files/exim-4.50-srs_update.patch

Required by exim-4.50-r2.ebuild.  Taken from the libsrs_alt distribution itself
(also under GPL).
Comment 16 Sheldon Hearn 2005-04-03 11:39:46 UTC
I've added exim-4.50-r2.ebuild and files/exim-4.50-srs_update.patch.

This introduces two new use flags, spf and srs, the latter of which requires libsrs_alt.  I've submitted an ebuild for libsrs_alt on bug #87821.

The patch (files/exim-4.50-srs_update.patch) is taken from the libsrs_alt distribution itself, and the author is pushing to have it incorporated into the exim distribution.  So it's pretty official. :-)

Hopefully you'll agree that this is much cleaner.
Comment 17 Sheldon Hearn 2005-04-05 16:37:18 UTC
I've now been using this in production on various servers with different configurations for a couple of days without incident.

Ciao,
Sheldon.
Comment 18 Sheldon Hearn 2005-06-19 02:09:32 UTC
Am I wasting my time submitting updates?  I get the feeling the Exim ebuild  
maintainer is a bit of a blackhole.  
  
If you'd like me to submit another update, could you please let me know what  
was wrong with the last one that led to no action being taken on it?  
 
I don't mind contributing the fruits of my effort to the project, but nobody 
likes to waste time. 
Comment 19 Colin Morey (RETIRED) gentoo-dev 2005-06-20 01:36:12 UTC
Well, i've been called many things in my time, but not a blackhole :) (can't
speak  for Jay though.)
Please accept my apologies for this bug taking so long to resolve, I've been
wrapping up one period of employment and starting another and was on the road
for most of May. I'll be adding it into the tree later on today/this week after
some initial testing.
Comment 20 Andreas Bulling 2005-07-14 02:36:10 UTC
exim-4.50-r2 (in portage) fails to compile if use flag spf is set:

---
>>> config.h built

make[2]: Entering directory
`/var/tmp/portage/exim-4.50-r2/work/exim-4.50/build-exim-gentoo/pcre'
gcc -c -march=athlon-xp -O3 -pipe -fomit-frame-pointer  maketables.c
gcc -c -march=athlon-xp -O3 -pipe -fomit-frame-pointer  get.c
gcc -o dftables -march=athlon-xp -O3 -pipe -fomit-frame-pointer  dftables.c
./dftables chartables.c
gcc -c -march=athlon-xp -O3 -pipe -fomit-frame-pointer  pcre.c
gcc -c -march=athlon-xp -O3 -pipe -fomit-frame-pointer  study.c
rm -f libpcre.a
ar cq libpcre.a maketables.o get.o pcre.o study.o
ranlib libpcre.a
gcc -c -DNOPOSIX -march=athlon-xp -O3 -pipe -fomit-frame-pointer  -I. pcretest.c
gcc -march=athlon-xp -O3 -pipe -fomit-frame-pointer  -o ../pcretest pcretest.o
libpcre.a
make[2]: Leaving directory
`/var/tmp/portage/exim-4.50-r2/work/exim-4.50/build-exim-gentoo/pcre'
/bin/sh ../scripts/Configure-eximon
sed \
  -e "s?PROCESSED_FLAG?This file has been so processed.?"\
  -e "/^# /p" \
  -e "/^# /d" \
  -e "s?CONFIGURE_FILE_USE_NODE??" \
  -e "s?CONFIGURE_FILE?/etc/exim/exim.conf?" \
  -e "s?BIN_DIRECTORY?/usr/sbin?" \
  -e "s?BASENAME_COMMAND?look_for_it?" \
  -e "s?HOSTNAME_COMMAND?/bin/hostname?" \
  -e "s?X11_LD_LIBRARY?/usr/X11R6/lib?" \
  ../src/eximon.src >> eximon
>>> eximon script built

gcc -c -march=athlon-xp -O3 -pipe -fomit-frame-pointer  -DCOMPILE_UTILITY -o
util-spool_in.o spool_in.c
In file included from /usr/include/spf2/spf_server.h:22,
                 from /usr/include/spf2/spf.h:27,
                 from spf.h:13,
                 from exim.h:400,
                 from spool_in.c:14:
/usr/include/spf2/spf_dns.h:82: error: conflicting types for 'ns_type'
/usr/include/arpa/nameser.h:302: error: previous declaration of 'ns_type' was here
In file included from /usr/include/spf2/spf.h:27,
                 from spf.h:13,
                 from exim.h:400,
                 from spool_in.c:14:
/usr/include/spf2/spf_server.h:23:30: spf_dns_internal.h: No such file or directory
make[1]: *** [util-spool_in.o] Error 1
make[1]: Leaving directory
`/var/tmp/portage/exim-4.50-r2/work/exim-4.50/build-exim-gentoo'
make: *** [go] Error 2
---
Comment 21 Colin Morey (RETIRED) gentoo-dev 2005-07-14 14:10:34 UTC
(In reply to comment #20)
> exim-4.50-r2 (in portage) fails to compile if use flag spf is set:
Could you please post a new bug (so as not to fill this one) and include the output of emerge info.

Cheers
Comment 22 Sheldon Hearn 2005-07-28 03:24:21 UTC
You can pick up my latest ebuild (exim-4.52.ebuild) on bug #99412. 
It relies on an updated libspf2 ebuild on bug #100569. 
It also relies on the libsrs_alt ebuild on bug #58282. 
 
Both the SRS and SPF support have been tested. 
 
This would allow you to close at least 4 bugs. 
 
Action on this bug would be great.  I've been faithfully submitting updated 
ebuilds and patches on this for a while, now.  As in, 9 months. :-) 
  
Comment 23 Colin Morey (RETIRED) gentoo-dev 2005-07-28 03:38:41 UTC
the exim-4.50-r2 has some of your changes in it iirc, (I will confirm tonight),
the reason this hasn't been carried forward to 4.52 is due to the bug report
about  spf. (you should also find your libsrs_alt ebuild now in the tree).

(this has been in for a few weeks.) I can only apologise for the delay in
getting srs and spf support into exim, both exim maintainers have been very busy
as late, (hence the skip from 4.50 to 4.51
Comment 24 Sheldon Hearn 2005-07-28 03:45:02 UTC
Oops.  I didn't check to see whether the libsrs_alt ebuild had been committed.   
 
I'll remove it from my local tree and eagerly await libspf2-1.2.5-r1 and 
exim-4.52.  Thanks. :-) 
Comment 25 Colin Morey (RETIRED) gentoo-dev 2006-02-23 12:06:20 UTC
Sheldon, can i close this bug now?
Comment 26 Sheldon Hearn 2006-02-23 20:32:37 UTC
(In reply to comment #25)
> Sheldon, can i close this bug now?

Yeah, thanks Colin.  When I do a domainkeys patch, I'll open a new bug for that. :-)
Comment 27 Colin Morey (RETIRED) gentoo-dev 2006-03-05 13:47:02 UTC
closing Bug.