Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 563588 - app-misc/geoclue:0: drop old version from the tree
Summary: app-misc/geoclue:0: drop old version from the tree
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords: NeedPatch, UPSTREAM
: 631730 (view as bug list)
Depends on: 576006 qt-5.11.3-stable
Blocks:
  Show dependency tree
 
Reported: 2015-10-20 19:15 UTC by Steve Arnold
Modified: 2019-03-09 08:40 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Arnold archtester gentoo-dev 2015-10-20 19:15:08 UTC
On my desktop, the older geoclue is pulled in by python-geoclue and zeitgeist-extensions with USE=geolocation but it can't compile with the latest gpsd (seems like it started failing around gpsd-3.11 or so (3.10 seems okay).  Is there a zeitgeist and/or python-geoclue upgrade that can make the old version of geoclue obsolete?

distcc[10141] ERROR: compile /var/tmp/ccache/tmp/geoclue-gp.stdout.genchrome.101
33.w8VKFj.i on localhost failed
geoclue-gpsd.c: In function ‘gpsd_raw_hook’:
geoclue-gpsd.c:379:31: error: ‘gps_data_l’ has no member named ‘tag’
  char *tag_str = gpsd->gpsdata->tag;
                               ^
geoclue-gpsd.c: In function ‘main’:
geoclue-gpsd.c:534:2: warning: ‘g_type_init’ is deprecated (declared at /usr/inc
lude/glib-2.0/gobject/gtype.h:681) [-Wdeprecated-declarations]
  g_type_init ();
  ^
Makefile:508: recipe for target 'geoclue_gpsd-geoclue-gpsd.o' failed
make[3]: *** [geoclue_gpsd-geoclue-gpsd.o] Error 1
Comment 1 Pacho Ramos gentoo-dev 2015-10-23 18:29:56 UTC
Is gpsd support really needed for old SLOT? I couldn't find any fix for that branch (it's dead for ages), maybe we should consider disabling its gpsd support then :/
Comment 2 SpanKY gentoo-dev 2016-05-09 19:49:16 UTC
those packages have been dropped from the tree

the only one remaining is dev-qt/qtpositioning.  we should just drop geoclue:0 from the tree and be done with it.

so if no one cares, we can drop:
dev-qt/qtpositioning: all versions
app-misc/geoclue: only SLOT=0
Comment 3 Davide Pesavento (RETIRED) gentoo-dev 2016-05-09 20:56:56 UTC
NAK, we still need qtpositioning. And we'll need it for the foreseeable future since it's the sole geolocation provider for qtwebengine.

How about you restrict the dependency in geoclue:0 to something like
"<sci-geosciences/gpsd-3.11" ?
Comment 4 Gilles Dartiguelongue (RETIRED) gentoo-dev 2018-01-11 08:38:07 UTC
*** Bug 631730 has been marked as a duplicate of this bug. ***
Comment 5 Pacho Ramos gentoo-dev 2018-03-17 14:54:29 UTC
(In reply to Davide Pesavento from comment #3)
> NAK, we still need qtpositioning. And we'll need it for the foreseeable
> future since it's the sole geolocation provider for qtwebengine.
> 
> How about you restrict the dependency in geoclue:0 to something like
> "<sci-geosciences/gpsd-3.11" ?

What about disabling geoclue plugin for qtpositioning? It seems that even for the future 5.10 they still use old geoclue :/
Comment 6 Davide Pesavento (RETIRED) gentoo-dev 2018-03-17 16:03:16 UTC
(In reply to Pacho Ramos from comment #5)
> (In reply to Davide Pesavento from comment #3)
> > NAK, we still need qtpositioning. And we'll need it for the foreseeable
> > future since it's the sole geolocation provider for qtwebengine.
> > 
> > How about you restrict the dependency in geoclue:0 to something like
> > "<sci-geosciences/gpsd-3.11" ?
> 
> What about disabling geoclue plugin for qtpositioning? It seems that even
> for the future 5.10 they still use old geoclue :/

That would leave qtpositioning without any provider, i.e. it would basically be non-functional.

But why are pushing for this removal so much?
Comment 7 Pacho Ramos gentoo-dev 2018-03-17 18:19:59 UTC
Not "so much", after near two years (and more since the bug was opened) I was surprised this morning seeing that this is still the only reverse dep. Also I checked in Debian and it seems that they opted for disabling the plugin. Do you have an upstream bug or similar that would let us to track the progress directly there?
Comment 8 Davide Pesavento (RETIRED) gentoo-dev 2018-03-17 18:35:59 UTC
I'm also surprised to see that upstream still hasn't ported the plugin to geoclue:2, but that's the situation and there's nothing we can do about it.

Added upstream bug in "see also".
Comment 9 Pacho Ramos gentoo-dev 2018-03-17 18:42:12 UTC
Thanks!
Comment 10 Mart Raudsepp gentoo-dev 2018-11-24 15:14:40 UTC
Upstream has it fixed in qt 5.12 alpha. Please backport to 5.11 and remove the geoclue:0 based plugin from 5.9, or both.
Comment 11 Larry the Git Cow gentoo-dev 2018-11-29 13:09:48 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/qt.git/commit/?id=e075a5eced74b4216c1e561a03a63c431d21eff4

commit e075a5eced74b4216c1e561a03a63c431d21eff4
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2018-11-29 13:09:15 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2018-11-29 13:09:15 +0000

    dev-qt/qtpositioning: Switch to app-misc/geoclue:2.0
    
    Bug: https://bugs.gentoo.org/563588
    Package-Manager: Portage-2.3.52, Repoman-2.3.12
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 dev-qt/qtpositioning/qtpositioning-5.12.0_rc.ebuild | 4 ++--
 dev-qt/qtpositioning/qtpositioning-5.12.9999.ebuild | 6 +++---
 dev-qt/qtpositioning/qtpositioning-5.9999.ebuild    | 6 +++---
 3 files changed, 8 insertions(+), 8 deletions(-)
Comment 12 Michael Palimaka (kensington) gentoo-dev 2018-12-01 03:34:12 UTC
Given that geoclue2 support is a brand new positioning plugin, I don't think backporting will be feasible.
Comment 13 Mart Raudsepp gentoo-dev 2018-12-01 09:51:36 UTC
Then please drop geoclue:0 plugin from old qt without the backporting.
Comment 14 Larry the Git Cow gentoo-dev 2018-12-05 22:10:00 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=49b1276bc605c503515ba54f9d25e4b355815bb1

commit 49b1276bc605c503515ba54f9d25e4b355815bb1
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2018-12-05 00:52:09 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2018-12-05 22:09:47 +0000

    dev-qt/qtpositioning: Backport geoclue2 plugin to replace SLOT 0
    
    Development of the plugin seems to be contained in the geoclue2 subdirectory
    only, which makes packing it into a tarball relatively simple.
    
    Upstream commits (in 5.12.0):
    f0472774b36c862f5fb6822f2d4d63a967d1eaec
    4ef6b50278c041336f794cef20dd7e30fe8fbec0
    
    Bug: https://bugs.gentoo.org/563588
    Package-Manager: Portage-2.3.52, Repoman-2.3.12
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 dev-qt/qtpositioning/Manifest                    |  1 +
 dev-qt/qtpositioning/qtpositioning-5.11.3.ebuild | 10 ++++++++--
 2 files changed, 9 insertions(+), 2 deletions(-)
Comment 15 Mart Raudsepp gentoo-dev 2019-03-09 08:40:32 UTC
I had removed geoclue:0 from tree on Feb 14th already, after qtpositioning ported to new version and old usages in ebuilds were dropped