56356 – DBD-mysql does not compile against mysql-4.1.3

Bug 56356 - DBD-mysql does not compile against mysql-4.1.3

Summary: DBD-mysql does not compile against mysql-4.1.3

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All Linux

Importance:	High normal (vote)
Assignee:	Gentoo Perl team

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2004-07-07 12:03 UTC by Simon Detheridge
Modified:	2004-09-12 10:11 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Patch to make DBD-mysql compile against mysql-4.1.3 (DBD-mysql-2.9003-mysql4.1.3.diff,558 bytes, patch) 2004-07-07 12:05 UTC, Simon Detheridge	Details \| Diff
Ebuild to apply the patch (DBD-mysql-2.9003-r1.ebuild,648 bytes, text/plain) 2004-07-07 12:06 UTC, Simon Detheridge	Details
Patched ebuild (DBD-mysql-2.9003-r1.ebuild,663 bytes, text/plain) 2004-07-17 01:47 UTC, Alexander M. Turek	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Simon Detheridge 2004-07-07 12:03:01 UTC

DBD-mysql does not compile against mysql 4.1.3. This is because they have added a second parameter to mysql_shutdown.

I wrote a patch that fixes the problem. See below.

Reproducible: Always
Steps to Reproduce:
1.emerge mysql-4.1.3
2.emerge DBD-mysql

Actual Results:  
DBD-mysql fails to compile 

Expected Results:  
DBD-mysql should emerge

Comment 1 Simon Detheridge 2004-07-07 12:05:08 UTC

Created attachment 34936 [details, diff]
Patch to make DBD-mysql compile against mysql-4.1.3

This patch adds the second parameter required, if the mysql version is >=
4.1.3.

Comment 2 Simon Detheridge 2004-07-07 12:06:21 UTC

Created attachment 34937 [details]
Ebuild to apply the patch

This ebuild applies the above patch. It's based on 2.9003

Comment 3 Alexander M. Turek 2004-07-17 01:47:57 UTC

Created attachment 35623 [details]
Patched ebuild

Simon, your ebuild did not work for me.
I had to add "inherit eutils" to get it to work.

I attached a fixed ebuild.

Comment 4 Eric Sammer (RETIRED) gentoo-dev

2004-07-18 20:27:34 UTC

The upstream developers (namely Rudolf Lippan <rlippan@remotelinux.com>) had already fixed this with the DBD-mysql-2.9004 release. I've added 2.9004 to CVS, *but* it's hard masked as to not break things for existing ~ARCH users. To test, unmask it and give it a whirl.

Note: this is hard masked rather than ~ARCH masked because I do not have mysql-4.1.3 installed to test with. Please report test results in the form of a bug (file a bug to bump to 2.9004 if it works or file a bug that 2.9004 doesn't work and why if it doesn't).

Thanks for the otherwise good catch and patches to both of you!

Comment 5 Benedikt Böhm (RETIRED) gentoo-dev

2004-09-12 10:11:19 UTC

9004 works fine here with mysql-4.1.4 gamma ebuild on ~x86 posted on bugs.gentoo.org