Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 561852 - dev-libs/openssl:0 can/should depend on app-misc/c_rehash?
Summary: dev-libs/openssl:0 can/should depend on app-misc/c_rehash?
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-29 19:29 UTC by Julian Ospald
Modified: 2015-10-01 13:50 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
ca-certificates-20150426.3.20-r1.ebuild.diff (ca-certificates-20150426.3.20-r1.ebuild.diff,494 bytes, patch)
2015-09-29 21:11 UTC, Julian Ospald
Details | Diff
openssl-1.0.2d-r1.ebuild.diff (openssl-1.0.2d-r1.ebuild.diff,2.03 KB, patch)
2015-09-29 21:11 UTC, Julian Ospald
Details | Diff
ca-certificates-20150426.3.20-r1.ebuild.diff (ca-certificates-20150426.3.20-r1.ebuild.diff,976 bytes, patch)
2015-09-29 21:13 UTC, Julian Ospald
Details | Diff
ca-certificates-20150426.3.20-r1.ebuild.diff (ca-certificates-20150426.3.20-r1.ebuild.diff,1.10 KB, patch)
2015-09-30 08:54 UTC, Julian Ospald
Details | Diff
openssl-1.0.2d-r1.ebuild.diff (openssl-1.0.2d-r1.ebuild.diff,2.08 KB, patch)
2015-09-30 08:55 UTC, Julian Ospald
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Ospald 2015-09-29 19:29:56 UTC
app-misc/c_rehash was imported because of libressl which needs it but cannot depend on openssl for obvious reasons, so I split out the c_rehash part (since it's not really part of libressl or openssl anyway and rather a distro-specific tool).

Currently app-misc/c_rehash has to do "!dev-libs/openssl:0".

Instead, we could make openssl depend on c_rehash and thus remove the blocker and the code duplication.

If you like this idea, please feel free to add yourself as maintainer of app-misc/c_rehash.
Comment 1 SpanKY gentoo-dev 2015-09-29 19:51:26 UTC
sounds fine
Comment 2 Julian Ospald 2015-09-29 21:11:39 UTC
Created attachment 413304 [details, diff]
ca-certificates-20150426.3.20-r1.ebuild.diff
Comment 3 Julian Ospald 2015-09-29 21:11:55 UTC
Created attachment 413306 [details, diff]
openssl-1.0.2d-r1.ebuild.diff
Comment 4 Julian Ospald 2015-09-29 21:13:24 UTC
Created attachment 413308 [details, diff]
ca-certificates-20150426.3.20-r1.ebuild.diff
Comment 5 SpanKY gentoo-dev 2015-09-29 22:42:54 UTC
Comment on attachment 413308 [details, diff]
ca-certificates-20150426.3.20-r1.ebuild.diff

> # openssl: we run `c_rehash`; newer version for alt-cert-paths #552540

comment needs updating
Comment 6 SpanKY gentoo-dev 2015-09-29 22:43:27 UTC
Comment on attachment 413306 [details, diff]
openssl-1.0.2d-r1.ebuild.diff

> src_prepare() {
> 	SSL_CNF_DIR="/etc/ssl"

should add a comment above it noting requirement that it be kept in sync with the c_rehash ebuild
Comment 7 Julian Ospald 2015-09-30 08:54:56 UTC
Created attachment 413334 [details, diff]
ca-certificates-20150426.3.20-r1.ebuild.diff
Comment 8 Julian Ospald 2015-09-30 08:55:09 UTC
Created attachment 413336 [details, diff]
openssl-1.0.2d-r1.ebuild.diff
Comment 10 Alan McKinnon 2015-10-01 11:05:58 UTC

I'm getting a file collision between openssl and c_rehash since this change:

 * package dev-libs/openssl-1.0.2d-r1 NOT merged
 *
 * Detected file collision(s):
 *
 *      /usr/bin/c_rehash
 *
 * Searching all installed packages for file collisions...
 *
 * Press Ctrl-C to Stop
 *
 * app-misc/c_rehash-1.7-r1:0::gentoo
 *      /usr/bin/c_rehash


Both packages are latest ~arch:
 
# emerge -av1 c_rehash openssl

These are the packages that would be merged, in order:

Calculating dependencies... done!
[ebuild   R    ] app-misc/c_rehash-1.7-r1::gentoo
[ebuild     U  ] dev-libs/openssl-1.0.2d-r1::gentoo
Comment 11 Julian Ospald 2015-10-01 11:39:06 UTC
I see the problem... not just the removed
  dobin "${WORKDIR}"/c_rehash
installs c_rehash, but also "emake install" from src_install, so we will have to
  rm "${ED}"/usr/bin/c_rehash
Comment 13 SpanKY gentoo-dev 2015-10-01 13:40:22 UTC
(In reply to Julian Ospald (hasufell) from comment #12)

should `|| die` the `rm` call