Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 558348 - =media-sound/teamspeak-client-bin-3.0.17 version bump
Summary: =media-sound/teamspeak-client-bin-3.0.17 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Sami Loone
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-21 13:13 UTC by bill
Modified: 2015-09-06 08:01 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
client ebuild patch to add 3.0.17 version support (ebuild,7.49 KB, patch)
2015-08-29 17:42 UTC, Sami Loone
Details | Diff
client ebuild patch to add 3.0.17 version support - fixed (patch,7.09 KB, patch)
2015-08-29 17:52 UTC, Sami Loone
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Sami Loone 2015-08-29 17:42:48 UTC
Created attachment 410572 [details, diff]
client ebuild patch to add 3.0.17 version support

I have not tested x86 but works for amd64. 

This is the ebuild diff compared to 3.0.16-r1

--- teamspeak-client-bin-3.0.16-r1.ebuild	2015-08-29 20:25:55.353853835 +0300
+++ teamspeak-client-bin-3.0.17.ebuild	2015-08-29 20:25:38.734560187 +0300
@@ -44,7 +44,8 @@
 src_prepare() {
 	# Remove the qt-libraries as they just cause trouble with the system's Qt, see bug #328807.
 	rm libQt* || die "Couldn't remove bundled Qt libraries."
-	rm -r accessible platforms sqldrivers qt.conf || die "Couldn't remove bundle Qt files."
+
+	rm -r platforms sqldrivers qt.conf || die "Couldn't remove bundle Qt files."
 
 	# Remove unwanted soundbackends.
 	if ! use alsa ; then
@@ -56,7 +57,7 @@
 	fi
 
 	# Remove quazip
-	rm libquazip.so.1 || die
+	rm libquazip.so || die
 
 	# Rename the tsclient to its shorter version, required by the teamspeak3 script we install.
 	mv ts3client_linux_* ts3client || die "Couldn't rename ts3client to its shorter version."
Comment 2 Sami Loone 2015-08-29 17:52:27 UTC
Created attachment 410574 [details, diff]
client ebuild patch to add 3.0.17 version support - fixed

Had some garbage in the first patch. New patch added.
Comment 3 Ian Delaney (RETIRED) gentoo-dev 2015-09-04 09:41:20 UTC
+RESTRICT="fetch mirror strip"

does this need revising?  to RESTRICT="mirror strip".

Once again, the patch / new ebuild comes form a user other than the desginated maintainer.  Sami Loone, after editing the ebuild from the tip above, do you wish to maintain, or co-maintain, this package?
Comment 4 Sami Loone 2015-09-04 18:27:51 UTC
We might want to remove the direct links from the ebuild instead. From the changelog I found that:

  15 Apr 2013; Tom Wijsman <TomWij@gentoo.org>                                     
  teamspeak-client-bin-3.0.10.1.ebuild, teamspeak-client-bin-3.0.10.ebuild,        
  teamspeak-client-bin-3.0.9.2.ebuild:                                             
  FEATURES="fetch" since we are not allowed to directly link (therefore not        
  directly download) their files without express, written permission; this is   
  stated at the bottom of their Downloads page, let's comply with that. 




To answer the question, I'd gladly maintain the package.
Comment 5 Ian Delaney (RETIRED) gentoo-dev 2015-09-06 02:14:28 UTC
For now I have added you as a co-maintainer. Karol Herbst has not declared withdrawing. The fetch still has an issue to be resolved.
Comment 6 Ian Delaney (RETIRED) gentoo-dev 2015-09-06 08:01:59 UTC
commit c2806b29f5f8f5bbef12032277739af34a8411c4
Author: Ian Delaney <idella4@gentoo.org>
Date:   Sun Sep 6 16:00:06 2015 +0800

    teamspeak-client-bin: bump
    
     ebuild submitted by new maintainer via bug #558348, closes the bug