Bug 55647 – repoman check for files w/ executable bit set

• Status: RESOLVED FIXED
• Product: Portage Development

[Description Brian Harring (RETIRED) 2004-06-30 02:21:37 UTC]

Solar had asked about adding a check to bail out if repoman is commiting, and the ebuild has any executable bits on, this being the end result.

This patch adds ebuild.perms, and file.perms; file.perms is a warning, ebuild.perms is a failure.
All they do is check for executable bits set, pretty straightforward.

[Comment 1 Brian Harring (RETIRED) 2004-06-30 02:22:31 UTC]

Created attachment 34472 [details, diff]
portage-51_pre12-repoman-x-bit-check.patch

[Comment 2 Brian Harring (RETIRED) 2004-06-30 02:35:41 UTC]

Created attachment 34476 [details, diff]
portage-51_pre12-repoman-x-bit-check.patch 

Typos suck.

[Comment 3 Brian Harring (RETIRED) 2004-06-30 10:57:09 UTC]

Minor typo in the patch

+"file.perms", "ebuild.perms"

should be

+"file.perms", "ebuild.perms",

note the comma :)

[Comment 4 Brian Harring (RETIRED) 2004-06-30 18:06:06 UTC]

Created attachment 34536 [details, diff]
51_pre12 repoman +x check 

Patch with the comma typo fixed.

[Comment 5 Nicholas Jones (RETIRED) 2004-07-10 17:02:09 UTC]

Might just as well a-x the ebuild...
The files checks are fine.

[Comment 6 solar (RETIRED) 2004-07-26 14:36:39 UTC]

vs a-x would it not be just better to ensure that it's precisely 0644 ?

[Comment 7 Brian Harring (RETIRED) 2004-07-26 15:22:57 UTC]

CVS appears to ignore the perms exempting +x.
Note the "appears".  I don't know for sure, although some quick testing on my home machine seemd to indicate cvs ignored everything but +x.

[Comment 8 Brian Harring (RETIRED) 2004-08-05 13:47:07 UTC]

went out in pre15.