Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 543974 - net-firewall/ipset-6.21.1 patch fails
Summary: net-firewall/ipset-6.21.1 patch fails
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Server (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Robin Johnson
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 502870
  Show dependency tree
 
Reported: 2015-03-21 02:11 UTC by Thomas Capricelli
Modified: 2015-05-15 11:29 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Capricelli 2015-03-21 02:11:23 UTC
ipset is a dependancy of sys-cluster/neutron-2014.2.2-r1 that i'm trying to install. It fails with :

-----------------------------------------------------------------------------
 * Sorry, but you have to patch kernel sources with the following patch:
 *  # cd /usr/src/linux
 *  # patch -i /var/tmp/portage/net-firewall/ipset-6.21.1/work/ipset-6.21.1/netlink.patch -p1
-----------------------------------------------------------------------------

Which is already quite strange, i've never seen such a thing in gentoo.

Though the patch fails miserably:

-----------------------------------------------------------------------------
bach linux # patch -i /var/tmp/portage/net-firewall/ipset-6.21.1/work/ipset-6.21.1/netlink.patch -p1
patching file include/linux/netfilter/nfnetlink.h
Hunk #1 FAILED at 47.
1 out of 1 hunk FAILED -- saving rejects to file include/linux/netfilter/nfnetlink.h.rej
patching file include/net/netlink.h
Hunk #1 FAILED at 856.
1 out of 1 hunk FAILED -- saving rejects to file include/net/netlink.h.rej
-----------------------------------------------------------------------------


And indeed, the corresponding files have nothing related to what the patch tries to change.

I'm using kernel 3.19.2, which is very recent, and is i guess the reason of the failure.

Using grep i've found the following that might (or not, i'm no expert) be related :

include/uapi/linux/netfilter/nfnetlink.h:#define NFNL_SUBSYS_COUNT              12

But as it turns out, this files also contains a define for NFNL_SUBSYS_IPSET, so my current guest is that for recent kernel the patch is not needed ..



Reproducible: Always
Comment 1 Thomas Capricelli 2015-04-24 14:20:55 UTC
Confirmed both problem and analysis on kernel 3.18.7, which is older. So i guess the issue is of broader scope than i was thinking at first.

My current fix is to remove the check_header_patch() in ebuild. I still think that what the patch tries to fix is already merged somehow in kernel >=3.18.7 at least.
Comment 2 Yixun Lan archtester gentoo-dev 2015-05-14 06:28:38 UTC
the new version 6.24 takes care of this, please give it a try
(btw, I didn't fix this 6.21.1)
Comment 3 Thomas Capricelli 2015-05-15 11:29:22 UTC
It works well with 6.24 (and "-modules"), thanks !