Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 541588 - media-video/ffmpeg: add bindist restriction
Summary: media-video/ffmpeg: add bindist restriction
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 541408
  Show dependency tree
 
Reported: 2015-02-28 08:03 UTC by Ulrich Müller
Modified: 2015-03-05 13:57 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2015-02-28 08:03:01 UTC
Please add the following line to ebuilds, in order to restrict binary distribution with USE=-bindist:

   RESTRICT="!bindist? ( bindist )"

See the tracker bug 541408 for further explanation.
Comment 1 Alexis Ballier gentoo-dev 2015-03-02 08:05:20 UTC
where is this documented/announced ?

if the point is just to tell 'if use foo, then you cant bindist', since ffmpeg uses bindist only for required_use, it is much better to kill the bindist useflag have a proper RESTRICT=... line.


removing qacanfix tag since the proper solution is still unclear.
Comment 2 Ulrich Müller gentoo-dev 2015-03-02 09:56:03 UTC
(In reply to Alexis Ballier from comment #1)
> if the point is just to tell 'if use foo, then you cant bindist', since
> ffmpeg uses bindist only for required_use, it is much better to kill the
> bindist useflag have a proper RESTRICT=... line.

I went for the minimal change here, namely adding a RESTRICT line.

Removing the bindist flag should be discussed in the -dev ML. I'll send an announcement later today.
Comment 3 Alexis Ballier gentoo-dev 2015-03-02 09:58:13 UTC
(In reply to Ulrich Müller from comment #2)
> Removing the bindist flag should be discussed in the -dev ML. I'll send an
> announcement later today.


hu ?
this cannot be done for e.g. openssl, where the flag is used inside the ebuild. I was merely talking about the package this bug report is about.
Comment 4 Ulrich Müller gentoo-dev 2015-03-02 11:06:24 UTC
(In reply to Alexis Ballier from comment #3)
> (In reply to Ulrich Müller from comment #2)
> > Removing the bindist flag should be discussed in the -dev ML. I'll send an
> > announcement later today.
> 
> 
> hu ?
> this cannot be done for e.g. openssl, where the flag is used inside the
> ebuild. I was merely talking about the package this bug report is about.

It is a more general problem. We have several ebuilds that follow a scheme like the following: http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/net-dialup/freeradius/freeradius-3.0.3.ebuild?revision=1.3&view=markup

In a nutshell, they currently have (similar to ffmpeg, but simpler):

   IUSE="bindist foo"
   REQUIRED_USE="bindist? ( !foo )"

Except for the REQUIRED_USE, the bindist flag is otherwise not used in the ebuild. The question is if we should simply add a restriction:

   IUSE="bindist foo"
   REQUIRED_USE="bindist? ( !foo )"
   RESTRICT="!bindist? ( bindist )"

Or alternatively, we could remove the bindist flag:

   IUSE="foo"
   RESTRICT="foo? ( bindist )"
Comment 5 Alexis Ballier gentoo-dev 2015-03-02 12:37:03 UTC
(In reply to Ulrich Müller from comment #4)

ok; i wasn't even considering the former since i don't see the point of such duplication: it could very well be handled internally by PM just like FEATURES=test -> USE=test


also, aren't allowed values of RESTRICT defined by PMS ? in which case, what EAPI should be used ?
Comment 6 Ulrich Müller gentoo-dev 2015-03-04 16:34:49 UTC
Following up to the discussion in gentoo-dev, please add this line to ebuilds:

RESTRICT="encode? ( faac? ( bindist ) aacplus? ( bindist ) )
    openssl? ( bindist )"

and remove the bindist flag from IUSE and REQUIRED_USE.
Comment 7 Alexis Ballier gentoo-dev 2015-03-05 13:57:21 UTC
done