Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 525072 - net-libs/webkit-gtk-2.4.6[-webgl] - error: ‘class WebCore::PageCache’ has no member named ‘setShouldClearBackingStores’
Summary: net-libs/webkit-gtk-2.4.6[-webgl] - error: ‘class WebCore::PageCache’ has no ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL: https://bugs.webkit.org/show_bug.cgi?...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-11 16:09 UTC by Alexander Tsoy
Modified: 2014-10-25 16:15 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log.xz (webkit-gtk-build.log.xz,270.48 KB, application/x-xz)
2014-10-11 16:10 UTC, Alexander Tsoy
Details
Fix compilation with --disable-accelerated-compositing (webkit-gtk-2.4.6-fix-disable-webgl.patch,685 bytes, patch)
2014-10-11 20:29 UTC, Alexander Tsoy
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Tsoy 2014-10-11 16:09:38 UTC
net-libs/webkit-gtk-2.4.6[-webgl] fails to compile:

Source/WebKit2/WebProcess/soup/WebProcessSoup.cpp: In member function ‘void WebKit::WebProcess::platformSetCacheModel(WebKit::CacheModel)’:
Source/WebKit2/WebProcess/soup/WebProcessSoup.cpp:114:27: error: ‘class WebCore::PageCache’ has no member named ‘setShouldClearBackingStores’
     WebCore::pageCache()->setShouldClearBackingStores(true);
                           ^
GNUmakefile:75880: recipe for target 'Source/WebKit2/WebProcess/soup/libwebkit2gtk_3_0_la-WebProcessSoup.lo' failed
make[1]: *** [Source/WebKit2/WebProcess/soup/libwebkit2gtk_3_0_la-WebProcessSoup.lo] Error 1


This is probably due to "--disable-accelerated-compositing". Snippet trom the PageCache.h:

#if USE(ACCELERATED_COMPOSITING)
        bool shouldClearBackingStores() const { return m_shouldClearBackingStores; }
        void setShouldClearBackingStores(bool flag) { m_shouldClearBackingStores = flag; }
        void markPagesForDeviceScaleChanged(Page*);
#endif



$ emerge --info webkit-gtk
Portage 2.2.8-r2 (hardened/linux/amd64, gcc-4.8.3, glibc-2.19-r1, 3.14.20-hardened-r1 x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-3.14.20-hardened-r1-x86_64-AMD_Opteron-tm-_Processor_4332_HE-with-gentoo-2.2
KiB Mem:    16411772 total,   2691244 free
KiB Swap:   16777212 total,  16777212 free
Timestamp of tree: Sat, 11 Oct 2014 00:45:01 +0000
ld GNU ld (Gentoo 2.23.2 p1.0) 2.23.2
app-shells/bash:          4.2_p53
dev-java/java-config:     2.2.0
dev-lang/perl:            5.18.2-r1
dev-lang/python:          2.7.7, 3.3.5-r1
dev-util/cmake:           2.8.12.2-r1
dev-util/pkgconfig:       0.28-r1
sys-apps/baselayout:      2.2
sys-apps/openrc:          0.12.4
sys-apps/sandbox:         2.6-r1
sys-devel/autoconf:       2.13, 2.69
sys-devel/automake:       1.11.6, 1.12.6, 1.13.4
sys-devel/binutils:       2.23.2
sys-devel/gcc:            4.8.3
sys-devel/gcc-config:     1.7.3
sys-devel/libtool:        2.4.2-r1
sys-devel/make:           4.0-r1
sys-kernel/linux-headers: 3.13 (virtual/os-headers)
sys-libs/glibc:           2.19-r1
Repositories: gentoo puleglot local
ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -march=bdver2 -mtune=bdver2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/easy-rsa /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -march=bdver2 -mtune=bdver2 -pipe"
DISTDIR="/var/cache/portage/distfiles"
EMERGE_DEFAULT_OPTS="--with-bdeps=y --binpkg-respect-use=y --ask-enter-invalid"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs buildsyspkg config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync webrsync-gpg xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://mirror.yandex.ru/gentoo-distfiles/ ftp://mirror.yandex.ru/gentoo-distfiles/"
LANG="ru_RU.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j6"
PKGDIR="/var/cache/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/var/cache/portage/tree"
PORTDIR_OVERLAY="/var/lib/layman/puleglot-overlay /usr/local/portage"
SYNC=""
USE="X aac acl acpi aio alsa amd64 amr ape asyncns avahi avx bash-completion berkdb bluetooth bluray branding bzip2 cairo caps cdda cddb cdparanoia cdr cli colord cracklib crypt cryptsetup cups cxx dbus dconf device-mapper djvu dri dts dvd dvdr eds egl evo examples exif faac faad ffmpeg flac fma fontconfig fuse gdbm gif gnome gnome-keyring gnome-online-accounts gpm gstreamer gtk gtk3 hardened iconv icu idn ieee1394 introspection ipv6 jpeg jpeg2k justify libass libnotify libsamplerate libsecret lz4 lzma mac mad maildir mms mmx mmxext modules mp3 mp4 multilib musepack musicbrainz nautilus ncurses networkmanager nls nptl nptlonly ogg openal opengl openmp opus pam pax_kernel pcre perl pmu png policykit postscript pulseaudio python raw readline samba sasl session socialweb speex sse sse2 sse3 sse4 sse4_1 sse4a ssl ssse3 startup-notification svg systemd tcpd theora tiff tls truetype udev unicode upnp-av urandom usb vdpau vim-syntax vorbis vpx wavpack webp x264 xattr xfs xtpax xv xvid xz zlib" ABI_X86="64 32" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="*" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ublox ubx" GRUB_PLATFORMS="pc" INPUT_DEVICES="evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="en ru" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-5" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_3" QEMU_SOFTMMU_TARGETS="aarch64 arm i386 mips mips64 mips64el mipsel ppc ppc64 ppcemb x86_64" RUBY_TARGETS="ruby19 ruby20" USERLAND="GNU" VIDEO_CARDS="radeon radeonsi modesetting vesa v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON

=================================================================
                        Package Settings
=================================================================

net-libs/webkit-gtk-2.4.6 was built with the following:
USE="X egl geoloc gstreamer introspection libsecret opengl webgl (-aqua) -coverage -debug -gles2 -jit -spell -test -wayland" ABI_X86="64"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--no-keep-memory -Wl,--reduce-memory-overheads"


net-libs/webkit-gtk-2.4.6-r200 was built with the following:
USE="X egl geoloc gstreamer introspection libsecret opengl webgl (-aqua) -coverage -debug -gles2 -jit -spell -test" ABI_X86="64"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--no-keep-memory -Wl,--reduce-memory-overheads"
Comment 1 Alexander Tsoy 2014-10-11 16:10:48 UTC
Created attachment 386448 [details]
build.log.xz
Comment 2 Alexander Tsoy 2014-10-11 16:19:39 UTC
BTW, how do WebGL and accelerated composition relate to each other? :)
Comment 3 Alexander Tsoy 2014-10-11 16:20:24 UTC
(In reply to Alexander Tsoy from comment #2)
> BTW, how do WebGL and accelerated composition relate to each other? :)

I mean:

        $(use_enable webgl) \
        $(use_enable webgl accelerated-compositing) \
Comment 5 Pacho Ramos gentoo-dev 2014-10-11 16:42:41 UTC
Isn't webgl USE needed because either gles2 or opengl support is needed for accelerated-compositing? (well, I don't remember when was that interdependency added :S)

Regarding the build failure with --disable-accelerated-compositing I would also report it to upstream :/ -> bugzilla.webkit.org
Comment 6 Pacho Ramos gentoo-dev 2014-10-11 16:46:48 UTC
Maybe now the errors is reflected in a different way :S
Comment 7 Alexander Tsoy 2014-10-11 20:29:50 UTC
Created attachment 386468 [details, diff]
Fix compilation with --disable-accelerated-compositing

With this patch compilation progress futher, until I get the same linkage error as in bug 500966. :)
Comment 8 Alexander Tsoy 2014-10-11 21:00:23 UTC
(In reply to Pacho Ramos from comment #5)
> Isn't webgl USE needed because either gles2 or opengl support is needed for
> accelerated-compositing? (well, I don't remember when was that
> interdependency added :S)

WebGL and accelerated compositing are completely orthogonal to each other. Maybe this was done to minimize the amount of USE flags. Seems both these features have the same or mostly the same dependencies.

(In reply to Pacho Ramos from comment #6)
> Maybe now the errors is reflected in a different way :S
> See Also: https://bugs.gentoo.org/show_bug.cgi?id=500966

IMHO bug 500966 is not related to this one.
Comment 9 Alexander Tsoy 2014-10-14 10:04:19 UTC
(In reply to Alexander Tsoy from comment #8)
> (In reply to Pacho Ramos from comment #5)
> > Isn't webgl USE needed because either gles2 or opengl support is needed for
> > accelerated-compositing? (well, I don't remember when was that
> > interdependency added :S)
> 
> WebGL and accelerated compositing are completely orthogonal to each other.
> Maybe this was done to minimize the amount of USE flags. Seems both these
> features have the same or mostly the same dependencies.

Ah.. I see:

commit ca4e1c43a6aae7bf2c3b4de199a3d7fa2ea5ec4f
Author: Gilles Dartiguelongue <eva@gentoo.org>
Date:   Tue Nov 26 22:36:39 2013 +0100

<snip>
    
    accelerated-compositing implies canvas and css shaders, however css
    shaders require webgl to be enabled to build.
    
<snip>
Comment 10 Pacho Ramos gentoo-dev 2014-10-25 16:15:43 UTC
+*webkit-gtk-2.4.7 (25 Oct 2014)
+*webkit-gtk-2.4.7-r200 (25 Oct 2014)
+
+  25 Oct 2014; Pacho Ramos <pacho@gentoo.org>
+  +files/webkit-gtk-2.4.7-disable-accelerated-compositing.patch,
+  +files/webkit-gtk-2.4.7-disable-webgl.patch, +webkit-gtk-2.4.7-r200.ebuild,
+  +webkit-gtk-2.4.7.ebuild:
+  Version bump, fix building when disabling accelerated compositing and webgl
+  (#525072 and #500966 by Alexander Tsoy)
+