Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 507664 - app-emulation/vmware-modules-279.1 with kernel 3.15.0 - .../work/vmblock-only/linux/inode.c:181:4: error: implicit declaration of function ‘vfs_readlink’ [-Werror=implicit-function-declaration]
Summary: app-emulation/vmware-modules-279.1 with kernel 3.15.0 - .../work/vmblock-only...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal with 1 vote (vote)
Assignee: Gentoo VMWare Bug Squashers [disabled]
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2014-04-14 21:51 UTC by Fabio Rossi
Modified: 2015-07-11 04:50 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
279-kernel-3.15.patch (279-kernel-3.15.patch,1.38 KB, patch)
2014-04-14 21:51 UTC, Fabio Rossi
Details | Diff
patch (inode_patch.patch,604 bytes, patch)
2014-07-16 09:10 UTC, Andreas Schäfer
Details | Diff
inode_patch.patch (inode_patch.patch,604 bytes, patch)
2014-07-16 09:11 UTC, Andreas Schäfer
Details | Diff
vmci.patch (vmci.patch,885 bytes, patch)
2014-07-16 09:12 UTC, Andreas Schäfer
Details | Diff
vsock.patch (vsock.patch,650 bytes, patch)
2014-07-16 09:12 UTC, Andreas Schäfer
Details | Diff
build failed (file_507664.txt,14.29 KB, text/plain)
2014-08-04 23:44 UTC, renato gallo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Fabio Rossi 2014-04-14 21:51:21 UTC
Created attachment 374932 [details, diff]
279-kernel-3.15.patch

I get two kind of errors when trying to compile against kernel 3.15-rc:

/var/tmp/portage/app-emulation/vmware-modules-279.1/work/vmblock-only/linux/inode.c: In function ‘InodeOpReadlink’:
/var/tmp/portage/app-emulation/vmware-modules-279.1/work/vmblock-only/linux/inode.c:181:4: error: implicit declaration of function ‘vfs_readlink’ [-Werror=implicit-function-declaration]

/var/tmp/portage/app-emulation/vmware-modules-279.1/work/vsock-only/linux/notifyQState.c: In function ‘VSockVmciHandleWrote’:
/var/tmp/portage/app-emulation/vmware-modules-279.1/work/vsock-only/linux/notifyQState.c:167:4: error: too many arguments to function ‘sk->sk_data_ready’
/var/tmp/portage/app-emulation/vmware-modules-279.1/work/vsock-only/linux/notifyQState.c: In function ‘VSockVmciNotifyPktRecvPostDequeue’:
/var/tmp/portage/app-emulation/vmware-modules-279.1/work/vsock-only/linux/notifyQState.c:569:7: error: too many arguments to function ‘sk->sk_data_ready’
/var/tmp/portage/app-emulation/vmware-modules-279.1/work/vsock-only/linux/notify.c: In function ‘VSockVmciHandleWrote’:
/var/tmp/portage/app-emulation/vmware-modules-279.1/work/vsock-only/linux/notify.c:519:4: error: too many arguments to function ‘sk->sk_data_ready’

The related changes are:

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/include/net/sock.h?id=676d23690fb62b5d51ba5d659935e9f7d9da9f8e
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/fs/namei.c?id=5d826c847b34de6415b4f1becd88a57ff619af50

so the fixes are straight forward. Attached simple patch
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2014-04-25 12:11:09 UTC

*** This bug has been marked as a duplicate of bug 483410 ***
Comment 2 Fabio Rossi 2014-04-25 12:29:08 UTC
I don't see why this bug is a duplicate of #483410, the issues appeared only after kernel 3.15-rc (a patched vmware-modules with the fixes from #483410 has still the problems of this bug report)

Moreover there are two issues reported here, the bug summary reports only the first
Comment 3 Eric Siskonen 2014-06-23 03:06:36 UTC
I can confirm this patch works for me by placing it in /etc/portage/patches/app-emulation/vmware-modules/. Thanks!
Comment 4 Zhu Sha Zang 2014-06-23 15:36:14 UTC
Dear Eric Siskonen are you using any other patch inside etc/portage/patches/app-emulation/vmware-modules/ directory? I'm ask because this patch did not work form me. In fact, i'm using vmware-module-279.2 against linux-3.15.1 gentoo-sources version and do not know if this patch can be used too.

Best Regards
Comment 5 Adam Carter 2014-07-11 10:49:47 UTC
Zhu Sha Zang, vmware-modules built for me with these:
ls /etc/portage/patches/app-emulation/vmware-modules
279-getname.patch  279-kernel-3.15.patch  inode_patch.patch
Comment 6 Andreas Schäfer 2014-07-16 09:10:51 UTC
Created attachment 380796 [details, diff]
patch
Comment 7 Andreas Schäfer 2014-07-16 09:11:37 UTC
Created attachment 380798 [details, diff]
inode_patch.patch
Comment 8 Andreas Schäfer 2014-07-16 09:12:13 UTC
Created attachment 380800 [details, diff]
vmci.patch
Comment 9 Andreas Schäfer 2014-07-16 09:12:42 UTC
Created attachment 380802 [details, diff]
vsock.patch
Comment 10 Andreas Schäfer 2014-07-16 09:13:52 UTC
I could only compile with the four patches found above placed in /etc/portage/patches/app-emulation/vmware-modules: 279-kernel-3.15.patch, inode_patch.patch, vmci.patch, vsock.patch.
Comment 11 renato gallo 2014-08-04 23:44:18 UTC
Created attachment 382290 [details]
build failed

patches do not work for me
Comment 12 renato gallo 2014-08-04 23:45:25 UTC
emerge --info
Portage 2.2.8-r1 (default/linux/amd64/13.0/desktop/gnome/systemd, gcc-4.7.3, glibc-2.19-r1, 3.15.7-gentoo x86_64)
=================================================================
System uname: Linux-3.15.7-gentoo-x86_64-Intel-R-_Core-TM-_i5_CPU_760_@_2.80GHz-with-gentoo-2.2
KiB Mem:     4051048 total,   1056276 free
KiB Swap:    6297444 total,   5372012 free
Timestamp of tree: Wed, 30 Jul 2014 18:00:01 +0000
ld GNU ld (Gentoo 2.23.2 p1.0) 2.23.2
app-shells/bash:          4.2_p45
dev-java/java-config:     2.2.0
dev-lang/python:          2.7.6, 3.3.3
dev-util/cmake:           2.8.12.2-r1
dev-util/pkgconfig:       0.28-r1
sys-apps/baselayout:      2.2
sys-apps/openrc:          0.12.4
sys-apps/sandbox:         2.6-r1
sys-devel/autoconf:       2.13, 2.69
sys-devel/automake:       1.11.6, 1.12.6, 1.13.4
sys-devel/binutils:       2.23.2
sys-devel/gcc:            4.7.3-r1
sys-devel/gcc-config:     1.7.3
sys-devel/libtool:        2.4.2-r1
sys-devel/make:           3.82-r4
sys-kernel/linux-headers: 3.15 (virtual/os-headers)
sys-libs/glibc:           2.19-r1
Repositories: gentoo
ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt /var/lib/hsqldb"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-O2 -pipe"
DISTDIR="/usr/portage/distfiles"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://ftp.heanet.ie/pub/gentoo/"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY=""
USE="3dnow 3dnowext X a52 aac aacplus aalib acl acpi alsa amd64 amr amrenc atmo avx avx2 berkdb bindist bluetooth bluray branding bs2b bzip2 cairo cdda cddb cdio cdr celt chromaprint cli colord cpudetection cracklib crypt cups cxx dbus dirac directfb dri dts dvb dvd dvdr eds egl emboss encode evo exif faac faad fam fdk ffmpeg fftwaac firefox flac flite fluidsynth fma3 fma4 fontconfig fortran frei0r ftp gbm gdbm gif gme gnome gnome-keyring gnome-online-accounts gnutls gpm growl gsm gstreamer gtk hardcodedtables httpd iconv iec61883 ieee1394 introspection ipv6 java joystick jpeg jpeg2k kate ladspa lcms ldap libass libcaca libkms libnotify libsamplerate libsecret libsoxr libtar libtiger libv4l linsys lirc live lua mad matroska md5sum minizip mmx mmxext mng modplug modules mp3 mp4 mpeg mtp multilib musepack mysql nautilus ncurses network nls nptl ogg omxil openal opencv opengl openmp openssl optimisememory opus ovftool pam pango pcre pdf pic png pnm policykit ppds projectm pulseaudio pvr qt3support qt4 quvi radio rdp readline rtmp rtsp samba schroedinger sdl sdl-image session sftp shout sid skins socialweb speex spell sse sse2 sse3 sse4 sse4_2 ssh ssl ssse3 startup-notification staticlibs svg symlink systemd taglib tcpd tga theora threads tiff tremor truetype twolame udev udisks unicode upnp upower usb v4l vaapi vcd vcdx vdpau vix vlm vmware-tools vorbis vpx wavpack webp win32codecs wma-fixed wmv wxwidgets x264 x265 xa xcb xinerama xml xmp xop xv xvid yuv4mpeg zlib zvbi" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="nlpsolver scripting-beanshell scripting-javascript wiki-publisher" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-5" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_3" RUBY_TARGETS="ruby19 ruby20" USERLAND="GNU" VIDEO_CARDS="fbdev glint intel mach64 mga nouveau nv r128 radeon savage sis tdfx trident vesa via vmware dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, MAKEOPTS, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, SYNC, USE_PYTHON
Comment 13 Aaron Pelton 2014-09-11 12:08:27 UTC
FWIW, these patches plus the original patch from https://bugs.gentoo.org/show_bug.cgi?id=504736 work with gentoo-sources-3.16.2 and vmware-modules-279.2
Comment 14 Evan Teran 2014-10-14 02:16:14 UTC
I have commited a new ebuild and set of patches to the official vmware overlay. Please give it a try (be sure to remove any user patches you have in /etc/portage/patches/ as the code should now compile *cleanly* for all kernel versions 3.10 - 3.17.

I am working with the maintainer to get the ebuild and patches merged with the mainline once it has been tested enough.
Comment 15 mephinet 2015-02-12 17:46:10 UTC
(In reply to Evan Teran from comment #14)
> I have commited a new ebuild and set of patches to the official vmware
> overlay.
I just gave the vmware overlay a try, and app-emulation/vmware-modules-279.3-r1 compile fine against kernel 3.17.8-r1.