493514 – app-text/qpdfview-0.4.7 USE=-sqlite - sources/database.cpp:514:32: error: no ‘QString Database::instanceName()’ member function declared in class ‘Database’

Bug 493514 - app-text/qpdfview-0.4.7 USE=-sqlite - sources/database.cpp:514:32: error: no ‘QString Database::instanceName()’ member function declared in class ‘Database’

Summary: app-text/qpdfview-0.4.7 USE=-sqlite - sources/database.cpp:514:32: error: no ...

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Qt Bug Alias

URL:
Whiteboard:
Keywords:	PATCH, UPSTREAM

Depends on:
Blocks:

Reported:	2013-12-07 11:48 UTC by Franz Trischberger
Modified:	2013-12-14 11:04 UTC (History)
CC List:	7 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Patch that fixes the build issue (qpdfview-0.4.7_without-sql.patch,518 bytes, patch) 2013-12-07 11:48 UTC, Franz Trischberger	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Franz Trischberger 2013-12-07 11:48:10 UTC

Created attachment 364782 [details, diff]
Patch that fixes the build issue

#ifdef in sources/database.cpp is set differently then in database.h.
Patch attached.

Comment 1 Adam Reichold 2013-12-07 12:29:56 UTC

Hello Franz,

thank you the patch fixing the inconsistency. I just committed this to revision 1391 of qpdfview's trunk, noting your help in the change log. (However, I moved the #ifdef in the header since I did not intend the method declaration to be defined conditionally.)

Best regards, Adam.

Comment 2 Markos Chandras (RETIRED) gentoo-dev

2013-12-14 11:04:08 UTC

I applied the patch myself. Hopefully the Qt will don't mind. Thanks for fixing it!

+  14 Dec 2013; Markos Chandras <hwoarang@gentoo.org>
+  +files/qpdfview-0.4.7-fix-sqlite-build.patch, qpdfview-0.4.7.ebuild:
+  Add upstream patch to fix build with USE=-sqlite. Bug #493514. Patch by Franz
+  Fellner <alpine.art.de@googlemail.com>
+