Bug 485720 – =sys-libs/timezone-data-2013f version bump

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Dirkjan Ochtman (RETIRED) 2013-09-23 08:49:28 UTC]

Please bump.

Also, I'd be happy to co-maintain timezone-data if there is no objection. I've been on the tz mailing list for a long time now, I'd like to make sure Gentoo always has up-to-date data available.

[Comment 1 Dirkjan Ochtman (RETIRED) 2013-09-26 12:28:33 UTC]

Fixed.

[Comment 2 SpanKY 2013-09-28 10:54:48 UTC]

unfortunately, the upgrade is broken in a number of ways.  like how leap & posix paths get installed.

you should also not deviate from existing style.  patches should be named with a $PN prefix.  omitting that is not ok.

i cleaned it all up for timezone-data-2013f-r1.

[Comment 3 SpanKY 2013-09-28 10:55:50 UTC]

Commit message: Clean up errors in patch/install, and handle the upgrade from previous versions
http://sources.gentoo.org/sys-libs/timezone-data/files/timezone-data-2013f-makefile.patch?rev=1.1
http://sources.gentoo.org/sys-libs/timezone-data/timezone-data-2013f-r1.ebuild?rev=1.1

[Comment 4 Dirkjan Ochtman (RETIRED) 2013-09-28 11:08:25 UTC]

Thanks for fixing it.

Is there any value in keeping the PN in patch file names, except for consistency with existing patches? And how much value is there in that consistency?

[Comment 5 SpanKY 2013-09-28 22:24:11 UTC]

(In reply to Dirkjan Ochtman from comment #4)

see http://dev.gentoo.org/~vapier/clean-patches

[Comment 6 Arfrever Frehtes Taifersar Arahesis 2013-09-30 04:09:29 UTC]

(In reply to SpanKY from comment #3)

You have added:

pkg_postinst() {
       rm -rf "${EROOT}"/usr/share/zoneinfo/.gentoo-upgrade
}

But at the end of ebuild there is:

pkg_postinst() {
    pkg_config
}

So ${EROOT}/usr/share/zoneinfo/.gentoo-upgrade directory is left after installation.

[Comment 7 SpanKY 2013-09-30 04:42:26 UTC]

Commit message: Merge duplicate pkg_postinst funcs
http://sources.gentoo.org/sys-libs/timezone-data/timezone-data-2013f-r1.ebuild?r1=1.1&r2=1.2