Bug 477820 – net-misc/networkmanager-0.9.8.2-r3 does not respect bashcompdir

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Alexander Tsoy 2013-07-22 22:59:09 UTC]

Code snippet from ebuild:

        # Fix completiondir, avoid eautoreconf, bug #465100
        sed -i 's|^completiondir =.*|completiondir = $(datadir)/bash-completion|' \
                cli/completion/Makefile.in || die "sed completiondir failed"

[Comment 1 Alexander Tsoy 2013-07-24 23:12:36 UTC]

Created attachment 354134 [details, diff]
networkmanager-0.9.8.2-r3.ebuild.patch

[Comment 2 Pacho Ramos 2013-07-25 05:44:35 UTC]

I end up having the following:
# equery files networkmanager|grep completion
/usr/share/bash-completion
/usr/share/bash-completion/completions
/usr/share/bash-completion/completions/nmcli

But I still have old bash-completion:
[ebuild   R    ] app-shells/bash-completion-1.3-r2  0 kB

Reading eclass, this shouldn't occur :(

[Comment 3 poncho 2013-07-25 06:35:45 UTC]

I think this is an issue with the added call to eautoreconf in src_prepare.
We should patch cli/completion/Makefile.am not cli/completion/Makefile.in because the later gets overridden by eautoreconf?

[Comment 4 Pacho Ramos 2013-07-25 06:51:30 UTC]

Uh! Yes! Will review it later (if nobody beats me ;))

[Comment 5 Pacho Ramos 2013-07-25 17:39:04 UTC]

+  25 Jul 2013; Pacho Ramos <[e-mail]> networkmanager-0.9.8.2-r3.ebuild:
+  Refix completion dir using eclass (#477820 by Alexander Tsoy and poncho)
+