Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 47454 - Mplayer (media-video/mplayer-1.0_pre3-r5) fails to compile with gcc 3.4
Summary: Mplayer (media-video/mplayer-1.0_pre3-r5) fails to compile with gcc 3.4
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: High normal (vote)
Assignee: Please assign to toolchain
URL:
Whiteboard:
Keywords:
: 48651 (view as bug list)
Depends on:
Blocks: 48528
  Show dependency tree
 
Reported: 2004-04-10 12:54 UTC by Tamran Lengyel
Modified: 2004-04-27 22:21 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Adds a semicolin to ao_alsa9.c on line 345 (gcc-3.4_alsafix.diff,328 bytes, patch)
2004-04-10 12:55 UTC, Tamran Lengyel
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tamran Lengyel 2004-04-10 12:54:06 UTC
Used the following use flags:

Calculating dependencies ...done!
[ebuild   R   ] media-video/mplayer-1.0_pre3-r5  -3dfx -(3dnow) +X +aalib +alsa -arts -debug -dga -directfb -dvb -dvd +encode -esd -fbcon -ggi +gif +gnome +gtk +gtk2 +ipv6 -joystick +jpeg -lirc -matroska -matrox +oggvorbis +opengl +oss -samba +sdl -(sse) -(svga) -theora +truetype -v4l -v4l2 +xmms +xv

And got the following error:

....beginning delted....

gcc -c -O4   -pipe -ffast-math -fomit-frame-pointer -D_REENTRANT -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/pango-1.0 -I/usr/X11R6/include -I/usr/include/freetype2 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include   -I. -I..   -I/usr/include/SDL -D_REENTRANT -I/usr/X11R6/include -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/pango-1.0 -I/usr/X11R6/include -I/usr/include/freetype2 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include     -o ao_alsa9.o ao_alsa9.c
ao_alsa9.c: In function `init':
ao_alsa9.c:345: error: label at end of compound statement
make[1]: *** [ao_alsa9.o] Error 1
make[1]: Leaving directory `/var/tmp/portage/mplayer-1.0_pre3-r5/work/MPlayer-1.0pre3/libao2'
make: *** [libao2/libao2.a] Error 2

!!! ERROR: media-video/mplayer-1.0_pre3-r5 failed.
!!! Function src_compile, Line 280, Exitcode 2
!!! Failed to build MPlayer!
Comment 1 Tamran Lengyel 2004-04-10 12:55:59 UTC
Created attachment 29042 [details, diff]
Adds a semicolin to ao_alsa9.c on line 345
Comment 2 Tamran Lengyel 2004-04-10 15:25:30 UTC
My attachment should fix this problem

Tamran
Comment 3 Luca Barbato gentoo-dev 2004-04-12 06:25:40 UTC
I don't recall that there is a gcc-3.4 in portage, nor that there is one published by gnu, the bug doesn't apply, yet, to us. Probably you should also tell that the mplayer developer. Good catch anyway =)
Next time please provide more information (emerge info + system specs) please.
Comment 4 Tamran Lengyel 2004-04-12 11:38:01 UTC
I know gcc 3.4 doesn't have any official ebuilds.  But it's due to release soon, and someone's gotta test these things. ;)  Anyway, here's my emerge info:

---------------------------------------
Portage 2.0.50-r3 (default-amd64-2004.0, gcc-3.4, glibc-2.3.3_pre20040207-r0, 2.6.5-bh1)
=================================================================
System uname: 2.6.5-bh1 x86_64 5
Gentoo Base System version 1.4.6
distcc 2.13 x86_64-pc-linux-gnu (protocols 1 and 2) (default port 3632) [disabled]
Autoconf: sys-devel/autoconf-2.59-r3
Automake: sys-devel/automake-1.8.3
ACCEPT_KEYWORDS="amd64 ~amd64"
AUTOCLEAN="yes"
CFLAGS="-O3 -pipe -msse -msse2 -ftracer -march=k8"
CHOST="x86_64-pc-linux-gnu"
COMPILER="gcc3"
CONFIG_PROTECT="/etc /usr/X11R6/lib/X11/xkb /usr/kde/2/share/config /usr/kde/3/share/config /usr/lib/mozilla/defaults/pref /usr/share/config /usr/share/texmf/dvipdfm/config/ /usr/share/texmf/dvips/config/ /usr/share/texmf/tex/generic/config/ /usr/share/texmf/tex/platex/config/ /usr/share/texmf/xdvi/ /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-O3 -pipe -msse -msse2 -ftracer -march=k8"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs ccache sandbox"
GENTOO_MIRRORS="http://open-systems.ufl.edu/mirrors/gentoo http://mirrors.tds.net/gentoo http://mirror.tucdemonic.org/gentoo/ http://cudlug.cudenver.edu/gentoo/"
MAKEOPTS="-j5"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="3dnow X aalib acpi aim alsa amd64 apache2 apm avi berkdb bonobo cdr crypt cups dedicated doc encode foomaticdb gdbm gif gnome gpm gtk gtk2 gtkhtml imlib ipv6 jpeg libg++ libwww mikmod mmx motif mozilla mpeg mpi msn mysql ncurses nls nogcj nptl odbc oggvorbis opengl oss pam pdflib perl plotutils png python quicktime readline sdl slang spell sse ssl tcltk tcpd tetex tiff truetype usb xml2 xmms xv yahoo zlib"
Comment 5 Tamran Lengyel 2004-04-12 11:44:19 UTC
And an lspci ... The system is a dual opteron 242 (MSI Master2-far) with 1 gig of ram.  Pre gcc 3.4 doesn't allow many (any?) x86_64 optimizations.  So, there's probably going to be a lot of amd64 folks wanting to use gcc 3.4 as soon as it's available.

--------------------------
0000:00:00.0 Host bridge: VIA Technologies, Inc. VT8385 [K8T800 AGP] Host Bridge (rev 01)
0000:00:01.0 PCI bridge: VIA Technologies, Inc. VT8237 PCI bridge [K8T800 South]
0000:00:08.0 Multimedia audio controller: Creative Labs SB Live! EMU10k1 (rev 0a)
0000:00:08.1 Input device controller: Creative Labs SB Live! MIDI/Game Port (rev 0a)
0000:00:0b.0 Ethernet controller: Broadcom Corporation NetXtreme BCM5705 Gigabit Ethernet (rev 03)
0000:00:0f.0 RAID bus controller: VIA Technologies, Inc.: Unknown device 3149 (rev 80)
0000:00:0f.1 IDE interface: VIA Technologies, Inc. VT82C586A/B/VT82C686/A/B/VT823x/A/C/VT8235 PIPC Bus Master IDE (rev 06)
0000:00:11.0 ISA bridge: VIA Technologies, Inc. VT8237 ISA bridge [K8T800 South]
0000:00:18.0 Host bridge: Advanced Micro Devices [AMD] K8 NorthBridge
0000:00:18.1 Host bridge: Advanced Micro Devices [AMD] K8 NorthBridge
0000:00:18.2 Host bridge: Advanced Micro Devices [AMD] K8 NorthBridge
0000:00:18.3 Host bridge: Advanced Micro Devices [AMD] K8 NorthBridge
0000:00:19.0 Host bridge: Advanced Micro Devices [AMD] K8 NorthBridge
0000:00:19.1 Host bridge: Advanced Micro Devices [AMD] K8 NorthBridge
0000:00:19.2 Host bridge: Advanced Micro Devices [AMD] K8 NorthBridge
0000:00:19.3 Host bridge: Advanced Micro Devices [AMD] K8 NorthBridge
0000:01:00.0 VGA compatible controller: nVidia Corporation NV28 [GeForce4 Ti 4800 SE] (rev a1)
Comment 6 Travis Tilley (RETIRED) gentoo-dev 2004-04-12 14:22:37 UTC
as a gentoo/amd64 dev, I say --AMEN TO THAT--.

just out of curiousity, but why is this patch unacceptable if it doesn't break 3.3? errr... which brings up a very important question. tamran... have you tested this patch with gcc 3.3.3?

(i cant see how it would break 3.3, but compilers are fond of complaining and/or breaking when you least want/expect them to)
Comment 7 Tamran Lengyel 2004-04-12 14:39:58 UTC
I can confirm this patch does not break on gcc 3.3.3.  The problem is, the code in mplayer was just a little sloppy on that part.  The new gcc comipiler has stricter ansi/iso standards and that's why it hiccups on this part.

I'll forward this page to the people at mplayer as well.

Regards,

Tamran
Comment 8 Travis Tilley (RETIRED) gentoo-dev 2004-04-19 09:56:15 UTC
gcc 3.4 pre-release is now in the portage tree. the current pre-release is supposed to be released as 3.4.0 final within a week or so unless something drastic happens.
Comment 9 Travis Tilley (RETIRED) gentoo-dev 2004-04-19 09:57:02 UTC
re-assigning to gcc-porting like the rest of the gcc 3.4 bugs
Comment 10 Tamran Lengyel 2004-04-19 15:25:56 UTC
The mplayer crew is also going to add this patch (with a slight mod, according to the developer wiki) to future versions.  But, for now this is the best fix according to them.

Hail to the gcc-porting team!
Comment 11 Mikko Tiihonen 2004-04-22 08:57:00 UTC
*** Bug 48651 has been marked as a duplicate of this bug. ***
Comment 12 Sebastian Dröge 2004-04-24 04:11:30 UTC
http://zebra.fh-weingarten.de/~maxi/html/mplayer-dev-eng/2004-02/msg00235.html

with all these patches mplayer compiles and runs with gcc 3.4
Comment 13 Travis Tilley (RETIRED) gentoo-dev 2004-04-27 22:21:32 UTC
sorry it took so long. fix is in CVS. :)
i'm using a gcc 3.4.0 compiled mplayer and it works beautifully. after today's work i've uninstalled gcc 3.3.3 (but i broke java... need to make a compat lib for libstdc++).

also, as a side-note, this is fixed upstream so these patches shouldnt be necessary for much longer.