Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 473864 - www-servers/nginx creates unnecessary config files
Summary: www-servers/nginx creates unnecessary config files
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Server (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Tiziano Müller (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-19 21:48 UTC by peku33
Modified: 2014-04-10 00:13 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description peku33 2013-06-19 21:48:22 UTC
Hi!

While installing nginx (currently using ~), regardless of USE flags, fastcgi.conf fastcgi_params scgi_params uwsgi_params are created.

Please also note that fastcgi.conf and fastcgi_params have the same content and they are not symbolic links.

I think factcgi.conf and fastcgi_params should be put in nginx dir only while using nginx_modules_http_fastcgi; scgi_params only with nginx_modules_http_scgi; uwsgi_params only with nginx_modules_http_uwsgi.

Those files are not required by nginx.conf (they are only used after manual edits) and without approperiate module they are useless.

Also those files should have same name conception so they should be named fastcgi.conf scgi.conf uwsgi.conf or fastcgi_params scgi_params uwsgi_params.

Thanks.
Comment 1 Johan Bergström 2013-07-19 02:43:15 UTC
1: Not installing scgi* if its not used is a good idea
2: I think its a bit risky to choose a convention of removal, since peoples configs might rely on either.

Patch for #1?
Comment 2 Johan Bergström 2013-08-08 00:26:02 UTC
I've started to work on this.

As stated above, I won't touch fastcgi* stuff (as in removing one or symlinking one to the other), as they actually differ (below), and for reasons mentioned in my previous comment

diff -u fastcgi*
--- fastcgi.conf	2013-08-07 01:58:40.000000000 +1000
+++ fastcgi_params	2013-08-07 01:58:40.000000000 +1000
@@ -1,5 +1,4 @@

-fastcgi_param  SCRIPT_FILENAME    $document_root$fastcgi_script_name;
 fastcgi_param  QUERY_STRING       $query_string;
 fastcgi_param  REQUEST_METHOD     $request_method;
 fastcgi_param  CONTENT_TYPE       $content_type;
Comment 3 Johan Bergström 2014-01-14 23:31:47 UTC
We've been doing this for a while -- see: http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/www-servers/nginx/nginx-1.5.7-r1.ebuild?revision=1.1&view=markup, line 271.

Keen on closing after this. Thoughts?
Comment 4 Johan Bergström 2014-04-10 00:13:43 UTC
Marking as closed. I'm happy enough with the end result.