Bug 465092 – =net-proxy/dante-1.3.2-r1 fixing bug Bug 380449 has mysteriously gone away

• Status: RESOLVED DUPLICATE of bug 380449
• Product: Gentoo Linux

[Description cyberbat 2013-04-08 13:30:56 UTC]

There is a bug in =net-proxy/dante-1.3.2 that is fixed in bug 380449. But I can't find any record about dante-1.3.2-r1.

I've made patch for current ebuild in dante-1.3.2 fixing the issue and a cosmetic fix checking existence of temp directory:

--- dante-sockd.orig    2013-04-08 17:22:23.000000000 +0400
+++ dante-sockd 2013-04-08 17:27:21.000000000 +0400
@@ -3,7 +3,7 @@
 # Distributed under the terms of the GNU General Public License v2
 # $Header: /var/cvsroot/gentoo-x86/net-proxy/dante/files/dante-sockd-init,v 1.7 2011/10/04 20:14:21 robbat2 Exp $
 
-SOCKD_OPT="-D"
+SOCKD_OPT=""
 [ "${SOCKD_FORKDEPTH:-1}" -gt 1 ] && SOCKD_OPT="${SOCKD_OPT} -N ${SOCKD_FORKDEPTH}"
 [ "${SOCKD_DEBUG:-0}" -eq 1 ] && SOCKD_OPT="${SOCKD_OPT} -d"
 [ "${SOCKD_DISABLE_KEEPALIVE:-0}" -eq 1 ] && SOCKD_OPT="${SOCKD_OPT} -n"
@@ -32,11 +32,9 @@
        fi
        rm /tmp/dante-sockd.checkconf
 
-       #Create pidfile with owner set to daemon's uid
        DAEMON_UID=`sed -e '/^[ \t]*user[.]notprivileged[ \t]*:/{s/.*:[ \t]*//;q};d' /etc/socks/sockd.conf`
        if [ -n "$DAEMON_UID" ]; then
-               touch $PIDFILE && chown $DAEMON_UID $PIDFILE 
-               mkdir $SOCKDIR && chown $DAEMON_UID $SOCKDIR
+               [ ! -d $SOCKDIR ] && mkdir $SOCKDIR && chown $DAEMON_UID $SOCKDIR
                [ ! -f $SOCKDIR/.keep ] && touch $SOCKDIR/.keep 
        fi
 
@@ -46,8 +44,9 @@
 start() {
        checkconfig || return 1
        ebegin "Starting dante sockd"
-       start-stop-daemon --start --quiet --pidfile $PIDFILE --env TMPDIR=$SOCKDIR \
-               --exec /usr/sbin/sockd -- ${SOCKD_OPT} >/dev/null 2>&1
+               start-stop-daemon --start --quiet \
+               --background --pidfile $PIDFILE --make-pidfile --env TMPDIR=$SOCKDIR\
+               --exec /usr/sbin/sockd -- ${SOCKD_OPT} >/dev/null 2>&1
        eend $? "Failed to start sockd"
 }

[Comment 1 Jeroen Roovers (RETIRED) 2013-04-08 18:43:35 UTC]

According to the ChangeLog and according to [1], this revision bump was never committed to the portage tree, and indeed the new init.d was never committed either. But we can reopen that bug report...

[1] http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/net-proxy/dante/?hideattic=0

*** This bug has been marked as a duplicate of bug 380449 ***

[Comment 2 Tom Wijsman (TomWij) (RETIRED) 2013-04-09 18:09:33 UTC]

+  09 Apr 2013; Tom Wijsman <[e-mail]> +dante-1.3.2-r1.ebuild,
+  +dante-1.4.0_pre1-r1.ebuild, +files/dante-1.3.2-sockd-init,
+  dante-1.1.19-r4.ebuild, dante-1.3.2.ebuild, dante-1.4.0_pre1.ebuild:
+  Revision bump of 1.3.2 and 1.4.0_pre1 fix bug #380449 (duplicate bug #465092),
+  meanwhile also added GPL-2 to LICENSE of all versions to fix bug #426122.