Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 452156 - net-print/pykota: depends on dev-python/pysqlite but not on python*[sqlite]
Summary: net-print/pykota: depends on dev-python/pysqlite but not on python*[sqlite]
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal QA (vote)
Assignee: Patrick McLean
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 452122
  Show dependency tree
 
Reported: 2013-01-14 22:08 UTC by Michał Górny
Modified: 2017-01-29 22:33 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-01-14 22:08:33 UTC
The package does depend on dev-python/pysqlite:2 but not on Python implementation USE=sqlite.

The pysqlite package is no longer maintained and compatible with Python 2 only; while the builtin 'sqlite3' module is basically a maintained clone/fork of pysqlite.

If the package actually imports pysqlite2 unconditionally, please check whether it wouldn't work with the builtin 'sqlite3' module as well. If it does, upstream should probably fix the package to import 'sqlite3' *at least* when 'pysqlite2' is not available. If it doesn't, please let us know and we will know that pysqlite needs to be kept in the tree.

If the package simply supports 'sqlite3', please let us know or update the deps. However, the latter is unnecessary since the 'old' Python eclass doesn't provide a proper way to do this, and we may decide to drop pysqlite entirely after getting feedback for the packages depending on it.
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-01-15 23:36:03 UTC
This one imports 'pysqlite2' only. Need to investigate if it works with sqlite3 as well.
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-01-16 11:59:43 UTC
I have tested the package by setting up sqlite3 db as README states and running the test script from sources. I have been able to get it to work successfully with python2.5 and 2.7, both with pysqlite2 and sqlite3 modules.

For testing, I have replaced the:

    from pysqlite2 import dbapi2 as sqlite

line with:

    import sqlite3 as sqlite

Therefore, the package needlessly pulls in and uses external pysqlite2.
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-01-17 16:48:31 UTC
Ebuild fixed. Can you report it upstream, please?
Comment 4 Dion Moult (RETIRED) gentoo-dev 2013-03-25 00:38:43 UTC
From my understanding, because pysqlite has been removed, and the ebuild already replaces the pysqlite import with sqlite3 import, this bug is fixed?
Comment 5 Andreas K. Hüttel archtester gentoo-dev 2017-01-29 22:33:33 UTC
(In reply to Michał Górny from comment #3)
> Ebuild fixed. Can you report it upstream, please?

There's been no upstream commit anymore since 2013. No point.