444082 – sys-fs/lvm2-2.02.97 does hardcoded AR calls

Bug 444082 - sys-fs/lvm2-2.02.97 does hardcoded AR calls

Summary: sys-fs/lvm2-2.02.97 does hardcoded AR calls

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	[OLD] Core system (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Robin Johnson

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	tc-directly
	Show dependency tree

Reported:	2012-11-20 19:03 UTC by Denis M. (Phr33d0m)
Modified:	2012-11-24 09:01 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
lvm2-2.02.97-fix-ar.patch (file_444082.txt,663 bytes, text/plain) 2012-11-23 11:24 UTC, Vicente Olivert Riera (RETIRED)	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Denis M. (Phr33d0m) 2012-11-20 19:03:12 UTC

$ ▶ ./blatt.sh /var/tmp/portage/logs/sys-fs\:lvm2-2.02.97\:20121120-145452.log 
>>> sys-fs/lvm2-2.02.97: ISSUES FOUND
> Hardcoded calls:
ar rs ioctl/libdevmapper.a datastruct/bitset.o datastruct/hash.o datastruct/list.o libdm-common.o libdm-file.o libdm-deptree.o libdm-string.o libdm-report.o libdm-config.o mm/dbg_malloc.o mm/pool.o regex/matcher.o regex/parse_rx.o regex/ttree.o ioctl/libdm-iface.o
ar rs libdevmapper-event.a libdevmapper-event.o
ar rs libdaemonclient.a daemon-shared.o daemon-client.o
ar rs libdaemonserver.a daemon-server.o
ar rs liblvm-internal.a activate/activate.o cache/lvmcache.o [...]

Reproducible: Always

Comment 1 Vicente Olivert Riera (RETIRED) gentoo-dev

2012-11-22 16:04:37 UTC

This patch fixed the problem.

--- lvm2-2.02.97.ebuild	2012-11-22 17:03:32.837389023 +0100
+++ lvm2-2.02.97.ebuild.orig	2012-11-22 17:02:44.444317857 +0100
@@ -200,7 +200,7 @@
 	popd
 
 	einfo "Starting main build"
-	emake AR="$(tc-getAR)" || die "compile fail"
+	emake || die "compile fail"
 }
 
 src_install() {

Comment 2 Vicente Olivert Riera (RETIRED) gentoo-dev

2012-11-23 10:40:27 UTC

(In reply to comment #1)

Still calling AR directly at one point:

fujitsu sys-fs # grep ^ar lvm2*                        
lvm2-2.02.97-r1:20121123-103524.log:ar rs liblvm2cmd-static.a dumpconfig.o formats.o lvchange.o lvconvert.o lvcreate.o lvdisplay.o lvextend.o lvmchange.o lvmcmdline.o lvmdiskscan.o lvreduce.o lvremove.o lvrename.o lvresize.o lvscan.o polldaemon.o pvchange.o pvck.o pvcreate.o pvdisplay.o pvmove.o pvremove.o pvresize.o pvscan.o reporter.o segtypes.o toollib.o vgcfgbackup.o vgcfgrestore.o vgchange.o vgck.o vgcreate.o vgconvert.o vgdisplay.o vgexport.o vgextend.o vgimport.o vgmerge.o vgmknodes.o vgreduce.o vgremove.o vgrename.o vgscan.o vgsplit.o lvmcmdlib.o lvm2cmd-static.o

Comment 3 Vicente Olivert Riera (RETIRED) gentoo-dev

2012-11-23 11:24:28 UTC

Created attachment 330320 [details]
lvm2-2.02.97-fix-ar.patch

Now it's ok :-)

Comment 4 Pacho Ramos gentoo-dev

2012-11-24 08:45:35 UTC

+*lvm2-2.02.97-r1 (24 Nov 2012)
+
+  24 Nov 2012; Pacho Ramos <pacho@gentoo.org> +lvm2-2.02.97-r1.ebuild:
+  Fix strict aliasing bug (#444328 by MJJoker, Alexander Tsoy and Vicente
+  Olivert Riera), fix AR being called directly (#444082 by Vicente Olivert
+  Riera).
+

Comment 5 Denis M. (Phr33d0m) 2012-11-24 09:01:16 UTC

Oh, I feel offended now, I wasn't even mentioned in the commit message.
Hehe, joking of course :)