434086 – cmake-utils.eclass: CMAKE_INSTALL_LIBDIR is not prefixed

Bug 434086 - cmake-utils.eclass: CMAKE_INSTALL_LIBDIR is not prefixed

Summary: cmake-utils.eclass: CMAKE_INSTALL_LIBDIR is not prefixed

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Eclasses (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Gentoo KDE team

URL:
Whiteboard:
Keywords:	PATCH

Depends on:
Blocks:	425342 431308
	Show dependency tree

Reported:	2012-09-06 05:57 UTC by Christoph Junghans (RETIRED)
Modified:	2012-09-20 10:34 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
patch for cmake-utils.eclass (cmake-utils.eclass.patch,650 bytes, patch) 2012-09-06 05:57 UTC, Christoph Junghans (RETIRED)	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Christoph Junghans (RETIRED) gentoo-dev

2012-09-06 05:57:13 UTC

Created attachment 323044 [details, diff]
patch for cmake-utils.eclass

CMAKE_INSTALL_LIBDIR in gentoo_common_config.cmake is not prefixed, which is needed for example for dev-libs/pugixml.

Comment 1 Michael Palimaka (kensington) gentoo-dev

2012-09-06 14:56:20 UTC

Pushed to the overlay.

http://git.overlays.gentoo.org/gitweb/?p=proj/kde.git;a=commit;h=efa380fce0f4d090ca3a7f6fbb1c6cd546fb6537

Comment 2 Christoph Junghans (RETIRED) gentoo-dev

2012-09-07 19:22:06 UTC

T think a better solution to that issue would be to simply set CMAKE_INSTALL_LIBDIR to $(get_libdir). CMake adds the current prefix automatically anyway and for case, where CMAKE_INSTALL_LIBDIR != ../usr/lib.. (like libexec) one will have to overwrite the default anyhow.

Comment 3 Michael Palimaka (kensington) gentoo-dev

2012-09-09 18:42:48 UTC

Thanks, updated in the overlay.

http://git.overlays.gentoo.org/gitweb/?p=proj/kde.git;a=commit;h=f527a112c66b1e4a785efd6f2a9cfcb81b42f230

Comment 4 Michael Palimaka (kensington) gentoo-dev

2012-09-20 10:34:09 UTC

Thanks, moved to the main tree.

+  20 Sep 2012; Michael Palimaka <kensington@gentoo.org> cmake-utils.eclass:
+  Add support for the ninja build system wrt bug #430608. Improve prefix
+  support wrt bug #434086.