Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 43027 - added DNotify patch back to fam-2.7.0
Summary: added DNotify patch back to fam-2.7.0
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: foser (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-02-26 13:39 UTC by Vaclav Slavik
Modified: 2004-04-22 00:44 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch for the ebuild (fam-2.7.0.ebuild.patch,566 bytes, patch)
2004-02-26 13:39 UTC, Vaclav Slavik
Details | Diff
fam-2.7.0-dnotify.patch (fam-2.7.0-dnotify.patch,25.80 KB, patch)
2004-02-26 13:40 UTC, Vaclav Slavik
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vaclav Slavik 2004-02-26 13:39:09 UTC
The FAM library can take advantage of Linux's dnotify feature to avoid polling files for changes. It's not part of standard fam distribution, you have to apply a patch. This patch was removed from app-admin/fam in 2.7.0 (2.6.10-r1 had it). There's no mention of it in ChangeLog other than "New release, obsoletes most of the patches", so maybe it was a mistake? Anyway, this patch is pretty important (it improves responsibility), so I took updated patch for 2.7.0 from Debian package and modified the ebuild to apply it. Patches attached, tested & working.

Reproducible: Always
Steps to Reproduce:
Comment 1 Vaclav Slavik 2004-02-26 13:39:43 UTC
Created attachment 26426 [details, diff]
patch for  the ebuild
Comment 2 Vaclav Slavik 2004-02-26 13:40:16 UTC
Created attachment 26427 [details, diff]
fam-2.7.0-dnotify.patch
Comment 3 Spider (RETIRED) gentoo-dev 2004-02-26 13:49:15 UTC
Yes, thats correct. However, with DNotify there is another issue in descriptor leakage for removable devices.  By not providing the DNotify event tracker in fam there is no longer an issue with this, which is of more importance than the slight boost in responsiveness.
Comment 4 Vaclav Slavik 2004-02-26 14:11:51 UTC
Are you sure this is still true for 2.7.0 and latest (i.e. this one, Debian's) version of dnotify patch? From Debian's changelog (http://packages.debian.org/changelogs/pool/main/f/fam/fam_2.7.0-5/changelog):
"""
fam (2.7.0-1) experimental; urgency=low

  * New upstream release 
    (closes: Bug#224738):
    - should fix problems with unmounting filesystems with
      monitored files 
      (closes: Bug#225636)
"""
Comment #27 at http://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=106936 seems to indicate DNotify patch was fixed, too (it's dated 2004-02-04).

> which is of more importance than the slight boost in responsiveness.

As for "slight", I noticed this because KGhostview's Watch File feature started to react considerably slower (as in immediately vs. something that felt like 1-2 seconds later) after I set up famd.
Comment 5 foser (RETIRED) gentoo-dev 2004-03-14 14:22:20 UTC
ok re-added dnotify support in fam-2.7.0-r1

I indeed couldn't reproduce the old locking problems, but that might also have todo with fixes in other packages. We'll just have to see how it goes. This patch seems quite a bit altered from the original.

about 'slight' , fam without monitor polls once p.sec afaik vs almost immediatly now. It looks better, but it doesn't matter that much.
Comment 6 jack_mort 2004-04-21 04:20:01 UTC
Here, with fam-2.7.0-r1, I've still the problem with removable devices...
Comment 7 foser (RETIRED) gentoo-dev 2004-04-21 15:32:45 UTC
describe the exact problem & how it is reproducable . I can't reproduce the old problem.
Comment 8 jack_mort 2004-04-22 00:44:22 UTC
Well, it's quite simple :

In nautilus :
- start famd...
- mount a floppy/usbkey
- access it with nautilus to copy or read some files on it
- try to unmount the floppy/usbkey

Nautilus complains the device is busy... Try in a term. Same thing. With a lsof, you see that the mount point is beeing monitored by famd... Restart or stop famd : you can unmount.