Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 424163 - app-text/fbreader-0.12.10 fails to query fribidi's pkg-config file for correct Cflags: and fails to compile because of it
Summary: app-text/fbreader-0.12.10 fails to query fribidi's pkg-config file for correc...
Status: RESOLVED DUPLICATE of bug 417043
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal with 1 vote (vote)
Assignee: Alexey Shvetsov
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-29 21:04 UTC by Alexander Bezrukov
Modified: 2012-07-08 22:56 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
emerge --info (emerge.info.@black,5.28 KB, text/plain)
2012-06-29 21:04 UTC, Alexander Bezrukov 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Bezrukov 2012-06-29 21:04:25 UTC 
Created attachment 316647 [details]
emerge --info

Build of app-text/fbreader-0.12.10 fails with:
Compiling ZLTextParagraphCursor.o ...In file included from /usr/include/fribidi/fribidi.h:35:0,
                 from ZLTextParagraphBuilder.h:26,
                 from ZLTextParagraphCursor.cpp:26:
/usr/include/fribidi/fribidi-common.h:65:20: fatal error: glib.h: No such file or directory
compilation terminated.

This failure doesn't depend on the gtk USE flag.

$ emerge -pv fribidi fbreader

These are the packages that would be merged, in order:

Calculating dependencies... done!
[ebuild   R    ] dev-libs/fribidi-0.19.2-r2  USE="-static-libs" 0 kB
[ebuild   R    ] app-text/fbreader-0.12.10  USE="qt4 -debug -gtk" 0 kB

Total: 2 packages (2 reinstalls), Size of downloads: 0 kB
Comment 1 Alexander Bezrukov 2012-06-29 21:05:57 UTC 
$ eix -I ^glib$
[I] dev-libs/glib
     Available versions:  
	(1)	1.2.10-r5
	(2)	2.30.2 2.30.3 ~2.32.2 ~2.32.3
	{debug doc fam hardened kernel_linux selinux (+)static-libs systemtap test utils xattr}
     Installed versions:  1.2.10-r5(1)(12:03:14 AM 06/30/2012)(hardened) 2.30.3(2)(11:55:55 PM 06/29/2012)(static-libs -debug -doc -fam -selinux -systemtap -test -utils -xattr)
     Homepage:            http://www.gtk.org/
     Description:         The GLib library of C routines
Comment 2 Maks Verver 2012-06-30 00:47:41 UTC 
A quick fix is to edit the ebuild and add a line like this to the bottom of src_prepare():

sed -i '/^CFLAGS = /s/$/ $(shell pkg-config fribidi --cflags)/' makefiles/arch/desktop.mk || die
Comment 3 Alexander Bezrukov 2012-07-01 12:48:55 UTC 
(In reply to comment #2)

I can confirm, this fixes the failure.
Comment 4 Samuli Suominen (RETIRED) gentoo-dev 2012-07-03 10:47:53 UTC 
This could be resolved like following...

1. virtual/pkgconfig to DEPEND
2. inherit flag-o-matic toolchain-funcs
3. append-cppflags "$($(tc-getPKG_CONFIG) --cflags fribidi)" #424163

As in, you can't skip fribidi's pkg-config file if you plan on using the library.

The problem is that fbreader is ignoring all of CFLAGS, CXXFLAGS and CPPFLAGS so append-flags won't be working out of box

I'll leave this to maintainer for handling, alternative is lastriting
Comment 5 Stefan Kuhn 2012-07-05 01:55:49 UTC 
This is a duplicate of bug #417043

I'll add my patch and test-results there.
Comment 6 Johannes Huber (RETIRED) gentoo-dev 2012-07-08 22:56:05 UTC 
(In reply to comment #5)
> This is a duplicate of bug #417043
> 
> I'll add my patch and test-results there.

Thanks.

*** This bug has been marked as a duplicate of bug 417043 ***