Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 41416 - ppp-2.4.2 fails to build
Summary: ppp-2.4.2 fails to build
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: x86 Linux
: High normal (vote)
Assignee: Gentoo Dialup Developers
URL:
Whiteboard:
Keywords:
: 41451 41635 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-02-12 14:05 UTC by Colin Tinker
Modified: 2004-03-05 09:54 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch to pppd source (pcap.patch,728 bytes, patch)
2004-02-13 16:49 UTC, Peter Gantner (a.k.a. nephros)
Details | Diff
patch to ebuild (ebuild.patch,592 bytes, patch)
2004-02-13 16:54 UTC, Peter Gantner (a.k.a. nephros)
Details | Diff
patch to disable activefilter (ppp-2.4.2.ebuild.diff,893 bytes, patch)
2004-02-15 02:08 UTC, gentoo
Details | Diff
alternative patch (ppp-2.4.2-bpf.patch,567 bytes, patch)
2004-02-15 02:55 UTC, jochen
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Colin Tinker 2004-02-12 14:05:53 UTC
make[1]: *** [demand.o] Error 1
make[1]: *** Waiting for unfinished jobs....
sys-linux.c:144:21: net/bpf.h: No such file or directory
sys-linux.c: In function `set_filters':
sys-linux.c:1324: error: dereferencing pointer to incomplete type
sys-linux.c:1325: error: dereferencing pointer to incomplete type
sys-linux.c:1333: error: dereferencing pointer to incomplete type
sys-linux.c:1334: error: dereferencing pointer to incomplete type
make[1]: *** [sys-linux.o] Error 1
make[1]: Leaving directory `/var/tmp/portage/ppp-2.4.2/work/ppp-2.4.2/pppd'
make: *** [all] Error 2

!!! ERROR: net-dialup/ppp-2.4.2 failed.
!!! Function src_compile, Line 52, Exitcode 2
!!! (no error message)

merge info
Portage 2.0.50-r1 (default-x86-1.4, gcc-3.3.2, glibc-2.3.3_pre20040207-r0, 2.6.2)
=================================================================
System uname: 2.6.2 i686 AMD Athlon(tm) processor
Gentoo Base System version 1.4.3.13
Autoconf: sys-devel/autoconf-2.59
Automake: sys-devel/automake-1.8.2
ACCEPT_KEYWORDS="x86 ~x86"
AUTOCLEAN="yes"
CFLAGS="-march=athlon-tbird -O3 -funroll-loops -pipe"
CHOST="i686-pc-linux-gnu"
COMPILER="gcc3"
CONFIG_PROTECT="/etc /usr/X11R6/lib/X11/xkb /usr/kde/2/share/config /usr/kde/3.2/share/config /usr/kde/3/share/config /usr/share/config /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/env.d"
CXXFLAGS="-march=athlon-tbird -O3 -funroll-loops -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs buildpkg ccache cvs distcc fixpackages keeptemp keepwork notitles sandbox userpriv usersandbox"
GENTOO_MIRRORS="http://www.mirror.ac.uk/sites/www.ibiblio.org/gentoo/"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY=""
SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage"
USE="3dnow X aalib acpi acpi4linux apm arts avi berkdb bonobo cdr chroot crypt cups curl dga directfb dvd encode esd ethereal faad fam fbcon flac foomaticdb freetype gdbm gif gnome gphoto2 gpm gtk gtk2 imagemagick imlib ipv6 java jpeg kde ldap libg++ libwww mad mikmod mmx motif mozilla mpeg mpeg4 mysql ncurses nls oggvorbis opengl oss pam pcap pdflib perl pic png postgres prelink python qt quicktime readline scanner sdl slang sox speedo spell ssl svga t1lib tcpd tiff transcode truetype usb v4l vanilla vim-with-x x86 xfs xml2 xmms xv zlib zvbi"

Reproducible: Always
Steps to Reproduce:
1.emerge -Du ppp
2.
3.

Actual Results:  
demand.c:53:21: net/bpf.h: No such file or directory
make[1]: *** [demand.o] Error 1
make[1]: *** Waiting for unfinished jobs....
sys-linux.c:144:21: net/bpf.h: No such file or directory
sys-linux.c: In function `set_filters':
sys-linux.c:1324: error: dereferencing pointer to incomplete type
sys-linux.c:1325: error: dereferencing pointer to incomplete type
sys-linux.c:1333: error: dereferencing pointer to incomplete type
sys-linux.c:1334: error: dereferencing pointer to incomplete type
make[1]: *** [sys-linux.o] Error 1
make[1]: Leaving directory `/var/tmp/portage/ppp-2.4.2/work/ppp-2.4.2/pppd'
make: *** [all] Error 2

!!! ERROR: net-dialup/ppp-2.4.2 failed.
!!! Function src_compile, Line 52, Exitcode 2
!!! (no error message)


Expected Results:  
Build cleanly
Comment 1 Andrew Kirilenko 2004-02-13 02:30:24 UTC
Same here. Which linux-headers d'you have installed? Or maybe it's getting them from the /usr/src/linux?
Comment 2 flibble 2004-02-13 03:36:30 UTC
same here also:
gcc -march=pentium3 -mcpu=pentium4 -mno-sse2 -O2 -pipe -DHAVE_PATHS_H -DIPX_CHANGE -DHAVE_MMAP -I../include -DCHAPMS=1 -DMPPE=1 -DHAS_SHADOW -DHAVE_CRYPT_H=1 -DUSE_CRYPT=1 -DUSE_PAM -DHAVE_MULTILINK -DUSE_TDB=1 -DPLUGIN -DPPP_FILTER -I/usr/include/pcap -DCBCP_SUPPORT -DMAXOCTETS   -c -o utils.o utils.c
make[1]: *** [demand.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory `/var/tmp/portage/ppp-2.4.2/work/ppp-2.4.2/pppd'
make: *** [all] Error 2

!!! ERROR: net-dialup/ppp-2.4.2 failed.
!!! Function src_compile, Line 52, Exitcode 2
!!! (no error message)

#emerge info

Portage 2.0.50-r1 (default-x86-1.4, gcc-3.3.2, glibc-2.3.3_pre20040207-r0, 2.6.3-rc1-gentoo)
=================================================================
System uname: 2.6.3-rc1-gentoo i686 Intel(R) Pentium(R) 4 CPU 2.66GHz
Gentoo Base System version 1.4.3.13
Autoconf: sys-devel/autoconf-2.59
Automake: sys-devel/automake-1.8.2
ACCEPT_KEYWORDS="x86 ~x86"
AUTOCLEAN="yes"
CFLAGS="-march=pentium3 -mcpu=pentium4 -mno-sse2 -O2 -pipe"
CHOST="i686-pc-linux-gnu"
COMPILER="gcc3"
CONFIG_PROTECT="/etc /usr/X11R6/lib/X11/xkb /usr/kde/2/share/config /usr/kde/3.2/share/config /usr/kde/3/share/config /usr/share/config /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /usr/X11R6/bin/startx /etc/env.d"
CXXFLAGS="-march=pentium3 -mcpu=pentium4 -mno-sse2 -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs ccache sandbox"
GENTOO_MIRRORS="http://gentoo.oregonstate.edu http://www.ibiblio.org/pub/Linux/distributions/gentoo"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="X aalib acpi4linux alsa arts avi berkdb cdr crypt cups encode esd foomaticdb gdbm gif gnome gphoto2 gpm gtk gtk2 imlib java jpeg kde libg++ libwww mad mikmod mmx motif mozilla mpeg mplayer ncurses nls oggvorbis opengl oss pam pdflib perl png python qt quicktime readline sdl slang spell sse ssl svga tcltk tcpd truetype wxwindows x86 xine xml xml2 xmms xv zlib"

Using sys-kernel/linux-headers-2.4.22
Comment 3 Peter Gantner (a.k.a. nephros) 2004-02-13 03:49:43 UTC
the stuff from net/bpf.h has been moved to pcap-bpf.h (from net-libs/libpcap)

FIX:
edit ppp-2.4.2/work/ppp-2.4.2/pppd/sys-linux.c and demand.c and replace
#include <net/bpf.h>
with
#include <pcap-bpf.h>

This makes it compile at least, I have not tested pppd yet ;)
Comment 4 flibble 2004-02-13 04:40:43 UTC
This fix works for me. Thanks Peter. I did have to disregard the two updates to ip-up and ip-down that etc-update wanted to do though. When I accepted them, ppp would dial and connect but apps couldn't see the connection. *shrug*
Comment 5 Heinrich Wendel (RETIRED) gentoo-dev 2004-02-13 13:11:47 UTC
*** Bug 41451 has been marked as a duplicate of this bug. ***
Comment 6 Heinrich Wendel (RETIRED) gentoo-dev 2004-02-13 13:12:02 UTC
*** Bug 41457 has been marked as a duplicate of this bug. ***
Comment 7 Peter Gantner (a.k.a. nephros) 2004-02-13 16:49:08 UTC
Created attachment 25569 [details, diff]
patch to pppd source

patch to incorporate the two oneliners above.
place in files/2.4.2/pcap.patch
Comment 8 Peter Gantner (a.k.a. nephros) 2004-02-13 16:54:30 UTC
Created attachment 25570 [details, diff]
patch to ebuild

add epatch line to incorporate patch above
make ebuild depend on libpcap even without the activefilter USE flag set.
Comment 9 Aron Griffis (RETIRED) gentoo-dev 2004-02-14 19:21:55 UTC
Thanks for the patches, they're applied now.
Comment 10 gentoo 2004-02-15 02:08:44 UTC
Created attachment 25643 [details, diff]
patch to disable activefilter
Comment 11 jochen 2004-02-15 02:55:06 UTC
Created attachment 25647 [details, diff]
alternative patch

I don't think the patch is a good solution. The file pcap-bpf.h is not included
in libpcap 0.7.1 (and 0.8.1 is marked ~x86)

However, pcap.h which is included in both versions includes the correct bpf.h
file in both versions.

IMHO the correct solution is to include pcap.h
Comment 12 Ming Zhao (RETIRED) gentoo-dev 2004-02-15 03:28:48 UTC
I think the ebuild should be modified because the FILTER option is enabled by default in ppp-2.4.2,
so maybe the following 
    use activefilter && {
        einfo "Enabling active-filter"
        sed -i -e "s/^#FILTER=y/FILTER=y/" pppd/Makefile.linux || die
    }

should be replaced with:
    use activefilter || {
        einfo "Disabling active-filter"
        sed -i -e "s/^FILTER=y/#FILTER=y/" pppd/Makefile.linux
    }
Comment 13 Martin Holzer (RETIRED) gentoo-dev 2004-02-15 05:17:28 UTC
*** Bug 41635 has been marked as a duplicate of this bug. ***
Comment 14 Jesse Adelman 2004-02-15 23:26:51 UTC
Still getting this error, but it was marked as RESOLVED FIXED. Notes don't indicate a fix. Is it fixed?
Comment 15 Andrey Kolbasenko 2004-02-16 00:50:21 UTC
Thank's!

It's OK now. PPP maked successfully after emerge sync.
Comment 16 Chuck Brewer 2004-02-17 20:26:31 UTC
I don't know how this got jacked, but plz remove depend on libpcap.
 activefilter should be off by default, and it should be
activefilter?(dev-libs/libpcap) for the depends. I was trying to go
this way when I rewrote it, however I couldnt get any testing peeps on 
activefilter portion, so it was never completed. Please change asap,thanks:)
Comment 17 Matt Oquist 2004-03-04 20:12:13 UTC
I'm getting a build problem that seems related to this, though my problem may simply be that I don't normally run ~x86.

My compilation dies with this message:
----------------------------------------------------------
demand.c:53:22: pcap-bpf.h: No such file or directory
make[1]: *** [demand.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory `/var/tmp/portage/ppp-2.4.2/work/ppp-2.4.2/pppd'
make: *** [all] Error 2

!!! ERROR: net-dialup/ppp-2.4.2 failed.
!!! Function src_compile, Line 55, Exitcode 2
!!! (no error message)
----------------------------------------------------------

I have libpcap installed:
----------------------------------------------------------
*  net-libs/libpcap
      Latest version available: 0.7.2-r1
      Latest version installed: 0.7.2
----------------------------------------------------------

But pcap-bpf.h doesn't appear to be among the files that come with libpcap 0.7.2:
----------------------------------------------------------
philonous tmp # qpkg -l libpcap
net-libs/libpcap-0.7.2-r1 *
CONTENTS:
/usr
/usr/include
/usr/include/pcap.h
/usr/include/net
/usr/include/net/bpf.h
/usr/include/pcap-namedb.h
/usr/lib
/usr/lib/libpcap.so.0.7
/usr/lib/libpcap.a
/usr/lib/libpcap.so.0 -> /usr/lib/libpcap.so.0.7
/usr/lib/libpcap.so -> /usr/lib/libpcap.so.0.7
/usr/share
/usr/share/man
/usr/share/man/man3
/usr/share/man/man3/pcap.3.gz
/usr/share/doc
/usr/share/doc/libpcap-0.7.2-r1
/usr/share/doc/libpcap-0.7.2-r1/FILES.gz
/usr/share/doc/libpcap-0.7.2-r1/README.aix.gz
/usr/share/doc/libpcap-0.7.2-r1/README.tru64.gz
/usr/share/doc/libpcap-0.7.2-r1/LICENSE.gz
/usr/share/doc/libpcap-0.7.2-r1/CREDITS.gz
/usr/share/doc/libpcap-0.7.2-r1/README.hpux.gz
/usr/share/doc/libpcap-0.7.2-r1/README.linux.gz
/usr/share/doc/libpcap-0.7.2-r1/CHANGES.gz
/usr/share/doc/libpcap-0.7.2-r1/VERSION.gz
/usr/share/doc/libpcap-0.7.2-r1/README.gz

philonous tmp # find /usr/include/ | grep pcap
/usr/include/pcap.h
/usr/include/pcap-namedb.h
----------------------------------------------------------

I don't normally run ~x86, but I want ppp-2.4.2.  I'm backing up my system and then I'll upgrade libpcap with ACCEPT_KEYWORDS="~x86" (and I'll get ~x86 glibc, gcc, etc...), and perhaps pcap-bpf.h will show up then.

I realize this package is marked ~x86, but figured it wouldn't hurt to mention that I was seeing this problem.
Comment 18 Dennis Freise 2004-03-05 09:54:19 UTC
Update libpcap to ~x86, and it will compile. x86 libpcap currently has "pcap.h" and ~x86 libpcap has "pcap-bpf.h".