Builds fine for me on hppa with the following patches removed: cmake-2.8.4-FindPythonLibs.patch (see #405181) cmake-2.8.3-more-no_host_paths.patch (does not apply) cmake-2.8.4-FindBoost.patch cmake-2.8.7-FindOpenMP.patch (both applied upstream) Reproducible: Always
(In reply to comment #0) > Builds fine for me on hppa with the following patches removed: > > cmake-2.8.4-FindPythonLibs.patch > (see #405181) Removal of this patch is wrong as long it is not decided. > cmake-2.8.3-more-no_host_paths.patch > (does not apply) Needs a replacement for 2.8.8. > cmake-2.8.4-FindBoost.patch > cmake-2.8.7-FindOpenMP.patch Confirmed.
> > cmake-2.8.3-more-no_host_paths.patch > > (does not apply) > > Needs a replacement for 2.8.8. =dev-util/cmake-2.8.8 is now masked in kde overlay. The mentioned patch is not done yet.
Created attachment 309779 [details, diff] cmake-2.8.8-more-no_host_paths.patch And here's the patch, updated for 2.8.8, I will commit this to the overlay shortly.
(In reply to comment #1) > (In reply to comment #0) > > Builds fine for me on hppa with the following patches removed: > > > > cmake-2.8.4-FindPythonLibs.patch > > (see #405181) > > Removal of this patch is wrong as long it is not decided. I dropped it because it would not apply anyway because the FindPython* modules have been much improved upstream. And because the patch is wrong anyway ;P
Created attachment 309861 [details, diff] replacement patch for cmake-2.8.4-FindPythonLibs.patch This untested patch should be a replacement for the FindPythonLibs modification that should both work and be correct in regard to 405181. Please verify if that works for you as expected, then I'll push something like that upstream.
As a note: one of the tests is failing really disastrously: something comments out the prefix for test 62, Qt4Deploy, and that test runs an rm -rf on the dir it's installing things to, which in the absence of the prefix is /usr/local. In other words, it breaks out of the sandbox and also manages to run rm -rf /usr/local/*. I restricted tests a few days ago, but wanted to make a note of that here.
cmake 2.8.8 contains some changes in FindPythonInterp.cmake and FindPythonLibs.cmake. I will work on updated patch for these files.
Created attachment 310327 [details, diff] cmake-2.8.8-python.patch This patch should work. It replaces cmake-2.8.4-FindPythonLibs.patch for cmake 2.8.8.
The FindPythonLibs part is wrong as described in bug 405181 (short version: try find_package(PythonLibs 3) with your patch). The FindPythonInterp patch is completely wrong. If the developer did not specify a version to find then the module will already look at "python" as the executable first. If the developer did specify a major version (find_package(PythonInterp 3) then it should look at "python3" first, then trying it's known python versions and returning the highest one. If the developer did specify a more detailed version (e.g. 3.2) then it will return the highest version of that major (i.e. 3.3, then 3.2). So in my eyes it behaves sensible in all cases already, but your patch breaks all cases where the developer did not just want "any python".
(In reply to comment #9) I suggest to move discussion about Python patches to bug #405181.
Thank you all. + 02 May 2012; Johannes Huber <johu@gentoo.org> +cmake-2.8.8-r1.ebuild, + +files/cmake-2.8.8-FindPkgConfig.patch, + +files/cmake-2.8.8-more-no_host_paths.patch, +files/cmake-2.8.8-tests.patch: + Version bump by me and Chris Reffett <geekboy72@gmail.com> wrt bug #412925. + Adds patch for FindPkgConfig to respect PKG_CONFIG environment variable by + DaboD <daiderek@gmail.com> bug #414037. (In reply to comment #10) > (In reply to comment #9) > > I suggest to move discussion about Python patches to bug #405181. Indeed the discussion of the python patches should discussed in bug #405181.
*** Bug 414441 has been marked as a duplicate of this bug. ***
