Bug 406009 – Keword ~x86-fbsd on dev-java/libmatthew-java

• Status: RESOLVED FIXED
• Product: Gentoo/Alt

[Description Naohiro Aota 2012-02-27 10:37:12 UTC]

Created attachment 303491 [details, diff]
libmatthew-java-0.7.2-makefile-fixes.patch.patch

We need libmatthew-java keyworded to keyword zemberek-server (#232411).

The current files/libmatthew-java-0.7.2-makefile-fixes.patch have two
problems.

1. It specify "-I$(JAVA_HOME)/include/linux" which does not exists on
   FreeBSD (or any non-Linux platforms)

2. It leave "make"s untouched, which should be replaced with "$(MAKE)"
   to work also when it is called "gmake"

The attached patch for
files/libmatthew-java-0.7.2-makefile-fixes.patch is for

1. Don't set INCLUDES anymore. INCLUDES are properly set with
   INCLUDES="$(java-pkg_get-jni-cflags)" in the ebuild

2. Replace "make"s wiht "$(MAKE)"

Java team, if you don't see any problem with the patch, could you
apply it or give me ACK to commit the change.

[Comment 1 Naohiro Aota 2012-05-27 04:30:15 UTC]

Any comment on this patch? I'll apply it if you don't see any problem.

[Comment 2 Ralph Sennhauser (RETIRED) 2012-05-27 20:35:02 UTC]

Looks fine, go ahead. Thanks.

[Comment 3 Naohiro Aota 2012-05-29 10:08:15 UTC]

Patch and ~x86-fbsd added, thanks. Leave this for ~amd64-fbsd KEYWORDing.

[Comment 4 Alexis Ballier 2012-08-06 21:40:40 UTC]

(In reply to comment #3)
> Leave this for ~amd64-fbsd KEYWORDing.

if someone has interest and tests it on amd64-fbsd, yes, but for now, no
closing

[Comment 5 Patrice Clement 2015-06-15 00:36:28 UTC]

See Alexis' answer.