Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 388545 - app-laptop/laptop-mode-tools fails to start with kernel 3.1
Summary: app-laptop/laptop-mode-tools fails to start with kernel 3.1
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Mobile Herd (OBSOLETE)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-26 12:54 UTC by Erich Seifert
Modified: 2012-01-01 15:57 UTC (History)
8 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Drop kernel version check from laptop-mode-tools 1.55 (laptop-mode-tools-1.55-no-version-check.patch,406 bytes, patch)
2011-10-26 13:02 UTC, Erich Seifert
Details | Diff
Drop kernel version check from laptop-mode-tools 1.55 module (laptop-mode-tools-1.55-modules-no-version-check.patch,3.14 KB, patch)
2011-10-27 00:29 UTC, Erich Seifert
Details | Diff
patch to make laptop-mode-tools-1.55 work with all 3.x kernels (laptop-mode-tools-1.55-linux3-support.patch,2.06 KB, patch)
2011-11-24 09:08 UTC, Stefano Takekawa
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Erich Seifert 2011-10-26 12:54:50 UTC
The available ebuilds for app-laptop/laptop-mode-tools (1.55-r1 and 1.55-r2) fail to start with kernel 3.1. The ebuilds should be updated to 1.58 which fixed the problem by removing version check completely.

Reproducible: Always

Steps to Reproduce:
1. Install app-laptop/laptop-mode-tools on a system with kernel 3.1 or higher
2. /etc/init.d/laptop_mode start
Actual Results:  
Daemon fails to start with message:
"Unhandled kernel version: 3.1"

Expected Results:  
Daemon should start successfully.

Error when starting daemon:
laptop_mode     |Unhandled kernel version: 3.1 ('uname -r' = '3.1.0-gentoo')

Output of emerge --info app-laptop/laptop-mode-tools
Portage 2.1.10.31 (default/linux/amd64/10.0/desktop/kde, gcc-4.5.3, glibc-2.12.2-r0, 3.1.0-gentoo x86_64)
=================================================================
                        System Settings
=================================================================
System uname: Linux-3.1.0-gentoo-x86_64-Intel-R-_Core-TM-2_Duo_CPU_P8700_@_2.53GHz-with-gentoo-2.1
Timestamp of tree: Wed, 26 Oct 2011 09:00:01 +0000
distcc 3.1 x86_64-pc-linux-gnu [enabled]
ccache version 2.4 [disabled]
app-shells/bash:          4.1_p9
dev-java/java-config:     2.1.11-r3::progress
dev-lang/python:          2.7.1-r1, 3.2.3_pre20111023::progress
dev-util/ccache:          2.4-r9
dev-util/cmake:           2.8.4-r1
dev-util/pkgconfig:       0.26
sys-apps/baselayout:      2.1
sys-apps/openrc:          0.9.4
sys-apps/sandbox:         2.4
sys-devel/autoconf:       2.13, 2.68
sys-devel/automake:       1.9.6-r3, 1.10.3, 1.11.1
sys-devel/binutils:       2.21.1-r1
sys-devel/gcc:            4.5.3-r1
sys-devel/gcc-config:     1.4.1-r1
sys-devel/libtool:        2.4-r1
sys-devel/make:           3.82-r1
sys-kernel/linux-headers: 2.6.39 (virtual/os-headers)
sys-libs/glibc:           2.12.2
Repositories: gentoo x11 progress
ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=core2 -mtune=core2 -mcx16 -msahf -msse4.1 -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt /usr/share/maven-bin-3.0/conf /usr/share/themes/oxygen-gtk/gtk-2.0 /var/lib/hsqldb"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-march=core2 -mtune=core2 -mcx16 -msahf -msse4.1 -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="assume-digests binpkg-logs distcc distlocks ebuild-locks fixlafiles news parallel-fetch protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch"
FFLAGS=""
GENTOO_MIRRORS="http://gentoo.mirror.pw.edu.pl/ http://de-mirror.org/distro/gentoo/ http://ftp-stud.fht-esslingen.de/pub/Mirrors/gentoo/ http://mirror.mdfnet.se/mirror/gentoo http://gentoo.mneisen.org/"
LANG="de_DE.utf8"
LC_ALL="de_DE.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="de"
MAKEOPTS="-j6"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/var/lib/layman/x11 /var/lib/layman/progress"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="X a52 aac acl acpi alsa also amd64 avahi avi berkdb branding bzip2 cairo cdaudio cdda cddb cdparanoia cdr cli consolekit cracklib crypt cups cxx dbus declarative dirac dri dts dvd dvdr emboss encode exif fam ffmpeg firefox flac fortran freetype ftp fuse gdbm gdu gif gimp git gpm iconv id3tag imap ipv6 java java6 jpeg kde kipi lame lcms ldap libnotify libv4l2 lm_sensors logrotate mad matroska mmx mmxext mng modules mp3 mp4 mpeg mplayer mudflap multilib musicbrainz ncurses nfs nls nptl nptlonly ogg oggvorbis opengl openmp pam pango pcre pdf phonon plasma png policykit ppds pppd qt3support qt4 quicktime readline rtsp samba sane schroedinger sdl semantic-desktop session skype spell sse sse2 ssl startup-notification subversion svg synaptics sysfs tcpd theora threads tiff truetype type1 udev unicode usb v4l v4l2 vnc vorbis vpx wifi wma x264 xcb xcomposite xine xinerama xml xmp xorg xscreensaver xulrunner xv xvid zeroconf zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan stage tables krita karbon braindump" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="evdev keyboard mouse synaptics" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="de" PHP_TARGETS="php5-3" RUBY_TARGETS="ruby18" USERLAND="GNU" VIDEO_CARDS="intel" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

=================================================================
                        Package Settings
=================================================================

app-laptop/laptop-mode-tools-1.55-r2 was built with the following:
USE="acpi (consolekit) (multilib) (policykit) -apm -bluetooth -scsi"
CFLAGS="-march=core2 -O2 -pipe"
CXXFLAGS="-march=core2 -O2 -pipe"
Comment 1 Erich Seifert 2011-10-26 13:02:05 UTC
Created attachment 290873 [details, diff]
Drop kernel version check from laptop-mode-tools 1.55

I backported upstream commit aa798a6ebbba which removes the check for kernel version as it was never used actually. This allows the daemon to start again.
Comment 2 Ulrich Müller gentoo-dev 2011-10-26 22:13:59 UTC
(In reply to comment #1)
> Created attachment 290873 [details, diff]
> Drop kernel version check from laptop-mode-tools 1.55

I believe that this patch is incomplete. There are additional tests for the kernel version in usr/share/laptop-mode-tools/modules/laptop-mode.
Comment 3 Erich Seifert 2011-10-27 00:29:18 UTC
Created attachment 290953 [details, diff]
Drop kernel version check from laptop-mode-tools 1.55 module

Added backport of upstream commit cf00a0a651d25f406ba6a825268916f737e38f20 which removes kernel version checks also from /usr/share/laptop-mode-tools/modules/laptop-mode. Best would be to do a version bump to laptop-mode-tools 1.58 or higher though.
Comment 4 Sven Eden 2011-10-31 19:31:14 UTC
With the two patches it works here.
Comment 5 Wicher Minnaard 2011-11-16 09:25:47 UTC
This is fixed upstream; bug #390709 bumps laptop-mode-tools to v1.60 .
Comment 6 Stefano Takekawa 2011-11-24 09:08:38 UTC
Created attachment 293609 [details, diff]
patch to make laptop-mode-tools-1.55 work with all 3.x kernels

IMHO, it is better not to prevent kernel version checking, so I propose this patch which should work with all 3.x kernels for laptop-mode-tools-1.55 until newer versions are in portage. At least it works on my laptop.
Comment 7 Markos Chandras (RETIRED) gentoo-dev 2012-01-01 15:57:27 UTC
Thanks for the patch but this is fixed by upstream in version 1.60. So closing this bug as WONTFIX