Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 38838 - Eclass howto suggests the use of newdepend in kde ebuilds
Summary: Eclass howto suggests the use of newdepend in kde ebuilds
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Sven Vermeulen (RETIRED)
URL: http://www.gentoo.org/doc/en/eclass-h...
Whiteboard:
Keywords:
Depends on: 25013
Blocks:
  Show dependency tree
 
Reported: 2004-01-20 12:46 UTC by Heinrich Wendel (RETIRED)
Modified: 2004-02-19 10:43 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to eclass-howto.xml (temp.diff,1.61 KB, patch)
2004-02-18 02:12 UTC, Sven Vermeulen (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Heinrich Wendel (RETIRED) gentoo-dev 2004-01-20 12:46:21 UTC
From the latest discussion on -dev i thought newdepend should only be used in eclasses, but the eclass howto says the following:


"The next stage is to add any extra deps. Remember: *always* extend variables, never override!

Because our goal is to avoid defining custom ebuild functions unless we have to, we set all the settings we can, and call all the helper functions we can, directly from the ebuild's main section. Remember though that there are limitations on code in the main section; for example, it must not produce any output (debug-print() output probably doesn't count though).

Code listing 3.2: A simple KDE ebuild, #2: adding extra dependencies

DEPEND="$DEPEND foo/bar"
RDEPEND="$RDEPEND bar/foo"

Alternatively, a newdepend() call will add a dep to both DEPEND and RDEPEND:

Code listing 3.3: A simple KDE ebuild, #3: using newdepend()

newdepend "foo? ( bar )""
Comment 1 SpanKY gentoo-dev 2004-01-20 14:52:35 UTC
i think we need to have this issue resolved first before we change the documentation

in other words, we NEED nick to weigh in on what future portages are going to do (Bug 25013)
Comment 2 Sven Vermeulen (RETIRED) gentoo-dev 2004-02-18 02:12:02 UTC
Created attachment 25840 [details, diff]
Patch to eclass-howto.xml

This patch removes the example ebuild that uses newdepend() and the newdepend
line used in another example.
Comment 3 Sven Vermeulen (RETIRED) gentoo-dev 2004-02-18 02:12:24 UTC
If someone can review?
Comment 4 SpanKY gentoo-dev 2004-02-18 19:53:40 UTC
yeah, but even the note on extending variables should be removed :)

eclasses should be of 'normal' style, exactly like an ebuild ... portage handles the merging of the lists

so if you could also change 'DEPEND="$DEPEND ...' to 'DEPEND="...' that'd be perfect
Comment 5 Sven Vermeulen (RETIRED) gentoo-dev 2004-02-19 10:43:27 UTC
Done and committed.