Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 382845 - sys-devel/make: glob speedups from upstream
Summary: sys-devel/make: glob speedups from upstream
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on: 383311
Blocks:
  Show dependency tree
 
Reported: 2011-09-13 16:42 UTC by Tomáš Chvátal (RETIRED)
Modified: 2011-09-17 23:29 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
glob-speedup.patch (make-glob-speedup.patch,2.69 KB, patch)
2011-09-13 16:42 UTC, Tomáš Chvátal (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tomáš Chvátal (RETIRED) gentoo-dev 2011-09-13 16:42:10 UTC
Created attachment 286365 [details, diff]
glob-speedup.patch

Hi, this patch from upstream speeds up globbing function by not actually doing it when it is not needed. Thus saving some precious cycles.

In libreoffice you get 60-20 secs speedups in avg.

See the attached patch from upstream repo.
Comment 1 SpanKY gentoo-dev 2011-09-17 04:28:46 UTC
what are the actual upstream commits ?  i see only:
http://cvs.savannah.gnu.org/viewvc/make/read.c?root=make&r1=1.198&r2=1.199
Comment 2 Tomáš Chvátal (RETIRED) gentoo-dev 2011-09-17 04:48:43 UTC
This attached diff is larger due to whitespace change for that case, otherwise they are both same, feel free to pick the one from upstream directly, obviously nobody bothered to rebase it at libreo repository :)
Comment 3 SpanKY gentoo-dev 2011-09-17 05:18:59 UTC
nm.  upstream viewvc ignores whitespace differences when showing patches.
Comment 4 SpanKY gentoo-dev 2011-09-17 05:22:10 UTC
should be all set now in the tree; thanks for the report!

Commit message: Add glob optimization patch from upstream
http://sources.gentoo.org/sys-devel/make/files/make-3.82-glob-speedup.patch?rev=1.1
http://sources.gentoo.org/sys-devel/make/make-3.82-r2.ebuild?rev=1.1
Comment 5 SpanKY gentoo-dev 2011-09-17 07:25:46 UTC
ive punted that version.  it breaks things like busybox.
Comment 6 Rafał Mużyło 2011-09-17 19:26:30 UTC
This seems to prove, that while picking up changes from upstream repos, it's good to read some of the following commits:
http://cvs.savannah.gnu.org/viewvc/make/read.c?root=make&r1=1.199&r2=1.200

The most amusing part of it is that the patch in comment 0 already included this change.
Comment 7 Tomáš Chvátal (RETIRED) gentoo-dev 2011-09-17 20:15:04 UTC
it said in the patch that it is r198 to r200 :)

I am reopening this as I will try to find out wtf went wrong (we really plan to rely on this stuff, so i need it for openSUSE at minimal (I will run tinderbox test in next few days for it).
Comment 8 SpanKY gentoo-dev 2011-09-17 20:52:54 UTC
the built in bugzilla viewvc browser trims metadata
Comment 9 SpanKY gentoo-dev 2011-09-17 23:29:46 UTC
should be all set now in the tree; thanks for the report!

Commit message: Add more complete glob optimization patch from upstream
http://sources.gentoo.org/sys-devel/make/files/make-3.82-glob-speedup.patch?rev=1.1
http://sources.gentoo.org/sys-devel/make/make-3.82-r3.ebuild?rev=1.1