Bug 380551 – dispatch-conf needs to depends on dev-vcs/rcs

• Status: RESOLVED FIXED
• Product: Portage Development

[Description Mathieu Z 2011-08-24 19:17:40 UTC]

When using dispatch-conf with use-rcs=yes option, if ci command is not available, it fails with
# dispatch-conf
dispatch-conf: Error finding all RCS utils and " +                         "use-rcs=yes in config; fatal

So, I think we should either make dispatch-conf have RDEPEND on dev-vcs/rcs, or put a warning in the comment above use-rcs=yes line to remind users to emerge it.

Reproducible: Always

[Comment 1 Zac Medico 2012-09-06 20:08:45 UTC]

We can't add a dependency since we don't have support for "suggested deps" yet. So, I've added a comment to dispatch-conf.conf like you suggested:

http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=40c0d7c86f83ff9a1507d030ffc29697df0e3274

[Comment 2 SpanKY 2012-09-06 21:23:28 UTC]

we can change the script to run `rcs --version` first and bail early if it doesn't exist ...

[Comment 3 Zac Medico 2012-09-06 21:33:33 UTC]

(In reply to comment #2)
> we can change the script to run `rcs --version` first and bail early if it
> doesn't exist ...

It does something like that already. The code looks like this:

        if self.options['use-rcs'] == 'yes':
            for rcs_util in ("rcs", "ci", "co", "rcsmerge"):
                if not find_binary(rcs_util):
                    print('dispatch-conf: Error finding all RCS utils and " + \
                        "use-rcs=yes in config; fatal', file=sys.stderr)
                    return False

[Comment 4 Zac Medico 2012-09-08 23:50:51 UTC]

This is fixed in 2.1.11.14 and 2.2.0_alpha125.