Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 379663 - media-sound/qsampler fails because of underlinking
Summary: media-sound/qsampler fails because of underlinking
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Highest normal (vote)
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: underlinking
  Show dependency tree
 
Reported: 2011-08-18 06:38 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2012-05-30 19:36 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Build log (qsampler-0.2.2:20110818-030332.log,26.49 KB, text/plain)
2011-08-18 06:38 UTC, Diego Elio Pettenò (RETIRED)
Details
qsampler-0.2.2-build.patch (qsampler-0.2.2-build.patch,1.26 KB, patch)
2011-12-26 12:55 UTC, Michael Palimaka (kensington)
Details | Diff
qsampler-0.2.2-r1.patch (qsampler-0.2.2-r1.patch,1.43 KB, patch)
2011-12-26 13:25 UTC, Michael Palimaka (kensington)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2011-08-18 06:38:50 UTC
Created attachment 283717 [details]
Build log

Hello there!

You're getting this bug because the package in Summary failed to build in my tinderbox using the gold link editor from binutils. Before closing the bug as INVALID let me explain why this is still important!

The gold link editor does not support underlinking of shared objects, which is something I have described in my blog post:

http://blog.flameeyes.eu/2010/11/26/it-s-not-all-gold-that-shines-why-underlinking-is-a-bad-thing

Even the basic link editor (ld.bfd) has an option to support this but it is a heck to enable and get passed, so linking with gold is simply quicker.

Fixing underlinking provides optimized --as-needed builds (because the "softer" version no longer need to recover libraries that are underlinked), so it is a Good Thing To Do.

Thank you very much for the attention!
Comment 1 Michael Palimaka (kensington) gentoo-dev 2011-12-26 12:55:52 UTC
Created attachment 296979 [details, diff]
qsampler-0.2.2-build.patch

Patch to fix underlinking, as well as respect CC/CFLAGS/LDFLAGS/$(MAKE).
Comment 2 Michael Palimaka (kensington) gentoo-dev 2011-12-26 13:25:11 UTC
Created attachment 296989 [details, diff]
qsampler-0.2.2-r1.patch

Also, EAPI bump and fix deps.
Comment 3 Ben de Groot (RETIRED) gentoo-dev 2012-05-30 13:48:59 UTC
Fixed in qsampler-0.2.2.2345 snapshot ebuild. Thanks for your contributions!
Comment 4 Pacho Ramos gentoo-dev 2012-05-30 19:36:50 UTC
(In reply to comment #3)
> Fixed in qsampler-0.2.2.2345 snapshot ebuild. Thanks for your contributions!