Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 376665 - media-sound/amsynth-1.2.3 does not respect CFLAGS
Summary: media-sound/amsynth-1.2.3 does not respect CFLAGS
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal minor (vote)
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 360597
  Show dependency tree
 
Reported: 2011-07-27 23:09 UTC by Agostino Sarubbo
Modified: 2011-09-18 16:22 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
amsynth-1.2.3-cflags.patch (x.patch,2.83 KB, text/plain)
2011-08-10 17:59 UTC, Agostino Sarubbo
Details
proposed patch (amsynth-1.2.3-cflags.patch,732 bytes, patch)
2011-08-10 19:03 UTC, Markos Chandras (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2011-07-27 23:09:31 UTC
As per $summary:

x86_64-pc-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I..    -march=native -O2 -Wall -W -g -Wall -D_DEBUG -O3 -ffast-math -fno-exceptions -fomit-frame-pointer -Dwith_oss -Dwith_alsa -Dwith_jack -Dwith_sndfile -DENABLE_BINRELOC -march=native -O2 -Wall -W -g -Wall -D_DEBUG -O3 -ffast-math -fno-exceptions -fomit-frame-pointer -Dwith_oss -Dwith_alsa -Dwith_jack -Dwith_sndfile -MT amSynth-main.o -MD -MP -MF .deps/amSynth-main.Tpo -c -o amSynth-main.o `test -f 'main.cc' || echo './'`main.cc

amd64box maildrop # emerge --info | grep CXX
CXXFLAGS="-march=native -O2"

Please drop -O3 -g -fomit-frame-pointers and that do you think is more.
Comment 1 Markos Chandras (RETIRED) gentoo-dev 2011-08-10 15:40:34 UTC
Fixed
Comment 2 Samuli Suominen (RETIRED) gentoo-dev 2011-08-10 17:00:16 UTC
the committed patch is bogus as it drops upstream preprocessor flag -D_DEBUG to enable different codepath, then it removes warning flags hiding also portage QA warnings

you can remove -O3 since it's unsafe taking account different gcc versions, and different arches
and -g since it's up to user to set -g -ggdb and to what level
but leave the other optimization flags in too, upstream has specifically picked them to be compatible with his code, and unless we get a bug report about them, there is absolutely no need to remove them
Comment 3 Markos Chandras (RETIRED) gentoo-dev 2011-08-10 17:08:43 UTC
Right. Sorry about that. I removed the patch for now. I will try to come up with an improved patch when I get back home
Comment 4 Agostino Sarubbo gentoo-dev 2011-08-10 17:59:45 UTC
Created attachment 282849 [details]
amsynth-1.2.3-cflags.patch

this patch works for me. Dropped also -fomit-frame-pointers.
Comment 5 Markos Chandras (RETIRED) gentoo-dev 2011-08-10 19:03:08 UTC
Created attachment 282865 [details, diff]
proposed patch

patch based on Samuli's suggestions
Comment 6 Agostino Sarubbo gentoo-dev 2011-08-24 13:32:29 UTC
Markos, your patch works for me and respect that samuli sayd. You can commit, imho.
Comment 7 Tony Vroon (RETIRED) gentoo-dev 2011-08-30 09:36:55 UTC
+*amsynth-1.2.3-r1 (30 Aug 2011)
+
+  30 Aug 2011; Tony Vroon <chainsaw@gentoo.org> +amsynth-1.2.3-r1.ebuild,
+  +files/amsynth-1.2.3-respect-cflags.patch:
+  Revision bump for EAPI 4 porting and CFLAGS respect patch by Markos
+  "hwoarang" Chandros with input from Samuli Suominen in bug #376665 filed by
+  Agostino "ago" Sarubbo.