Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 375797 - app-emulation/wine: should use pax-mark instead of calling paxctl directly
Summary: app-emulation/wine: should use pax-mark instead of calling paxctl directly
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Wine Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 375561 404329
  Show dependency tree
 
Reported: 2011-07-20 19:46 UTC by Anthony Basile
Modified: 2012-02-21 04:18 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Anthony Basile gentoo-dev 2011-07-20 19:46:39 UTC
All ebuilds for app-emulation/wine currently do pax markings on /usr/bin/wine{,-preloader} by calling paxctl directly in the pkg_postinst() phase.  Since paxctl is not necessarily installed on the user's system, this is not a good approach.  A better approach would be to inherit pax-utils.eclass and use pax-mark instead, since it has the intelligence to use paxctl if available or fall back on scanelf otherwise, which is guaranteed to be present because of the profiles.  It might also be a better idea to use pax-mark in the src_install() phase.

Reproducible: Always
Comment 1 Alexandre Rostovtsev (RETIRED) gentoo-dev 2012-02-21 04:18:00 UTC
Fixed in 1.4_rc4, thanks for reporting.

>*wine-1.4_rc4 (21 Feb 2012)
>
>  21 Feb 2012; Alexandre Rostovtsev <tetromino@gentoo.org>
>  +wine-1.4_rc4.ebuild, wine-9999.ebuild:
>  Bump, see http://www.winehq.org/announce/1.4-rc4 for the announcement. Add
>  /usr/bin/wine and wine-preloader symlinks for win64-only installs (bug
>  #404331, thanks to Zhang Hongjiu). Add odbc USE flag to pull in unixODBC
>  runtime dep (bug #404507, thanks to Andreas Sturmlechner). Use pax-mark (bug
>  #375797, thanks to Anthony Basile) and mark win64 binaries (bug #404329,
>  thanks to Zhang Hongjiu). Add a die in src_configure when intel opencl is
>  selected to help with bug #403947 (thanks to candrews and Kacper Kowalik).