Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 374015 - x11-misc/xdg-utils-1.1.0_rc1-r1: bashism in xdg-open
Summary: x11-misc/xdg-utils-1.1.0_rc1-r1: bashism in xdg-open
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Freedesktop bugs
URL: http://cgit.freedesktop.org/xdg/xdg-u...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-04 09:17 UTC by Faustus
Modified: 2011-10-03 09:12 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
files/xdg-utils-1.1.0_rc1_p20110519-bashism.patch (xdg-utils-1.1.0_rc1_p20110519-bashism.patch,7.28 KB, patch)
2011-07-27 12:10 UTC, Naohiro Aota
Details | Diff
xdg-utils-1.1.0_rc1_p20110519.ebuild.patch (xdg-utils-1.1.0_rc1_p20110519.ebuild.patch,866 bytes, patch)
2011-07-27 12:15 UTC, Naohiro Aota
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Faustus 2011-07-04 09:17:27 UTC
elif [ x"$DESKTOP_SESSION" == x"LXDE" ]; then DE=lxde;

"==" should be "="

That line produces an error in dash.
Comment 1 Faustus 2011-07-05 16:29:53 UTC
From the freedesktop.org bug report:

Comment #1 from Rex Dieter <rdieter@math.unl.edu> 2011-07-05 09:25:17 PDT ---
this is fixed in git, that code was refactored into a case statement to no
longer include any explicit == or = comparisons

I suggest patching the script in the meanwhile.
Comment 2 Naohiro Aota gentoo-dev 2011-07-27 12:10:57 UTC
Created attachment 281131 [details, diff]
files/xdg-utils-1.1.0_rc1_p20110519-bashism.patch
Comment 3 Naohiro Aota gentoo-dev 2011-07-27 12:15:03 UTC
Created attachment 281133 [details, diff]
xdg-utils-1.1.0_rc1_p20110519.ebuild.patch

freedesktop team,

This patch apply the above replacing '==' with '=' to the source
tree. If there's no problem with the patch, I'd like to apply it.

Thanks,
Comment 4 Samuli Suominen (RETIRED) gentoo-dev 2011-07-27 20:32:12 UTC
Are you sure it's reported, let alone fixed at upstream yet?
Looking at [1], I'm seeing a lot lines with == syntax

[1] http://cgit.freedesktop.org/xdg/xdg-utils/tree/scripts/xdg-desktop-icon

Please report to upstream & apply the patch in portage :)
Comment 5 Faustus 2011-07-28 10:02:42 UTC
It has been reported (see the bug in "See Also"), and claimed as fixed, but I reopened the bug now.
http://bugs.freedesktop.org/show_bug.cgi?id=38959
Comment 6 Faustus 2011-08-25 04:25:03 UTC
The upstream says it's fixed now (see the URL above).
Comment 7 Samuli Suominen (RETIRED) gentoo-dev 2011-10-03 09:12:47 UTC
+*xdg-utils-1.1.0_rc1_p20111003 (03 Oct 2011)
+
+  03 Oct 2011; Samuli Suominen <ssuominen@gentoo.org>
+  +xdg-utils-1.1.0_rc1_p20111003.ebuild:
+  New snapshot for solving bugs #367993 (x-scheme-handler) and #374015
+  (bashism). Thanks to Cyprien Nicolas, Naohiro Aota and "Faustus".