Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 372671 - mail-mta/exim-4.76 uses deprecated --oknodo of start-stop-daemon
Summary: mail-mta/exim-4.76 uses deprecated --oknodo of start-stop-daemon
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Fabian Groffen
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: s-s-d-deprecated
  Show dependency tree
 
Reported: 2011-06-23 10:30 UTC by Marcel Pennewiß
Modified: 2011-08-16 17:16 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
exim.rc6.patch (exim.rc6.patch,351 bytes, patch)
2011-06-29 13:40 UTC, Marcel Pennewiß
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel Pennewiß 2011-06-23 10:30:45 UTC
exim init-script uses --oknodo from start-stop-daemon for reloading. --oknodo is dprecated.

Reproducible: Always

Steps to Reproduce:
1. emerge mail-mta/exim
2. start exim
3. reload exim (/etc/init.d/exim reload)
Actual Results:  
 * Reloading exim ...
 * WARNING: -o/--oknodo is deprecated and will be removed in the future                                                                              [ ok ]

Expected Results:  
 * Reloading exim ...

Portage 2.1.9.42 (default/linux/amd64/10.0, gcc-4.4.5, libc-0-r0, 2.6.34-xen-r4 x86_64)
=================================================================
System uname: Linux-2.6.34-xen-r4-x86_64-AMD_Opteron-tm-_Processor_252-with-gentoo-2.0.3
Timestamp of tree: Thu, 23 Jun 2011 08:15:01 +0000
distcc 3.1 x86_64-pc-linux-gnu [disabled]
app-shells/bash:     4.1_p9
dev-lang/python:     2.6.6-r2, 2.7.1-r1, 3.1.3-r1
sys-apps/baselayout: 2.0.3
sys-apps/openrc:     0.8.3
sys-apps/sandbox:    2.4
sys-devel/autoconf:  2.65-r1
sys-devel/automake:  1.11.1
sys-devel/binutils:  2.20.1-r1
sys-devel/gcc:       4.4.5
sys-devel/gcc-config: 1.4.1-r1
sys-devel/libtool:   2.2.10
sys-devel/make:      3.82
sys-kernel/linux-headers: 2.6.36.1
sys-libs/glibc:      2.12.2
virtual/os-headers:  0
ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=opteron -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/openvpn/easy-rsa"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-march=opteron -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="assume-digests binpkg-logs distlocks fixlafiles fixpackages news parallel-fetch protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch"
FFLAGS=""
GENTOO_MIRRORS="http://gentoo-portage.fem.tu-ilmenau.de/mirror/gentoo http://ftp.tu-ilmenau.de/mirror/gentoo"
LANG="de_DE.utf-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/var/lib/layman/fem-overlay /var/lib/layman/raw"
SYNC="rsync://gentoo-portage.fem.tu-ilmenau.de/gentoo-portage"
USE="acl amd64 berkdb bzip2 cli cracklib crypt cups cxx dri fortran gdbm gpm iconv ipv6 mmx modules mudflap multilib ncurses nls nptl nptlonly openmp pam pcre perl pppd python readline session sse sse2 ssl sysfs tcpd threads unicode xorg zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="braindump flow karbon kexi kpresenter krita tables words" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" PHP_TARGETS="php5-3" RUBY_TARGETS="ruby18" USERLAND="GNU" VIDEO_CARDS="fbdev glint intel mach64 mga neomagic nouveau nv r128 radeon savage sis tdfx trident vesa via vmware dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account" 
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, LINGUAS, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 1 Marcel Pennewiß 2011-06-29 13:18:53 UTC
JFYI: deprecation message was added in sys-apps/openrc-0.8.3
Comment 2 Marcel Pennewiß 2011-06-29 13:40:57 UTC
Created attachment 278621 [details, diff]
exim.rc6.patch

fix for init-script in files-directory
Comment 3 Fabian Groffen gentoo-dev 2011-06-29 20:01:30 UTC
hmmm, and this does the same? (--stop argument is removed as well?)
Comment 4 Marcel Pennewiß 2011-06-30 04:47:00 UTC
exactly, see start-stop-daemon.c:
...

        /* Allow start-stop-daemon --signal HUP --exec /usr/sbin/dnsmasq
         * instead of forcing --stop --oknodo as well */
        if (!start &&
            !stop &&
            sig != SIGINT &&
            sig != SIGTERM &&
            sig != SIGQUIT &&
            sig != SIGKILL)
                oknodo = true;

...
Comment 5 Christian Ruppert (idl0r) gentoo-dev 2011-07-01 13:56:36 UTC
--stop has not been removed its just useless/not what you want in this case.
Also the --quiet seems to be not necessary here.
start-stop-daemon --signal HUP --pidfile /var/run/exim.pid --name exim
That should be enough.
Comment 6 Fabian Groffen gentoo-dev 2011-07-01 14:44:01 UTC
idl0r, if you are confident about the change, could you please fix it for me?
Comment 7 Christian Ruppert (idl0r) gentoo-dev 2011-07-01 18:18:45 UTC
(In reply to comment #6)
> idl0r, if you are confident about the change, could you please fix it for me?

Hm, that will break compatibility to baselayout1.
Either we wait until its officially deprecated/obsolete or I patch it anyway.
Please ping me in IRC when you're online :P
Comment 8 Fabian Groffen gentoo-dev 2011-08-05 09:03:49 UTC
I think it would ok to implement this in 4.76-r1 (probably with revbump, I unfortunately forgot about this bug yesterday :( ), exim.rc7 that is.

Would you care to commit the necessary changes?
Comment 9 Christian Ruppert (idl0r) gentoo-dev 2011-08-16 16:52:03 UTC
(In reply to comment #8)
> I think it would ok to implement this in 4.76-r1 (probably with revbump, I
> unfortunately forgot about this bug yesterday :( ), exim.rc7 that is.
> 
> Would you care to commit the necessary changes?

Done.
Comment 10 Fabian Groffen gentoo-dev 2011-08-16 17:16:31 UTC
thanks, looks fixed to me then.

Re-emerge -r1 if you want/need this change and are on ~arch