Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 372321 - sys-kernel/gentoo-sources-2.6.38: Build failure in nouveau_acpi.c
Summary: sys-kernel/gentoo-sources-2.6.38: Build failure in nouveau_acpi.c
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: x86 Linux
: Normal normal (vote)
Assignee: Gentoo Kernel Bug Wranglers and Kernel Maintainers
URL: https://bugzilla.kernel.org/show_bug....
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-20 05:52 UTC by Alexey Mishustin
Modified: 2013-12-23 16:19 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
My kernel 2.6.38 .config (.config,77.71 KB, text/plain)
2011-06-20 05:55 UTC, Alexey Mishustin
Details
CONFIG_ACPI_VIDEO build failure patch (acpi_video_build_failure.patch,985 bytes, patch)
2011-06-22 13:19 UTC, Stratos Psomadakis (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Mishustin 2011-06-20 05:52:59 UTC
Hi. I cannot compile a 2.6.38 kernel (and 2.6.37 too) with Nouveau support. I always get the error

  drivers/built-in.o: In function `nouveau_acpi_edid':
  (.text+0xd6a00): undefined reference to `acpi_video_get_edid'

I have googled, found discussions like that -
http://us.generation-nt.com/answer/patch-nouveau-build-regression-undefined-reference-acpi-video-get-edid-help-200299821.html
- but it didn't help.

Chí-Thanh Christopher Nguyễn said ( http://bugs.gentoo.org/show_bug.cgi?id=357763 ) that this error shouldn't happen, "unless I messed around manually in .config or neglected to run make oldconfig".

But I didn't edit .config manually. I created my .config by `zcat /proc/config.gz` with the current Minimal CD running, then `make menuconfig`.

Please help.

Reproducible: Always

Steps to Reproduce:
1. Take my .config (or `zcat /proc/config.gz > /usr/src/linux/.config` with the current Minimal CD running)
2. make menuconfig
3. make && make modules_install
Actual Results:  
Kernel is not compiled because of error
  drivers/built-in.o: In function `nouveau_acpi_edid':
  (.text+0xd6a00): undefined reference to `acpi_video_get_edid'

Expected Results:  
Kernel is not compiled
Comment 1 Alexey Mishustin 2011-06-20 05:55:56 UTC
Created attachment 277567 [details]
My kernel 2.6.38 .config
Comment 2 Alexey Mishustin 2011-06-20 06:02:20 UTC
To be exact,

1. Take my .config (or `zcat /proc/config.gz > /usr/src/linux/.config` with the
current Minimal CD running)
2. make menuconfig __(and turn on Nouveau support, if you ran zcat)__
3. make && make modules_install
Comment 3 Chí-Thanh Christopher Nguyễn gentoo-dev 2011-06-22 09:05:39 UTC
It is possible that nouveau has not specified all dependencies properly in the Kconfig. Find out which kernel option is behind acpi_video_get_edid (presumably ACPI_VIDEO) and make sure that it is enabled built-in.

Your problem may be related to http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=c42988012ad9c1807b7c7a5ff855cd630094989b and the fact that you have CONFIG_VIDEO_OUTPUT_CONTROL=m
Comment 4 Stratos Psomadakis (RETIRED) gentoo-dev 2011-06-22 09:48:41 UTC
(In reply to comment #3)
> It is possible that nouveau has not specified all dependencies properly in the
> Kconfig. Find out which kernel option is behind acpi_video_get_edid (presumably
> ACPI_VIDEO) and make sure that it is enabled built-in.
> 
> Your problem may be related to
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=c42988012ad9c1807b7c7a5ff855cd630094989b
> and the fact that you have CONFIG_VIDEO_OUTPUT_CONTROL=m

I think that this is indeed what causes the build failure.

I'd suggest reporting the issue upstream (either at bugzilla.kernel.org or directly at the nouveau mailing list [1]).

In the meantime, setting CONFIG_VIDEO_OUTPUT_CONTROL to y will most likely resolve the build failure. 

If you report this upstream, please report back at this bug with the URL of the upstream bug report.
Comment 5 Alexey Mishustin 2011-06-22 12:59:22 UTC
Thank you for your replies. I'll be able to check if setting CONFIG_VIDEO_OUTPUT_CONTROL to y will resolve my problem, tonight.

I have reported this issue upstream. The link is https://bugzilla.kernel.org/show_bug.cgi?id=38052
Comment 6 Stratos Psomadakis (RETIRED) gentoo-dev 2011-06-22 13:19:18 UTC
Created attachment 277761 [details, diff]
CONFIG_ACPI_VIDEO build failure patch

I think this could resolve the build failure. I'll post it to the upstream bug too, and at the nouveau mailing list. 

Btw, could you add kernel@gentoo.org at the CC address at bugzilla.kernel.org?

Thanks.
Comment 7 Alexey Mishustin 2011-06-22 13:41:04 UTC
>Btw, could you add kernel@gentoo.org at the CC address at bugzilla.kernel.org?

Done.
Comment 8 Alexey Mishustin 2011-06-22 19:17:23 UTC
It works!

Thanks a lot!

*Best Regards*
Comment 9 Mike Pagano gentoo-dev 2011-12-11 19:05:58 UTC
Should we repoke on the mailing list?

http://lists.freedesktop.org/archives/nouveau/2011-June/008585.html
Comment 10 Mike Pagano gentoo-dev 2012-03-04 21:00:12 UTC
Closing, not sure if this issue still exists or this patch or something similar was ever committed.
Comment 11 Carter Young 2012-03-29 21:02:13 UTC
can we get this patch into the tree and re-open this bug as the build failure is happening in the 3.2.12 gentoo sources?  Ran genkernel twice and happened both times.  I could get around it if I were to disable ACPI but then the monitor would never sleep.  I'll stick to the nvidia-drivers until this is fixed.
Comment 12 Mike Pagano gentoo-dev 2012-03-29 23:36:45 UTC
We only commit patches from upstream. This would need to be accepted into the upstream repositories, and at that point, we can include in gentoo-sources.

Q. Will you apply [some kernel patch]? 
If it's a serious and non-intrusive bugfix that has been accepted into the upstream development kernel, then usually yes (please open a bug). Otherwise, generally the answer is no - instead of getting new features added to our kernel, we'd prefer you to contact the authors of that code and get them to finish off their work and submit it to the mainline kernel so that everyone can benefit.
Comment 13 Carter Young 2012-03-30 00:47:10 UTC
(In reply to comment #12)
> 
> Q. Will you apply [some kernel patch]? 
> If it's a serious and non-intrusive bugfix that has been accepted into the
> upstream development kernel, then usually yes (please open a bug).
> Otherwise, generally the answer is no - instead of getting new features
> added to our kernel, we'd prefer you to contact the authors of that code and
> get them to finish off their work and submit it to the mainline kernel so
> that everyone can benefit.

That is fine if that is policy, but would you please reconsider opening the bug so that others who are smart enough to google find an open bug.

I can confirm that disabling the nouveau driver in the staging area solves the issue
Comment 14 Mike Pagano gentoo-dev 2012-03-30 22:21:52 UTC
that would be fine.
Comment 15 Mike Pagano gentoo-dev 2012-09-08 23:12:28 UTC
As a workaround, can you try to build with 

CONFIG_VIDEO_OUTPUT_CONTROL=y,
CONFIG_ACPI_VIDEO=y
Comment 16 Carter Young 2012-10-10 14:19:10 UTC
(In reply to comment #15)
> As a workaround, can you try to build with 
> 
> CONFIG_VIDEO_OUTPUT_CONTROL=y,
> CONFIG_ACPI_VIDEO=y

Will Test later on this weekend  Updating System after 6 months of no updates takes awhile, please leave in test request atatus
Comment 17 Ben Kohler gentoo-dev 2013-02-21 21:31:02 UTC
(In reply to comment #15)
> As a workaround, can you try to build with 
> 
> CONFIG_VIDEO_OUTPUT_CONTROL=y,
> CONFIG_ACPI_VIDEO=y

The above workaround does fix things here, but I believe the bug should stay open until there is a proper fix.  All that's needed to reproduce this bug is:

1.  genkernel --menuconfig all
2.  set CONFIG_DRM=y
3.  set CONFIG_DRM_NOUVEAU=y
4.  save/exit/build

Lots of users are still hitting this bug.
Comment 18 Tom Wijsman (TomWij) (RETIRED) gentoo-dev 2013-03-26 17:50:58 UTC
(In reply to comment #13)
> That is fine if that is policy, but would you please reconsider opening the
> bug so that others who are smart enough to google find an open bug.

They won't find it, regardless of its state. https://bugs.gentoo.org/robots.txt

(In reply to comment #17)
> Lots of users are still hitting this bug.

Not much people are on CC. Is this bug still present in the latest kernels?