Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 367445 - double signing on repoman commit
Summary: double signing on repoman commit
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Repoman (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 431026
  Show dependency tree
 
Reported: 2011-05-15 23:02 UTC by Angelo Arrifano (RETIRED)
Modified: 2013-02-12 18:40 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Angelo Arrifano (RETIRED) gentoo-dev 2011-05-15 23:02:08 UTC
$ FEATURES="sign" repoman commit
(enter ssh passphrase)
(enter gpg passphrase)
*signing*
(cancel commit before entering ssh passphrase again)

$ FEATURES="sign" repoman commit
(enter ssh passphrase)
(enter gpg passphrase)
*signing*
(enter ssh passphrase again)
*commiting*

and there, you just double signed the Manifest. This just happened to me with the package gpe-base/libgpewidget (look at it for an example). It would probably not happen if I was using a ssh-agent though.
Comment 1 Zac Medico gentoo-dev 2011-05-15 23:10:36 UTC
The Manifest.write() method avoids unnecessary writes by parsing the existing Manifest and comparing the entries to the data that would be written. This is good since we can call Manifest.write() and trust that it won't do unnecessary writes and also that it won't unnecessarily discard an existing signature. What we need is an additional mode for repoman to use during commits, that will discard the existing signature when we are planning to generate a new signature.