364105 – emerge-webrsync should respect PORTAGE_RSYNC_OPTS

Bug 364105 - emerge-webrsync should respect PORTAGE_RSYNC_OPTS

Summary: emerge-webrsync should respect PORTAGE_RSYNC_OPTS

Status:	RESOLVED FIXED

Alias:	None

Product:	Portage Development
Classification:	Unclassified
Component:	Tools (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Portage team

URL:
Whiteboard:
Keywords:	InVCS

Depends on:
Blocks:	431026
	Show dependency tree

Reported:	2011-04-19 08:05 UTC by Jan Pobrislo
Modified:	2012-11-07 13:47 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
patch enabling PORTAGE_RSYNC_OPTS (webrsync.patch,686 bytes, text/plain) 2011-04-19 08:05 UTC, Jan Pobrislo	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jan Pobrislo 2011-04-19 08:05:56 UTC

Created attachment 270493 [details]
patch enabling PORTAGE_RSYNC_OPTS

emerge-webrsync has hardcoded --verbose flag which makes it hassle to run it from cron which produces mail output, and unnecessarily duplicates the default PORTAGE_RSYNC_OPTS from /etc/make.conf

possible fixes are either to simply reuse PORTAGE_RSYNC_OPTS, or remove the -v rsync flag, when emerge-webrsync is ran with -q flag. A patch for former fix is attached.

Comment 1 Zac Medico gentoo-dev

2012-08-15 03:04:27 UTC

Thanks, this is in git:

http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=e672b5ccbbbe38eda5c733fc799a20d92a8bdf75

Comment 2 Zac Medico gentoo-dev

2012-08-22 23:45:14 UTC

This is fixed in 2.1.11.11 and 2.2.0_alpha122.

Comment 3 Alexander Tsoy 2012-11-07 13:35:21 UTC

'--owner' argument should be forcibly added. Whithout it the chown in emerge-webrsync is completely useless - all files is transferring in PORTDIR with the root ownership anyway.

Comment 4 Alexander Tsoy 2012-11-07 13:47:03 UTC

I've opened a new Bug 442190