Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 361089 - dev-lang/v8-3.1.8.3 in prefix passes env overrides incorrectly
Summary: dev-lang/v8-3.1.8.3 in prefix passes env overrides incorrectly
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Prefix Support (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Prefix
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-29 10:51 UTC by Asfand Yar Qazi
Modified: 2011-05-01 16:55 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Fix the way importenv is used (fix-importenv-passing.patch,594 bytes, text/plain)
2011-03-29 10:51 UTC, Asfand Yar Qazi 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Asfand Yar Qazi 2011-03-29 10:51:43 UTC 
Created attachment 267667 [details]
Fix the way importenv is used

LINKFLAGS is meant to be passed from the environment, but to fix SCons PATH hard-coding design decision, we also need to pass PATH through.

Quotes were being passed through as part of the arguments before.

Patch attached
Comment 1 Fabian Groffen gentoo-dev 2011-04-23 14:55:00 UTC 
@chromium: patch looks pretty much ok to me, is it ok to apply to latest version and 9999?
Comment 2 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2011-05-01 15:55:29 UTC 
(In reply to comment #1)
> @chromium: patch looks pretty much ok to me, is it ok to apply to latest
> version and 9999?

LGTM (Looks Good To Me). Please make sure it is really needed, I'm not sure what problem it's fixing. If in doubt, let's postpone applying until we know what's going on.

Sorry for the delayed reply. Feel free to ping me on e-mail on irc.
Comment 3 Fabian Groffen gentoo-dev 2011-05-01 16:55:45 UTC 
Added PATH to the importenv thing for Prefix users