Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 360459 - repoman should check for gpg key validity before doing anything else
Summary: repoman should check for gpg key validity before doing anything else
Status: RESOLVED DUPLICATE of bug 298605
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Repoman (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-25 18:17 UTC by SpanKY
Modified: 2013-06-27 19:06 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description SpanKY gentoo-dev 2011-03-25 18:17:26 UTC
when someone's gpg key expires, repoman will make all the normal commits, and then the key issue will be noticed only when the manifest is regenerated.  this leaves a window where the changes have been pushed up but not the manifest, and it could take some time for the dev to fix things.

similarly, when a password is required, the user is prompted for it after the initial commit.  we can really only handle this if people are using gpg-agent, as prompting for the key otherwise wont cache the result for the 2nd usage.

so, if the user has PORTAGE_GPG_KEY set, repoman should, before making any commits, do the following:
 - verify the key is still valid (not expired)
 - if gpg-agent is available (look for env GPG_AGENT_INFO), attempt to use the key so the password prompt comes up before anything is committed
Comment 1 SpanKY gentoo-dev 2011-03-25 18:20:16 UTC
and if we can verify gpg-agent is active, make sure that the current signing settings will not result in a SHA1 digest.  not sure if we could find this out just by running `gpg` itself though and asking for its current settings ...
Comment 2 SpanKY gentoo-dev 2011-03-25 18:35:00 UTC
once the commit has been done, it'd be good if repoman also checked for the expiration of the key.  if it is coming up soon (like 1 week or something), issue a warning that their key is going to expire soon.
Comment 3 Jan Matějka (RETIRED) gentoo-dev 2013-06-27 19:06:08 UTC

*** This bug has been marked as a duplicate of bug 298605 ***